Sfoglia il codice sorgente

Other: Remove todos.

Maciej Gołaszewski 7 anni fa
parent
commit
0e642d1c9a

+ 0 - 1
packages/ckeditor5-table/src/converters/downcast.js

@@ -395,7 +395,6 @@ function createViewTableCellElement( tableWalkerValue, tableAttributes, insertPo
 
 
 			conversionApi.mapper.bindElements( tableCell, cellElement );
 			conversionApi.mapper.bindElements( tableCell, cellElement );
 		} else {
 		} else {
-			// TODO: binding two to one seems supspicious...
 			conversionApi.mapper.bindElements( tableCell, cellElement );
 			conversionApi.mapper.bindElements( tableCell, cellElement );
 			conversionApi.mapper.bindElements( innerParagraph, cellElement );
 			conversionApi.mapper.bindElements( innerParagraph, cellElement );
 		}
 		}

+ 0 - 1
packages/ckeditor5-table/tests/_utils/utils.js

@@ -246,7 +246,6 @@ function makeRows( tableData, options ) {
 				let resultingCellElement = cellElement;
 				let resultingCellElement = cellElement;
 
 
 				if ( isObject ) {
 				if ( isObject ) {
-					// TODO: check...
 					if ( tableCellData.isHeading ) {
 					if ( tableCellData.isHeading ) {
 						resultingCellElement = headingElement;
 						resultingCellElement = headingElement;
 					}
 					}

+ 0 - 1
packages/ckeditor5-table/tests/converters/downcast.js

@@ -495,7 +495,6 @@ describe( 'downcast converters', () => {
 					writer.insert( writer.createElement( 'tableCell' ), firstRow, 'end' );
 					writer.insert( writer.createElement( 'tableCell' ), firstRow, 'end' );
 				} );
 				} );
 
 
-				// TODO check span always?
 				expect( formatTable(
 				expect( formatTable(
 					getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
 					getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
 					'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
 					'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +

+ 1 - 2
packages/ckeditor5-table/tests/manual/tableblockcontent.js

@@ -19,8 +19,7 @@ ClassicEditor
 		plugins: [ ArticlePluginSet, Table, TableToolbar, Alignment, Image, ImageCaption, ImageStyle ],
 		plugins: [ ArticlePluginSet, Table, TableToolbar, Alignment, Image, ImageCaption, ImageStyle ],
 		toolbar: [
 		toolbar: [
 			'heading', '|', 'insertTable', '|', 'bold', 'italic', 'bulletedList', 'numberedList', 'blockQuote',
 			'heading', '|', 'insertTable', '|', 'bold', 'italic', 'bulletedList', 'numberedList', 'blockQuote',
-			'alignment', 'insertImage',
-			'|', 'undo', 'redo'
+			'alignment', '|', 'undo', 'redo'
 		],
 		],
 		image: {
 		image: {
 			toolbar: [ 'imageStyle:full', 'imageStyle:side', '|', 'imageTextAlternative' ]
 			toolbar: [ 'imageStyle:full', 'imageStyle:side', '|', 'imageTextAlternative' ]