Browse Source

Move jumpOverInlineFiller since it is context less.

Piotr Jasiun 9 years ago
parent
commit
0cee15256a
1 changed files with 22 additions and 27 deletions
  1. 22 27
      packages/ckeditor5-engine/src/treeview/treeview.js

+ 22 - 27
packages/ckeditor5-engine/src/treeview/treeview.js

@@ -89,7 +89,9 @@ export default class TreeView {
 		 */
 		this._observers = new Map();
 
-		this._jumpOverInlineFiller();
+		// Assign key observer which move cursor from the end of the inline filler to the begging of it when
+		// the left arrow is pressed, so the filler does not break navigation.
+		this.on( 'keydown', jumpOverInlineFiller );
 	}
 
 	/**
@@ -193,37 +195,30 @@ export default class TreeView {
 			observer.enable();
 		}
 	}
+}
 
-	/**
-	 * Assign key observer which move cursor from the end of the inline filler to the begging of it when the left arrow
-	 * is pressed, so the filler does not break navigation.
-	 *
-	 * @private
-	 */
-	_jumpOverInlineFiller() {
-		this.on( 'keydown', ( evt, data ) => {
-			if ( data.keyCode == keyNames.arrowleft ) {
-				const domSelection = data.domTarget.ownerDocument.defaultView.getSelection();
-
-				if ( domSelection.rangeCount == 1 && domSelection.getRangeAt( 0 ).collapsed ) {
-					const domParent = domSelection.getRangeAt( 0 ).startContainer;
-					const domOffset = domSelection.getRangeAt( 0 ).startOffset;
-
-					if ( startsWithFiller( domParent ) && domOffset <= INLINE_FILLER_LENGTH ) {
-						const domRange = new Range();
-						domRange.setStart( domParent, 0 );
-						domRange.collapse( true );
-						domSelection.removeAllRanges();
-						domSelection.addRange( domRange );
-					}
-				}
+mix( TreeView, EmitterMixin );
+
+// Move cursor from the end of the inline filler to the begging of it when, so the filler does not break navigation.
+function jumpOverInlineFiller( evt, data ) {
+	if ( data.keyCode == keyNames.arrowleft ) {
+		const domSelection = data.domTarget.ownerDocument.defaultView.getSelection();
+
+		if ( domSelection.rangeCount == 1 && domSelection.getRangeAt( 0 ).collapsed ) {
+			const domParent = domSelection.getRangeAt( 0 ).startContainer;
+			const domOffset = domSelection.getRangeAt( 0 ).startOffset;
+
+			if ( startsWithFiller( domParent ) && domOffset <= INLINE_FILLER_LENGTH ) {
+				const domRange = new Range();
+				domRange.setStart( domParent, 0 );
+				domRange.collapse( true );
+				domSelection.removeAllRanges();
+				domSelection.addRange( domRange );
 			}
-		} );
+		}
 	}
 }
 
-mix( TreeView, EmitterMixin );
-
 /**
  * Enum representing type of the change.
  *