8
0
Prechádzať zdrojové kódy

Other: Small code refactor.

Szymon Cofalik 7 rokov pred
rodič
commit
08e1d235f8

+ 1 - 1
packages/ckeditor5-engine/src/model/differ.js

@@ -181,7 +181,7 @@ export default class Differ {
 			buffered.newRange = newRange;
 
 			if ( buffered.oldRange == null && buffered.newRange == null ) {
-				// The marker is going to be removed (`newRange == null`) but it did not exist before the change set
+				// The marker is going to be removed (`newRange == null`) but it did not exist before the first buffered change
 				// (`buffered.oldRange == null`). In this case, do not keep the marker in buffer at all.
 				this._changedMarkers.delete( markerName );
 			}

+ 2 - 2
packages/ckeditor5-engine/src/model/document.js

@@ -165,8 +165,8 @@ export default class Document {
 			// Whenever marker is updated, buffer that change.
 			this.differ.bufferMarkerChange( marker.name, oldRange, newRange );
 
-			if ( !oldRange ) {
-				// Whenever marker changes, buffer that.
+			if ( oldRange === null ) {
+				// If this is a new marker, add a listener that will buffer change whenever marker changes.
 				marker.on( 'change', ( evt, oldRange ) => {
 					this.differ.bufferMarkerChange( marker.name, oldRange, marker.getRange() );
 				} );