浏览代码

Code refactoring: renamed functions.

Piotrek Koszuliński 9 年之前
父节点
当前提交
06490e6783

+ 3 - 3
packages/ckeditor5-image/src/imagestyle/converters.js

@@ -10,13 +10,13 @@
 import { isImage } from '../utils';
 
 /**
- * Returns converter for `imageStyle` attribute. It can be used for adding, changing and removing the attribute.
+ * Returns converter for the `imageStyle` attribute. It can be used for adding, changing and removing the attribute.
  *
  * @param {Object} styles Object containing available styles. See {@link module:image/imagestyle/imagestyleengine~ImageStyleFormat}
  * for more details.
  * @returns {Function} Model to view attribute converter.
  */
-export function modelToViewSetStyle( styles ) {
+export function modelToViewStyleAttribute( styles ) {
 	return ( evt, data, consumable, conversionApi ) => {
 		const eventType = evt.name.split( ':' )[ 0 ];
 		const consumableType = eventType + ':imageStyle';
@@ -42,7 +42,7 @@ export function modelToViewSetStyle( styles ) {
  * @param {Array.<module:image/imagestyle/imagestyleengine~ImageStyleFormat>} styles Styles for which converter is created.
  * @returns {Function} View to model converter.
  */
-export function viewToModelImageStyles( styles ) {
+export function viewToModelStyleAttribute( styles ) {
 	// Convert only styles without `null` value.
 	const filteredStyles = styles.filter( style => style.value !== null );
 

+ 3 - 3
packages/ckeditor5-image/src/imagestyle/imagestyleengine.js

@@ -10,7 +10,7 @@
 import Plugin from 'ckeditor5-core/src/plugin';
 import ImageStyleCommand from './imagestylecommand';
 import ImageEngine from '../imageengine';
-import { viewToModelImageStyles, modelToViewSetStyle } from './converters';
+import { viewToModelStyleAttribute, modelToViewStyleAttribute } from './converters';
 import fullSizeIcon from 'ckeditor5-core/theme/icons/object-center.svg';
 import sideIcon from 'ckeditor5-core/theme/icons/object-right.svg';
 
@@ -56,7 +56,7 @@ export default class ImageStyleEngine extends Plugin {
 		schema.allow( { name: 'image', attributes: 'imageStyle', inside: '$root' } );
 
 		// Converters for imageStyle attribute from model to view.
-		const modelToViewConverter = modelToViewSetStyle( styles );
+		const modelToViewConverter = modelToViewStyleAttribute( styles );
 		editing.modelToView.on( 'addAttribute:imageStyle:image', modelToViewConverter );
 		data.modelToView.on( 'addAttribute:imageStyle:image', modelToViewConverter );
 		editing.modelToView.on( 'changeAttribute:imageStyle:image', modelToViewConverter );
@@ -65,7 +65,7 @@ export default class ImageStyleEngine extends Plugin {
 		data.modelToView.on( 'removeAttribute:imageStyle:image', modelToViewConverter );
 
 		// Converter for figure element from view to model.
-		data.viewToModel.on( 'element:figure', viewToModelImageStyles( styles ), { priority: 'low' } );
+		data.viewToModel.on( 'element:figure', viewToModelStyleAttribute( styles ), { priority: 'low' } );
 
 		// Register separate command for each style.
 		for ( let style of styles ) {