Browse Source

Internal: Use dropdown instead of drop-down. Closes ckeditor/ckeditor5#891. [skip ci]

Piotrek Koszuliński 7 years ago
parent
commit
05e99c6f1d

+ 1 - 1
packages/ckeditor5-ui/CHANGELOG.md

@@ -65,7 +65,7 @@ refer to the `KeystrokeHandler` helper to learn more.
 * `ContextualToolbar` should have proper editor toolbar styling. Closes [#230](https://github.com/ckeditor/ckeditor5-ui/issues/230). ([4e2ee36](https://github.com/ckeditor/ckeditor5-ui/commit/4e2ee36))
 * BalloonPanelView should prevent native #selectstart event. Closes [#243](https://github.com/ckeditor/ckeditor5-ui/issues/243). ([cba3fb1](https://github.com/ckeditor/ckeditor5-ui/commit/cba3fb1))
 * Button tooltip should not look blurry on low-DPI screens. Closes [#142](https://github.com/ckeditor/ckeditor5-ui/issues/142). Closes [#133](https://github.com/ckeditor/ckeditor5-ui/issues/133). ([a497aff](https://github.com/ckeditor/ckeditor5-ui/commit/a497aff))
-* Clicking and dragging in a drop-down panel should not break the selection. Closes [#228](https://github.com/ckeditor/ckeditor5-ui/issues/228). ([6066a09](https://github.com/ckeditor/ckeditor5-ui/commit/6066a09))
+* Clicking and dragging in a dropdown panel should not break the selection. Closes [#228](https://github.com/ckeditor/ckeditor5-ui/issues/228). ([6066a09](https://github.com/ckeditor/ckeditor5-ui/commit/6066a09))
 * Contextual toolbar should re–position correctly on window scroll. Closes [#227](https://github.com/ckeditor/ckeditor5-ui/issues/227). ([e5ea25f](https://github.com/ckeditor/ckeditor5-ui/commit/e5ea25f))
 * `DropdownView` should open upon arrow down key press. Closes [#249](https://github.com/ckeditor/ckeditor5-ui/issues/249). ([c1e6afc](https://github.com/ckeditor/ckeditor5-ui/commit/c1e6afc))
 * List items should handle Enter and Space key press when focused. Closes [#153](https://github.com/ckeditor/ckeditor5-ui/issues/153). ([403b64a](https://github.com/ckeditor/ckeditor5-ui/commit/403b64a))

+ 6 - 6
packages/ckeditor5-ui/docs/framework/guides/external-ui.md

@@ -152,7 +152,7 @@ With the Bootstrap framework loaded in the web page, you can define the actual U
 <div class="ck-editor">
 	<!-- The toolbar of the editor. -->
 	<div class="btn-toolbar" role="toolbar" aria-label="Editor toolbar">
-		<!-- The headings drop-down. -->
+		<!-- The headings dropdown. -->
 		<div class="btn-group mr-2" role="group" aria-label="Headings">
 			<div class="dropdown" id="heading">
 			  <button class="btn btn-primary btn-sm dropdown-toggle" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span>Headings</span></button>
@@ -210,7 +210,7 @@ Although Bootstrap provides most of the CSS, it does not come with styles dedica
 	color: hsl(0, 0%, 47%);
 }
 
-/* Make sure the headings drop-down button does not change its size
+/* Make sure the headings dropdown button does not change its size
 as different headings are selected. */
 .ck-editor .dropdown-toggle span {
 	display: inline-block;
@@ -221,7 +221,7 @@ as different headings are selected. */
 	vertical-align: bottom;
 }
 
-/* Make the headings drop-down items visually distinctive. */
+/* Make the headings dropdown items visually distinctive. */
 .ck-editor .heading-item_heading1 { font-size: 1.5em; }
 .ck-editor .heading-item_heading2 { font-size: 1.3em; }
 .ck-editor .heading-item_heading3 { font-size: 1.1em; }
@@ -390,11 +390,11 @@ _setupBootstrapToolbarButtons() {
 }
 ```
 
-### Binding the drop-down to the heading commands
+### Binding the dropdown to the heading commands
 
-The drop-down in the toolbar is a more complex case.
+The dropdown in the toolbar is a more complex case.
 
-First, it must be populated with heading options for the users to select from. Then, clicking each option must execute a related heading command in the editor. Finally, the drop-down button and the drop-down menu items must reflect the state of the editor, for example, when the selection lands in a heading, a proper menu item should become active and the button should show the name of the heading level.
+First, it must be populated with heading options for the users to select from. Then, clicking each option must execute a related heading command in the editor. Finally, the dropdown button and the dropdown menu items must reflect the state of the editor, for example, when the selection lands in a heading, a proper menu item should become active and the button should show the name of the heading level.
 
 ```js
 // This method activates the headings dropdown in the toolbar.