|
|
@@ -66,7 +66,7 @@ describe( 'TableNavigation', () => {
|
|
|
};
|
|
|
} );
|
|
|
|
|
|
- it( 'should do nothing if not tab pressed', () => {
|
|
|
+ it( 'should do nothing if pressed other key', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '12[]' ]
|
|
|
] ) );
|
|
|
@@ -98,8 +98,8 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- describe( 'on TAB', () => {
|
|
|
- it( 'should do nothing if selection is not in a table', () => {
|
|
|
+ describe( 'on Tab key press', () => {
|
|
|
+ it( 'should do nothing if the selection is not in a table', () => {
|
|
|
setModelData( model, '<paragraph>[]</paragraph>' + modelTable( [ [ '11', '12' ] ] ) );
|
|
|
|
|
|
editor.editing.view.document.fire( 'keydown', domEvtDataStub );
|
|
|
@@ -111,7 +111,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to next cell', () => {
|
|
|
+ it( 'should move to the next cell', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11[]', '12' ]
|
|
|
] ) );
|
|
|
@@ -125,7 +125,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should create another row and move to first cell in new row', () => {
|
|
|
+ it( 'should create another row and move to the first cell in a new row', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '[12]' ]
|
|
|
] ) );
|
|
|
@@ -138,7 +138,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not create another row and not move the caret if insertTableRowBelow command is disabled', () => {
|
|
|
+ it( 'should not create another row and not move the caret if the "insertTableRowBelow" command is disabled', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '12[]' ]
|
|
|
] ) );
|
|
|
@@ -154,7 +154,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the first cell of next row if on end of a row', () => {
|
|
|
+ it( 'should move to the first cell of the next row if at the end of a row', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '12[]' ],
|
|
|
[ '21', '22' ]
|
|
|
@@ -168,7 +168,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the next table cell if part of block content is selected', () => {
|
|
|
+ it( 'should move to the next table cell if the block content is partially selected', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '<paragraph>12</paragraph><paragraph>[foo]</paragraph><paragraph>bar</paragraph>', '13' ]
|
|
|
] ) );
|
|
|
@@ -184,7 +184,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to next cell with an image', () => {
|
|
|
+ it( 'should move to the next cell containing an image', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11[]', '<paragraph>foo</paragraph><image><caption></caption></image>' ]
|
|
|
] ) );
|
|
|
@@ -198,7 +198,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to next cell with an blockQuote', () => {
|
|
|
+ it( 'should move to the next cell containing a block quote', () => {
|
|
|
model.schema.register( 'blockQuote', {
|
|
|
allowWhere: '$block',
|
|
|
allowContentOf: '$root'
|
|
|
@@ -218,7 +218,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should listen with lower priority then its children', () => {
|
|
|
+ it( 'should listen with the lower priority than its children', () => {
|
|
|
// Cancel TAB event.
|
|
|
editor.keystrokes.set( 'Tab', ( data, cancel ) => cancel() );
|
|
|
|
|
|
@@ -289,12 +289,12 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'on SHIFT+TAB', () => {
|
|
|
+ describe( 'on Shift+Tab key press', () => {
|
|
|
beforeEach( () => {
|
|
|
domEvtDataStub.shiftKey = true;
|
|
|
} );
|
|
|
|
|
|
- it( 'should do nothing if selection is not in a table', () => {
|
|
|
+ it( 'should do nothing if the selection is not in a table', () => {
|
|
|
setModelData( model, '<paragraph>[]</paragraph>' + modelTable( [
|
|
|
[ '11', '12' ]
|
|
|
] ) );
|
|
|
@@ -311,7 +311,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to previous cell', () => {
|
|
|
+ it( 'should move to the previous cell', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '12[]' ]
|
|
|
] ) );
|
|
|
@@ -326,7 +326,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not move if caret is in first table cell', () => {
|
|
|
+ it( 'should not move if the caret is in the first table cell', () => {
|
|
|
setModelData( model, '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
[ '[]11', '12' ]
|
|
|
] ) );
|
|
|
@@ -338,7 +338,7 @@ describe( 'TableNavigation', () => {
|
|
|
);
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the last cell of previous row if on beginning of a row', () => {
|
|
|
+ it( 'should move to the last cell of a previous row if at the beginning of a row', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '12' ],
|
|
|
[ '[]21', '22' ]
|
|
|
@@ -352,7 +352,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the previous table cell if part of block content is selected', () => {
|
|
|
+ it( 'should move to the previous table cell if the block content is partially selected', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '11', '<paragraph>12</paragraph><paragraph>[foo]</paragraph><paragraph>bar</paragraph>', '13' ]
|
|
|
] ) );
|
|
|
@@ -368,7 +368,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to previous cell with an image', () => {
|
|
|
+ it( 'should move to the previous cell containing an image', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '<paragraph>foo</paragraph><image><caption></caption></image>', 'bar[]' ]
|
|
|
] ) );
|
|
|
@@ -414,7 +414,7 @@ describe( 'TableNavigation', () => {
|
|
|
};
|
|
|
} );
|
|
|
|
|
|
- it( 'should do nothing if not arrow key pressed', () => {
|
|
|
+ it( 'should do nothing if pressed some non-arrow key', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01[]' ]
|
|
|
] ) );
|
|
|
@@ -431,7 +431,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should do nothing if selection is not in a table', () => {
|
|
|
+ it( 'should do nothing if the selection is not in a table', () => {
|
|
|
const modelData = '<paragraph>[]foobar</paragraph>' + modelTable( [ [ '00', '01' ] ] );
|
|
|
|
|
|
setModelData( model, modelData );
|
|
|
@@ -444,7 +444,7 @@ describe( 'TableNavigation', () => {
|
|
|
assertEqualMarkup( getModelData( model ), modelData );
|
|
|
} );
|
|
|
|
|
|
- describe( '#_navigateFromCellInDirection (finding proper cell to move selection to)', () => {
|
|
|
+ describe( '#_navigateFromCellInDirection (finding a proper cell to move the selection to)', () => {
|
|
|
let tableNavigation;
|
|
|
|
|
|
beforeEach( () => {
|
|
|
@@ -467,7 +467,7 @@ describe( 'TableNavigation', () => {
|
|
|
tableCell = modelRoot.getNodeByPath( [ 1, 0, 0 ] );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the start position of the cell on the right when direction is "right"', () => {
|
|
|
+ it( 'should navigate to the start position of the cell on the right when the direction is "right"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -477,7 +477,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the start position the cell below when direction is "down"', () => {
|
|
|
+ it( 'should navigate to the start position of the cell below when the direction is "down"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'down' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -487,7 +487,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should select a whole table when direction is "up"', () => {
|
|
|
+ it( 'should select a whole table when the direction is "up"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'up' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>[' + modelTable( [
|
|
|
@@ -497,7 +497,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + ']<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should select a whole table when direction is "left"', () => {
|
|
|
+ it( 'should select a whole table when the direction is "left"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>[' + modelTable( [
|
|
|
@@ -515,7 +515,7 @@ describe( 'TableNavigation', () => {
|
|
|
tableCell = modelRoot.getNodeByPath( [ 1, 2, 2 ] );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position of the cell on the left when direction is "left"', () => {
|
|
|
+ it( 'should navigate to the end position of the cell on the left when the direction is "left"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -525,7 +525,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position of the cell above when direction is "up"', () => {
|
|
|
+ it( 'should navigate to the end position of the cell above when the direction is "up"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'up' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -535,7 +535,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should select a whole table when direction is "down"', () => {
|
|
|
+ it( 'should select a whole table when the direction is "down"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'down' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>[' + modelTable( [
|
|
|
@@ -545,7 +545,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + ']<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should select a whole table when direction is "right"', () => {
|
|
|
+ it( 'should select a whole table when the direction is "right"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>[' + modelTable( [
|
|
|
@@ -563,7 +563,7 @@ describe( 'TableNavigation', () => {
|
|
|
tableCell = modelRoot.getNodeByPath( [ 1, 1, 0 ] );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to start position of the cell on the right when direction is "right"', () => {
|
|
|
+ it( 'should navigate to start position of the cell on the right when the direction is "right"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -573,7 +573,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position of the cell above when direction is "up"', () => {
|
|
|
+ it( 'should navigate to the end position of the cell above when the direction is "up"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'up' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -583,7 +583,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the start position of the cell below when direction is "down"', () => {
|
|
|
+ it( 'should navigate to the start position of the cell below when the direction is "down"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'down' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -593,7 +593,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position of the last cell in the previous row when direction is "left"', () => {
|
|
|
+ it( 'should navigate to the end position of the last cell in the previous row when the direction is "left"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -604,14 +604,14 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'from a cell in the last column (but not last row)', () => {
|
|
|
+ describe( 'from a cell in the last column (but not the last row)', () => {
|
|
|
let tableCell;
|
|
|
|
|
|
beforeEach( () => {
|
|
|
tableCell = modelRoot.getNodeByPath( [ 1, 1, 2 ] );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position of the cell on the left when direction is "left"', () => {
|
|
|
+ it( 'should navigate to the end position of the cell on the left when the direction is "left"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -621,7 +621,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the end position the cell above when direction is "up"', () => {
|
|
|
+ it( 'should navigate to the end position the cell above when the direction is "up"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'up' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -631,7 +631,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the start position of the cell below when direction is "down"', () => {
|
|
|
+ it( 'should navigate to the start position of the cell below when the direction is "down"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'down' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -641,7 +641,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) + '<paragraph>bar</paragraph>' );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the start position of the first cell in the next row when direction is "right"', () => {
|
|
|
+ it( 'should navigate to the start position of the first cell in the next row when the direction is "right"', () => {
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
|
|
|
assertEqualMarkup( getModelData( model ), '<paragraph>foo</paragraph>' + modelTable( [
|
|
|
@@ -676,7 +676,7 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
|
|
|
describe( 'when navigating to the right', () => {
|
|
|
- it( 'should navigate to the row-col-spanned cell when approaching from the upper spanned row', () => {
|
|
|
+ it( 'should navigate to the row-col-spanned cell when approaching from the upper-spanned row', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 1, 0 ] );
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
@@ -690,7 +690,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the row-col-spanned cell when approaching from the lower spanned row', () => {
|
|
|
+ it( 'should navigate to the row-col-spanned cell when approaching from the lower-spanned row', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 2, 0 ] );
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
@@ -718,7 +718,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the cell in the upper spanned row when approaching from the row-spanned cell', () => {
|
|
|
+ it( 'should navigate to the cell in the upper-spanned row when approaching from the row-spanned cell', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 1, 2 ] ); // Cell 13.
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'right' );
|
|
|
@@ -762,7 +762,7 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
|
|
|
describe( 'when navigating to the left', () => {
|
|
|
- it( 'should navigate to the row-spanned cell when approaching from the upper spanned row', () => {
|
|
|
+ it( 'should navigate to the row-spanned cell when approaching from the upper-spanned row', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 1, 3 ] ); // Cell 14.
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
@@ -776,7 +776,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the row-spanned cell when approaching from the lower spanned row', () => {
|
|
|
+ it( 'should navigate to the row-spanned cell when approaching from the lower-spanned row', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 2, 1 ] ); // Cell 24.
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
@@ -804,7 +804,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should navigate to the cell in the upper spanned row when approaching from the row-spanned cell', () => {
|
|
|
+ it( 'should navigate to the cell in the upper-spanned row when approaching from the row-spanned cell', () => {
|
|
|
const tableCell = modelRoot.getNodeByPath( [ 0, 1, 1 ] ); // Cell 11.
|
|
|
|
|
|
tableNavigation._navigateFromCellInDirection( tableCell, 'left' );
|
|
|
@@ -1022,7 +1022,7 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
|
|
|
describe( 'with the table cells selected from outside', () => {
|
|
|
- describe( 'on single table cell selected', () => {
|
|
|
+ describe( 'on a single table cell selected', () => {
|
|
|
beforeEach( () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
@@ -1062,7 +1062,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell above selection', () => {
|
|
|
+ it( 'should move to the cell above the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', upArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( upArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1075,7 +1075,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell below selection', () => {
|
|
|
+ it( 'should move to the cell below the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', downArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( downArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1089,7 +1089,7 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'on multiple table cell selected vertically', () => {
|
|
|
+ describe( 'on multiple table cells selected vertically', () => {
|
|
|
beforeEach( () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02', '03' ],
|
|
|
@@ -1104,7 +1104,7 @@ describe( 'TableNavigation', () => {
|
|
|
);
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the left top of selection', () => {
|
|
|
+ it( 'should move to the cell on the top left of the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', leftArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( leftArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1118,7 +1118,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the right bottom of selection', () => {
|
|
|
+ it( 'should move to the cell on the bottom right of the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', rightArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( rightArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1132,7 +1132,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell above selection', () => {
|
|
|
+ it( 'should move to the cell above the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', upArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( upArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1146,7 +1146,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell below selection', () => {
|
|
|
+ it( 'should move to the cell below the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', downArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( downArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1178,7 +1178,7 @@ describe( 'TableNavigation', () => {
|
|
|
);
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the left top of selection', () => {
|
|
|
+ it( 'should move to the cell on the top left of the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', leftArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( leftArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1192,7 +1192,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the right bottom of selection', () => {
|
|
|
+ it( 'should move to the cell on the bottom right of the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', rightArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( rightArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1206,7 +1206,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell above selection', () => {
|
|
|
+ it( 'should move to the cell above the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', upArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( upArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1220,7 +1220,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell below selection', () => {
|
|
|
+ it( 'should move to the cell below the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', downArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( downArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1250,7 +1250,7 @@ describe( 'TableNavigation', () => {
|
|
|
);
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the left top of selection', () => {
|
|
|
+ it( 'should move to the cell on the top left of selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', leftArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( leftArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1264,7 +1264,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the right bottom of selection', () => {
|
|
|
+ it( 'should move to the cell on the bottom right of selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', rightArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( rightArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -1308,8 +1308,8 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'with selection inside a table cell', () => {
|
|
|
- describe( 'with selection at the edge of a cell', () => {
|
|
|
+ describe( 'with the selection inside a table cell', () => {
|
|
|
+ describe( 'with the selection at the boundary of a cell', () => {
|
|
|
describe( 'simple cell text content', () => {
|
|
|
it( 'should navigate to the cell on the left', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
@@ -1685,7 +1685,7 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'with selection not at the edge of a cell', () => {
|
|
|
+ describe( 'with selection not at the boundary of a cell', () => {
|
|
|
let editorElement, editor, model, styleElement;
|
|
|
|
|
|
beforeEach( async () => {
|
|
|
@@ -1702,12 +1702,12 @@ describe( 'TableNavigation', () => {
|
|
|
styleElement.type = 'text/css';
|
|
|
styleElement.appendChild( global.document.createTextNode(
|
|
|
`
|
|
|
- * {
|
|
|
- font-size: 12px !important;
|
|
|
+ * {
|
|
|
+ font-size: 12px !important;
|
|
|
font-family: serif !important;
|
|
|
- margin: 0 !important;
|
|
|
- padding: 0 !important;
|
|
|
- border: 0 !important
|
|
|
+ margin: 0 !important;
|
|
|
+ padding: 0 !important;
|
|
|
+ border: 0 !important
|
|
|
}
|
|
|
td { width: 30px !important; }
|
|
|
tr:nth-child(2) td:nth-child(2) { width: 300px !important; }
|
|
|
@@ -1844,13 +1844,13 @@ describe( 'TableNavigation', () => {
|
|
|
} );
|
|
|
|
|
|
if ( !env.isGecko ) {
|
|
|
- // This tests fails on Travis. They work correctly when started on local machine.
|
|
|
+ // These tests fails on Travis. They work correctly when started on local machine.
|
|
|
// Issue is probably related to text rendering and wrapping.
|
|
|
|
|
|
describe( 'with selection in the wrap area', () => {
|
|
|
const text = new Array( 10 ).fill( 0 ).map( () => 'word' ).join( ' ' );
|
|
|
|
|
|
- it( 'should move caret to end if caret is after the last space in the line next to the last one', () => {
|
|
|
+ it( 'should move the caret to end if the caret is after the last space in the line next to the last one', () => {
|
|
|
// This is also first position in the last line.
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
@@ -1870,7 +1870,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move caret to end if caret is at the last space in the line next to last one', () => {
|
|
|
+ it( 'should move the caret to end if ther caret is at the last space in the line next to last one', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', text + '[] word word word', '12' ],
|
|
|
@@ -1889,7 +1889,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not move caret if it\'s just before the last space in the line next to last one', () => {
|
|
|
+ it( 'should not move the caret if it\'s just before the last space in the line next to last one', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', text.substring( 0, text.length - 1 ) + '[]d word word word', '12' ],
|
|
|
@@ -1907,7 +1907,7 @@ describe( 'TableNavigation', () => {
|
|
|
describe( 'with multiple paragraphs of text', () => {
|
|
|
const text = new Array( 100 ).fill( 0 ).map( () => 'word' ).join( ' ' );
|
|
|
|
|
|
- it( 'should not navigate if caret is in the middle line of a text', () => {
|
|
|
+ it( 'should not navigate if caret is in the middle of a line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>${ text }[]${ text }</paragraph><paragraph>foobar</paragraph>`, '12' ],
|
|
|
@@ -1920,7 +1920,7 @@ describe( 'TableNavigation', () => {
|
|
|
sinon.assert.notCalled( upArrowDomEvtDataStub.stopPropagation );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move caret to beginning of cell content if caret is in the first line of a text', () => {
|
|
|
+ it( 'should move the caret to the beginning of a cell content if the caret is in the first line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>word[]${ text }</paragraph><paragraph>foobar</paragraph>`, '12' ],
|
|
|
@@ -1939,7 +1939,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not move caret to end of cell content if caret is not last line of text', () => {
|
|
|
+ it( 'should not move the caret to the end of a cell content if the caret is not in the last line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>${ text }word []word</paragraph><paragraph>foobar</paragraph>`, '12' ],
|
|
|
@@ -1952,7 +1952,7 @@ describe( 'TableNavigation', () => {
|
|
|
sinon.assert.notCalled( downArrowDomEvtDataStub.stopPropagation );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move caret to end of cell content if caret is in the last line of a text', () => {
|
|
|
+ it( 'should move the caret to end of a cell content if the caret is in the last line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>foobar</paragraph><paragraph>${ text }word []word</paragraph>`, '12' ],
|
|
|
@@ -1975,7 +1975,7 @@ describe( 'TableNavigation', () => {
|
|
|
describe( 'with horizontal line widget', () => {
|
|
|
const text = new Array( 100 ).fill( 0 ).map( () => 'word' ).join( ' ' );
|
|
|
|
|
|
- it( 'should not navigate if caret is in the middle line of a text', () => {
|
|
|
+ it( 'should not navigate if the caret is in the middle line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<horizontalLine></horizontalLine><paragraph>${ text }[]${ text }</paragraph>`, '12' ],
|
|
|
@@ -1988,7 +1988,7 @@ describe( 'TableNavigation', () => {
|
|
|
sinon.assert.notCalled( upArrowDomEvtDataStub.stopPropagation );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move caret to beginning of cell content if caret is in the first line of a text', () => {
|
|
|
+ it( 'should move the caret to the beginning of cell content if the caret is in the first line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<horizontalLine></horizontalLine><paragraph>word[] ${ text }</paragraph>`, '12' ],
|
|
|
@@ -2007,7 +2007,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move caret to end of cell content if caret is in the last line of a text', () => {
|
|
|
+ it( 'should move the caret to the end of cell content if the caret is in the last line of text', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>${ text } word []word</paragraph><horizontalLine></horizontalLine>`, '12' ],
|
|
|
@@ -2026,7 +2026,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not move caret to end of cell content if widget is selected in middle of cell content', () => {
|
|
|
+ it( 'should not move the caret to the end of cell content if widget is selected in middle of a cell content', () => {
|
|
|
const paragraph = `<paragraph>${ text }</paragraph>`;
|
|
|
const hr = '<horizontalLine></horizontalLine>';
|
|
|
|
|
|
@@ -2045,7 +2045,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not move caret to end of cell content if widget is next to selection', () => {
|
|
|
+ it( 'should not move the caret to the end of cell content if widget is next to the selection', () => {
|
|
|
const paragraph = `<paragraph>${ text }</paragraph>`;
|
|
|
const hr = '<horizontalLine></horizontalLine>';
|
|
|
|
|
|
@@ -2105,7 +2105,7 @@ describe( 'TableNavigation', () => {
|
|
|
sinon.assert.notCalled( upArrowDomEvtDataStub.stopPropagation );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not navigate to the cell above but should select image widget', () => {
|
|
|
+ it( 'should not navigate to the cell above but should select the image widget', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<image src="${ imageUrl }"><caption>1[]1</caption></image><paragraph>foo</paragraph>`, '12' ],
|
|
|
@@ -2124,7 +2124,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not navigate to the cell below when followed by paragraph', () => {
|
|
|
+ it( 'should not navigate to the cell below when followed by a paragraph', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<image src="${ imageUrl }"><caption>1[]1</caption></image><paragraph>foo</paragraph>`, '12' ],
|
|
|
@@ -2137,7 +2137,7 @@ describe( 'TableNavigation', () => {
|
|
|
sinon.assert.notCalled( downArrowDomEvtDataStub.stopPropagation );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not navigate to the cell below but should select image widget', () => {
|
|
|
+ it( 'should not navigate to the cell below but should select the image widget', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>foo</paragraph><image src="${ imageUrl }"><caption>1[]1</caption></image>`, '12' ],
|
|
|
@@ -2156,7 +2156,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not navigate to the cell above but should select image widget without caption', () => {
|
|
|
+ it( 'should not navigate to the cell above but should select the image widget without caption', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<image src="${ imageUrl }"><caption></caption></image><paragraph>f[]oo</paragraph>`, '12' ],
|
|
|
@@ -2175,7 +2175,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not navigate to the cell below but should select image widget without caption', () => {
|
|
|
+ it( 'should not navigate to the cell below but should select the image widget without caption', () => {
|
|
|
setModelData( model, modelTable( [
|
|
|
[ '00', '01', '02' ],
|
|
|
[ '10', `<paragraph>f[]oo</paragraph><image src="${ imageUrl }"><caption></caption></image>`, '12' ],
|
|
|
@@ -2227,7 +2227,7 @@ describe( 'TableNavigation', () => {
|
|
|
);
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the right (it\'s visually flipped by browser)', () => {
|
|
|
+ it( 'should move to the cell on the right (visually flipped by the browser)', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', leftArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( leftArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -2240,7 +2240,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell on the left (it\'s visually flipped by browser)', () => {
|
|
|
+ it( 'should move to the cell on the left (visually flipped by the browser)', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', rightArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( rightArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -2253,7 +2253,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell above selection', () => {
|
|
|
+ it( 'should move to the cell above the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', upArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( upArrowDomEvtDataStub.preventDefault );
|
|
|
@@ -2266,7 +2266,7 @@ describe( 'TableNavigation', () => {
|
|
|
] ) );
|
|
|
} );
|
|
|
|
|
|
- it( 'should move to the cell below selection', () => {
|
|
|
+ it( 'should move to the cell below the selection', () => {
|
|
|
editor.editing.view.document.fire( 'keydown', downArrowDomEvtDataStub );
|
|
|
|
|
|
sinon.assert.calledOnce( downArrowDomEvtDataStub.preventDefault );
|