Răsfoiți Sursa

Merge pull request #8006 from ckeditor/i/7843

Internal: Fix code according to "no-unused-expressions" ESLint rule. See #7843.
Kamil Piechaczek 5 ani în urmă
părinte
comite
030d0c35c1
29 a modificat fișierele cu 123 adăugiri și 246 ștergeri
  1. 2 2
      packages/ckeditor5-autoformat/tests/autoformat.js
  2. 3 3
      packages/ckeditor5-code-block/src/codeblockediting.js
  3. 2 2
      packages/ckeditor5-core/tests/commandcollection.js
  4. 1 1
      packages/ckeditor5-engine/src/controller/datacontroller.js
  5. 1 1
      packages/ckeditor5-engine/tests/model/operation/operation.js
  6. 0 39
      packages/ckeditor5-engine/tests/model/operation/transform.js
  7. 1 1
      packages/ckeditor5-engine/tests/model/position.js
  8. 26 28
      packages/ckeditor5-engine/tests/model/schema.js
  9. 5 15
      packages/ckeditor5-engine/tests/model/selection.js
  10. 2 2
      packages/ckeditor5-engine/tests/tickets/ckeditor5-692.js
  11. 0 16
      packages/ckeditor5-engine/tests/view/documentselection.js
  12. 58 58
      packages/ckeditor5-engine/tests/view/domconverter/dom-to-view.js
  13. 1 1
      packages/ckeditor5-engine/tests/view/node.js
  14. 0 10
      packages/ckeditor5-engine/tests/view/selection.js
  15. 0 9
      packages/ckeditor5-engine/tests/view/styles/utils.js
  16. 1 1
      packages/ckeditor5-font/src/ui/colorui.js
  17. 3 15
      packages/ckeditor5-list/tests/listediting.js
  18. 1 1
      packages/ckeditor5-list/tests/todolistediting.js
  19. 0 11
      packages/ckeditor5-page-break/tests/pagebreakediting.js
  20. 1 1
      packages/ckeditor5-restricted-editing/tests/restrictededitingmodeediting.js
  21. 2 2
      packages/ckeditor5-table/tests/tablecellproperties/tablecellpropertiesediting.js
  22. 2 2
      packages/ckeditor5-table/tests/tableproperties/tablepropertiesediting.js
  23. 1 1
      packages/ckeditor5-ui/tests/toolbar/toolbarview.js
  24. 0 3
      packages/ckeditor5-ui/tests/viewcollection.js
  25. 4 4
      packages/ckeditor5-utils/tests/config.js
  26. 1 1
      packages/ckeditor5-utils/tests/diff.js
  27. 4 4
      packages/ckeditor5-utils/tests/fastdiff.js
  28. 0 11
      packages/ckeditor5-watchdog/tests/utils/areconnectedthroughproperties.js
  29. 1 1
      packages/ckeditor5-word-count/src/wordcount.js

+ 2 - 2
packages/ckeditor5-autoformat/tests/autoformat.js

@@ -486,7 +486,7 @@ describe( 'Autoformat', () => {
 		} );
 
 		describe( 'with code element', () => {
-			describe( 'should not format', () => {
+			describe( 'should not format (inside)', () => {
 				it( '* inside', () => {
 					setData( model, '<paragraph><$text code="true">fo*obar[]</$text></paragraph>' );
 
@@ -532,7 +532,7 @@ describe( 'Autoformat', () => {
 				} );
 			} );
 
-			describe( 'should not format', () => {
+			describe( 'should not format (across)', () => {
 				it( '* across', () => {
 					setData( model, '<paragraph><$text code="true">fo*o</$text>bar[]</paragraph>' );
 

+ 3 - 3
packages/ckeditor5-code-block/src/codeblockediting.js

@@ -214,9 +214,9 @@ export default class CodeBlockEditing extends Plugin {
 				return;
 			}
 
-			leaveBlockStartOnEnter( editor, data.isSoft ) ||
-			leaveBlockEndOnEnter( editor, data.isSoft ) ||
-			breakLineOnEnter( editor );
+			if ( !leaveBlockStartOnEnter( editor, data.isSoft ) && !leaveBlockEndOnEnter( editor, data.isSoft ) ) {
+				breakLineOnEnter( editor );
+			}
 
 			data.preventDefault();
 			evt.stop();

+ 2 - 2
packages/ckeditor5-core/tests/commandcollection.js

@@ -135,8 +135,8 @@ describe( 'CommandCollection', () => {
 		} );
 	} );
 
-	describe( 'commands()', () => {
-		it( 'returns iterator of commands', () => {
+	describe( 'destroy()', () => {
+		it( 'should destroy commands', () => {
 			const c1 = new SomeCommand( editor );
 			const c2 = new SomeCommand( editor );
 

+ 1 - 1
packages/ckeditor5-engine/src/controller/datacontroller.js

@@ -72,7 +72,7 @@ export default class DataController {
 		 *
 		 * @member {module:engine/dataprocessor/dataprocessor~DataProcessor} #processor
 		 */
-		this.processor;
+		this.processor = undefined;
 
 		/**
 		 * Mapper used for the conversion. It has no permanent bindings, because they are created when getting data and

+ 1 - 1
packages/ckeditor5-engine/tests/model/operation/operation.js

@@ -39,7 +39,7 @@ describe( 'Operation', () => {
 			} );
 		} );
 
-		it( 'should create proper json object #1', () => {
+		it( 'should create proper json object #2', () => {
 			const op = new Operation( 4 );
 			const batch = new Batch();
 			batch.addOperation( op );

+ 0 - 39
packages/ckeditor5-engine/tests/model/operation/transform.js

@@ -1771,45 +1771,6 @@ describe( 'transform', () => {
 				expectOperation( transOp[ 2 ], expected );
 			} );
 
-			it( 'range intersects on right side of transforming range and is important: shrink range', () => {
-				const transformBy = new MoveOperation(
-					new Position( root, [ 2, 2, 5 ] ),
-					2,
-					new Position( root, [ 4, 1, 0 ] ),
-					0
-				);
-
-				const transOp = transform( op, transformBy );
-
-				expected.howMany = 1;
-
-				expect( transOp.length ).to.equal( 1 );
-				expectOperation( transOp[ 0 ], expected );
-			} );
-
-			it( 'range intersects on right side of transforming range and is less important: split into two operations', () => {
-				const transformBy = new MoveOperation(
-					new Position( root, [ 2, 2, 5 ] ),
-					2,
-					new Position( root, [ 4, 1, 0 ] ),
-					0
-				);
-
-				const transOp = transform( op, transformBy, strongContext );
-
-				expect( transOp.length ).to.equal( 2 );
-
-				expected.sourcePosition = sourcePosition;
-				expected.howMany = 1;
-
-				expectOperation( transOp[ 0 ], expected );
-
-				expected.sourcePosition = new Position( root, [ 4, 1, 0 ] );
-				expected.targetPosition = targetPosition.getShiftedBy( 1 );
-
-				expectOperation( transOp[ 1 ], expected );
-			} );
-
 			it( 'range intersects, target inside transforming range and is important: split into two operations', () => {
 				op.targetPosition.path = [ 2, 2, 7 ];
 

+ 1 - 1
packages/ckeditor5-engine/tests/model/position.js

@@ -615,7 +615,7 @@ describe( 'Position', () => {
 			expect( positionB.isTouching( positionA ) ).to.be.false;
 		} );
 
-		it( 'should return false if there are whole nodes between positions', () => {
+		it( 'should return false if there are whole nodes between positions (same depth, but deeper)', () => {
 			const positionA = new Position( root, [ 1, 0, 3 ] );
 			const positionB = new Position( root, [ 1, 1, 1 ] );
 

+ 26 - 28
packages/ckeditor5-engine/tests/model/schema.js

@@ -2509,7 +2509,7 @@ describe( 'Schema', () => {
 				expect( schema.checkChild( root1, r1p1 ) ).to.be.true;
 			} );
 
-			it( 'passes $root>paragraph>$text – paragraph inherits allowIn from $block through $block\'s allowWhere', () => {
+			it( 'passes $root>paragraph>$text – paragraph inherits allowed content from $block through $block\'s allowContentOf', () => {
 				schema.register( '$root' );
 				schema.register( '$blockProto' );
 				schema.register( '$block', {
@@ -2525,6 +2525,31 @@ describe( 'Schema', () => {
 
 				expect( schema.checkChild( r1p1, r1p1.getChild( 0 ) ) ).to.be.true;
 			} );
+
+			it( 'passes paragraph[align] – paragraph inherits attributes of $block', () => {
+				schema.register( '$block', {
+					allowAttributes: 'align'
+				} );
+				schema.register( 'paragraph', {
+					inheritAllFrom: '$block'
+				} );
+
+				expect( schema.checkAttribute( r1p1, 'align' ) ).to.be.true;
+			} );
+
+			it( 'passes paragraph[align] – paragraph inherits attributes of $block through allowAttributesOf', () => {
+				schema.register( '$blockProto', {
+					allowAttributes: 'align'
+				} );
+				schema.register( '$block', {
+					allowAttributesOf: '$blockProto'
+				} );
+				schema.register( 'paragraph', {
+					inheritAllFrom: '$block'
+				} );
+
+				expect( schema.checkAttribute( r1p1, 'align' ) ).to.be.true;
+			} );
 		} );
 
 		// We need to handle cases where some independent features registered definitions which might use
@@ -2669,33 +2694,6 @@ describe( 'Schema', () => {
 			// However, those situations are rather theoretical, so we're not going to waste time on them now.
 		} );
 
-		describe( 'inheritAllFrom', () => {
-			it( 'passes paragraph[align] – paragraph inherits attributes of $block', () => {
-				schema.register( '$block', {
-					allowAttributes: 'align'
-				} );
-				schema.register( 'paragraph', {
-					inheritAllFrom: '$block'
-				} );
-
-				expect( schema.checkAttribute( r1p1, 'align' ) ).to.be.true;
-			} );
-
-			it( 'passes paragraph[align] – paragraph inherits attributes of $block through allowAttributesOf', () => {
-				schema.register( '$blockProto', {
-					allowAttributes: 'align'
-				} );
-				schema.register( '$block', {
-					allowAttributesOf: '$blockProto'
-				} );
-				schema.register( 'paragraph', {
-					inheritAllFrom: '$block'
-				} );
-
-				expect( schema.checkAttribute( r1p1, 'align' ) ).to.be.true;
-			} );
-		} );
-
 		describe( 'missing attribute definitions', () => {
 			it( 'does not crash when checking an attribute of a non-registered element', () => {
 				expect( schema.checkAttribute( r1p1, 'align' ) ).to.be.false;

+ 5 - 15
packages/ckeditor5-engine/tests/model/selection.js

@@ -143,7 +143,12 @@ describe( 'Selection', () => {
 			expect( selection.is( 'model' ) ).to.be.false;
 			expect( selection.is( 'model:node' ) ).to.be.false;
 			expect( selection.is( '$text' ) ).to.be.false;
+			expect( selection.is( '$textProxy' ) ).to.be.false;
+			expect( selection.is( 'element' ) ).to.be.false;
 			expect( selection.is( 'element', 'paragraph' ) ).to.be.false;
+			expect( selection.is( 'documentSelection' ) ).to.be.false;
+			expect( selection.is( 'node' ) ).to.be.false;
+			expect( selection.is( 'rootElement' ) ).to.be.false;
 		} );
 	} );
 
@@ -826,21 +831,6 @@ describe( 'Selection', () => {
 		} );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for selection', () => {
-			expect( selection.is( 'selection' ) ).to.be.true;
-		} );
-
-		it( 'should return false for other values', () => {
-			expect( selection.is( 'documentSelection' ) ).to.be.false;
-			expect( selection.is( 'node' ) ).to.be.false;
-			expect( selection.is( '$text' ) ).to.be.false;
-			expect( selection.is( '$textProxy' ) ).to.be.false;
-			expect( selection.is( 'element' ) ).to.be.false;
-			expect( selection.is( 'rootElement' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'setTo - used to collapse at start', () => {
 		it( 'should collapse to start position and fire change event', () => {
 			selection.setTo( [ range2, range1, range3 ] );

+ 2 - 2
packages/ckeditor5-engine/tests/tickets/ckeditor5-692.js

@@ -41,7 +41,7 @@ describe( 'Bug ckeditor5#692', () => {
 
 	describe( 'DomConverter', () => {
 		// https://github.com/ckeditor/ckeditor5/issues/692 Scenario 1.
-		it( 'should handle space after inline filler at the end of container', () => {
+		it( 'should handle space after inline filler at the end of container (scenario 1)', () => {
 			setModelData( editor.model, '<paragraph>foo[]</paragraph>' );
 
 			// Create Bold attribute at the end of paragraph.
@@ -63,7 +63,7 @@ describe( 'Bug ckeditor5#692', () => {
 		} );
 
 		// https://github.com/ckeditor/ckeditor5/issues/692 Scenario 2.
-		it( 'should handle space after inline filler at the end of container', () => {
+		it( 'should handle space after inline filler at the end of container (scenario 2)', () => {
 			setModelData( editor.model, '<paragraph>[]foo</paragraph>' );
 
 			// Create Bold attribute at the end of paragraph.

+ 0 - 16
packages/ckeditor5-engine/tests/view/documentselection.js

@@ -80,16 +80,6 @@ describe( 'DocumentSelection', () => {
 			expect( selection.isBackward ).to.be.false;
 		} );
 
-		it( 'should be able to create a collapsed selection at the given position', () => {
-			const position = range1.start;
-			const selection = new DocumentSelection( position );
-
-			expect( Array.from( selection.getRanges() ).length ).to.equal( 1 );
-			expect( selection.getFirstRange().start ).to.deep.equal( position );
-			expect( selection.getFirstRange().end ).to.deep.equal( position );
-			expect( selection.isBackward ).to.be.false;
-		} );
-
 		it( 'should be able to create a selection from the other document selection', () => {
 			const otherSelection = new DocumentSelection( [ range2, range3 ], { backward: true } );
 			const selection = new DocumentSelection( otherSelection );
@@ -553,12 +543,6 @@ describe( 'DocumentSelection', () => {
 			expect( documentSelection.isEqual( otherSelection ) ).to.be.false;
 		} );
 
-		it( 'should return false if one selection is fake', () => {
-			const otherSelection = new DocumentSelection( null, { fake: true } );
-
-			expect( documentSelection.isEqual( otherSelection ) ).to.be.false;
-		} );
-
 		it( 'should return true if both selection are fake - DocumentSelection and Selection', () => {
 			const otherSelection = new Selection( range1, { fake: true } );
 			documentSelection._setTo( range1, { fake: true } );

+ 58 - 58
packages/ckeditor5-engine/tests/view/domconverter/dom-to-view.js

@@ -421,7 +421,7 @@ describe( 'DomConverter', () => {
 				expect( viewDiv.getChild( 0 ).getChild( 0 ).data ).to.equal( 'f o o' );
 			} );
 
-			function test( inputTexts, output ) {
+			function testTexts( inputTexts, output ) {
 				if ( typeof inputTexts == 'string' ) {
 					inputTexts = [ inputTexts ];
 				}
@@ -446,75 +446,75 @@ describe( 'DomConverter', () => {
 			}
 
 			// At the beginning.
-			test( '_x', ' x' );
-			test( '_ x', '  x' );
-			test( '_ _x', '   x' );
-			test( '_ _ x', '    x' );
+			testTexts( '_x', ' x' );
+			testTexts( '_ x', '  x' );
+			testTexts( '_ _x', '   x' );
+			testTexts( '_ _ x', '    x' );
 
 			// At the end.
-			test( 'x_', 'x ' );
-			test( 'x _', 'x  ' );
-			test( 'x __', 'x   ' );
-			test( 'x _ _', 'x    ' );
+			testTexts( 'x_', 'x ' );
+			testTexts( 'x _', 'x  ' );
+			testTexts( 'x __', 'x   ' );
+			testTexts( 'x _ _', 'x    ' );
 
 			// In the middle.
-			test( 'x x', 'x x' );
-			test( 'x _x', 'x  x' );
-			test( 'x _ x', 'x   x' );
-			test( 'x _ _x', 'x    x' );
+			testTexts( 'x x', 'x x' );
+			testTexts( 'x _x', 'x  x' );
+			testTexts( 'x _ x', 'x   x' );
+			testTexts( 'x _ _x', 'x    x' );
 
 			// Complex.
-			test( '_x_', ' x ' );
-			test( '_ x _x _', '  x  x  ' );
-			test( '_ _x x _', '   x x  ' );
-			test( '_ _x x __', '   x x   ' );
-			test( '_ _x _ _x_', '   x    x ' );
-			test( '_', ' ' );
+			testTexts( '_x_', ' x ' );
+			testTexts( '_ x _x _', '  x  x  ' );
+			testTexts( '_ _x x _', '   x x  ' );
+			testTexts( '_ _x x __', '   x x   ' );
+			testTexts( '_ _x _ _x_', '   x    x ' );
+			testTexts( '_', ' ' );
 
 			// With hard &nbsp;
-			test( '_x', ' x' );
-			test( '__x', ' _x' );
-			test( '___x', ' __x' );
-			test( '__ x', ' _ x' );
-
-			test( 'x_', 'x ' );
-			test( 'x__', 'x_ ' );
-			test( 'x___', 'x__ ' );
-
-			test( 'x_x', 'x_x' );
-			test( 'x___x', 'x___x' );
-			test( 'x____x', 'x____x' );
-			test( 'x__ x', 'x__ x' );
-			test( 'x___ x', 'x___ x' );
-			test( 'x_ _x', 'x_  x' );
-			test( 'x __x', 'x  _x' );
-			test( 'x _ x', 'x   x' );
-			test( 'x __ _x', 'x  _  x' );
+			testTexts( '_x', ' x' );
+			testTexts( '__x', ' _x' );
+			testTexts( '___x', ' __x' );
+			testTexts( '__ x', ' _ x' );
+
+			testTexts( 'x_', 'x ' );
+			testTexts( 'x__', 'x_ ' );
+			testTexts( 'x___', 'x__ ' );
+
+			testTexts( 'x_x', 'x_x' );
+			testTexts( 'x___x', 'x___x' );
+			testTexts( 'x____x', 'x____x' );
+			testTexts( 'x__ x', 'x__ x' );
+			testTexts( 'x___ x', 'x___ x' );
+			testTexts( 'x_ _x', 'x_  x' );
+			testTexts( 'x __x', 'x  _x' );
+			testTexts( 'x _ x', 'x   x' );
+			testTexts( 'x __ _x', 'x  _  x' );
 
 			// Two text nodes.
-			test( [ 'x', 'y' ], 'xy' );
-			test( [ 'x ', 'y' ], 'x y' );
-			test( [ 'x _', 'y' ], 'x  y' );
-			test( [ 'x __', 'y' ], 'x   y' );
-			test( [ 'x _  _', 'y' ], 'x    y' );
-
-			test( [ 'x', ' y' ], 'x y' );
-			test( [ 'x_', ' y' ], 'x  y' );
-			test( [ 'x _', ' y' ], 'x   y' );
-			test( [ 'x __', ' y' ], 'x    y' );
-			test( [ 'x _ _', ' y' ], 'x     y' );
-
-			test( [ 'x', ' _y' ], 'x  y' );
-			test( [ 'x_', ' _y' ], 'x   y' );
-			test( [ 'x _', ' _y' ], 'x    y' );
-			test( [ 'x __', ' _y' ], 'x     y' );
-			test( [ 'x _ _', ' _y' ], 'x      y' );
+			testTexts( [ 'x', 'y' ], 'xy' );
+			testTexts( [ 'x ', 'y' ], 'x y' );
+			testTexts( [ 'x _', 'y' ], 'x  y' );
+			testTexts( [ 'x __', 'y' ], 'x   y' );
+			testTexts( [ 'x _  _', 'y' ], 'x    y' );
+
+			testTexts( [ 'x', ' y' ], 'x y' );
+			testTexts( [ 'x_', ' y' ], 'x  y' );
+			testTexts( [ 'x _', ' y' ], 'x   y' );
+			testTexts( [ 'x __', ' y' ], 'x    y' );
+			testTexts( [ 'x _ _', ' y' ], 'x     y' );
+
+			testTexts( [ 'x', ' _y' ], 'x  y' );
+			testTexts( [ 'x_', ' _y' ], 'x   y' );
+			testTexts( [ 'x _', ' _y' ], 'x    y' );
+			testTexts( [ 'x __', ' _y' ], 'x     y' );
+			testTexts( [ 'x _ _', ' _y' ], 'x      y' );
 
 			// Some tests with hard &nbsp;
-			test( [ 'x', '_y' ], 'x_y' );
-			test( [ 'x_', 'y' ], 'x_y' );
-			test( [ 'x__', ' y' ], 'x_  y' );
-			test( [ 'x_ _', ' y' ], 'x_   y' );
+			testTexts( [ 'x', '_y' ], 'x_y' );
+			testTexts( [ 'x_', 'y' ], 'x_y' );
+			testTexts( [ 'x__', ' y' ], 'x_  y' );
+			testTexts( [ 'x_ _', ' y' ], 'x_   y' );
 
 			it( 'not in preformatted blocks', () => {
 				const domDiv = createElement( document, 'div', {}, [

+ 1 - 1
packages/ckeditor5-engine/tests/view/node.js

@@ -214,7 +214,7 @@ describe( 'Node', () => {
 		} );
 	} );
 
-	describe( 'getIndex()', () => {
+	describe( '#index getter', () => {
 		it( 'should return null if the parent is null', () => {
 			expect( root.index ).to.be.null;
 		} );

+ 0 - 10
packages/ckeditor5-engine/tests/view/selection.js

@@ -82,16 +82,6 @@ describe( 'Selection', () => {
 			expect( selection.isBackward ).to.be.false;
 		} );
 
-		it( 'should be able to create a collapsed selection at the given position', () => {
-			const position = range1.start;
-			const selection = new Selection( position );
-
-			expect( Array.from( selection.getRanges() ).length ).to.equal( 1 );
-			expect( selection.getFirstRange().start ).to.deep.equal( position );
-			expect( selection.getFirstRange().end ).to.deep.equal( position );
-			expect( selection.isBackward ).to.be.false;
-		} );
-
 		it( 'should be able to create a selection from the other selection', () => {
 			const otherSelection = new Selection( [ range2, range3 ], { backward: true } );
 			const selection = new Selection( otherSelection );

+ 0 - 9
packages/ckeditor5-engine/tests/view/styles/utils.js

@@ -232,15 +232,6 @@ describe( 'Styles utils', () => {
 			} );
 		} );
 
-		it( 'should parse one value', () => {
-			expect( getBoxSidesValues( 'foo' ) ).to.deep.equal( {
-				top: 'foo',
-				right: 'foo',
-				bottom: 'foo',
-				left: 'foo'
-			} );
-		} );
-
 		it( 'should parse two value', () => {
 			expect( getBoxSidesValues( 'foo bar' ) ).to.deep.equal( {
 				top: 'foo',

+ 1 - 1
packages/ckeditor5-font/src/ui/colorui.js

@@ -75,7 +75,7 @@ export default class ColorUI extends Plugin {
 		 *
 		 * @member {module:font/ui/colortableview~ColorTableView}
 		 */
-		this.colorTableView;
+		this.colorTableView = undefined;
 	}
 
 	/**

+ 3 - 15
packages/ckeditor5-list/tests/listediting.js

@@ -175,7 +175,7 @@ describe( 'ListEditing', () => {
 	} );
 
 	describe( 'delete key handling callback', () => {
-		it( 'should execute outdentList command on backspace key in first item of list', () => {
+		it( 'should execute outdentList command on backspace key in first item of list (first node in root)', () => {
 			const domEvtDataStub = { preventDefault() {}, direction: 'backward' };
 
 			sinon.spy( editor, 'execute' );
@@ -187,7 +187,7 @@ describe( 'ListEditing', () => {
 			sinon.assert.calledWithExactly( editor.execute, 'outdentList' );
 		} );
 
-		it( 'should execute outdentList command on backspace key in first item of list', () => {
+		it( 'should execute outdentList command on backspace key in first item of list (after a paragraph)', () => {
 			const domEvtDataStub = { preventDefault() {}, direction: 'backward' };
 
 			sinon.spy( editor, 'execute' );
@@ -262,18 +262,6 @@ describe( 'ListEditing', () => {
 			sinon.assert.notCalled( editor.execute );
 		} );
 
-		it( 'should not execute outdentList command when selection is not on first position', () => {
-			const domEvtDataStub = { preventDefault() {}, direction: 'backward' };
-
-			sinon.spy( editor, 'execute' );
-
-			setModelData( model, '<listItem listType="bulleted" listIndent="0">fo[]o</listItem>' );
-
-			editor.editing.view.document.fire( 'delete', domEvtDataStub );
-
-			sinon.assert.notCalled( editor.execute );
-		} );
-
 		it( 'should outdent list when previous element is nested in block quote', () => {
 			const domEvtDataStub = { preventDefault() {}, direction: 'backward' };
 
@@ -3985,7 +3973,7 @@ describe( 'ListEditing', () => {
 		} );
 
 		// Just checking that it doesn't crash. #69
-		it( 'should work if an element is passed to DataController#insertContent()', () => {
+		it( 'should work if an element is passed to DataController#insertContent() - case #69', () => {
 			setModelData( model,
 				'<listItem listType="bulleted" listIndent="0">A</listItem>' +
 				'<listItem listType="bulleted" listIndent="1">B[]</listItem>' +

+ 1 - 1
packages/ckeditor5-list/tests/todolistediting.js

@@ -1180,7 +1180,7 @@ describe( 'TodoListEditing', () => {
 	} );
 } );
 
-describe( 'TodoListEditing', () => {
+describe( 'TodoListEditing - checkbox rendering', () => {
 	let editorElement, editor, model, modelDoc, view, viewDoc, viewRoot;
 
 	beforeEach( () => {

+ 0 - 11
packages/ckeditor5-page-break/tests/pagebreakediting.js

@@ -171,17 +171,6 @@ describe( 'PageBreakEditing', () => {
 					.to.equal( '' );
 			} );
 
-			it( 'should not convert if inner span has wrong styles', () => {
-				editor.setData(
-					'<div class="page-break" style="page-break-after:always;">' +
-					'<span style="display:inline-block;">&nbsp;</span>' +
-					'</div>'
-				);
-
-				expect( getModelData( model, { withoutSelection: true } ) )
-					.to.equal( '' );
-			} );
-
 			it( 'should not convert if inner span has any children', () => {
 				editor.setData(
 					'<div class="page-break" style="page-break-after:always;">' +

+ 1 - 1
packages/ckeditor5-restricted-editing/tests/restrictededitingmodeediting.js

@@ -656,7 +656,7 @@ describe( 'RestrictedEditingModeEditing', () => {
 			assertEqualMarkup( getModelData( model ), '<paragraph>foo b[]ar baz</paragraph>' );
 		} );
 
-		it( 'should prevent changing text before exception marker', () => {
+		it( 'should prevent changing text before exception marker (native spell-check simulation)', () => {
 			addExceptionMarker( 4, 7, firstParagraph );
 
 			model.change( writer => {

+ 2 - 2
packages/ckeditor5-table/tests/tablecellproperties/tablecellpropertiesediting.js

@@ -323,7 +323,7 @@ describe( 'table cell properties', () => {
 					model.change( writer => writer.setAttribute( 'borderStyle', 'ridge', tableCell ) );
 				} );
 
-				it( 'should be overridable', () => {
+				it( 'should be overridable for borderStyle', () => {
 					editor.conversion.for( 'downcast' )
 						.add( dispatcher => dispatcher.on( 'attribute:borderStyle:tableCell', ( evt, data, conversionApi ) => {
 							conversionApi.consumable.consume( data.item, evt.name );
@@ -365,7 +365,7 @@ describe( 'table cell properties', () => {
 					model.change( writer => writer.setAttribute( 'borderWidth', '2px', tableCell ) );
 				} );
 
-				it( 'should be overridable', () => {
+				it( 'should be overridable for borderWidth', () => {
 					editor.conversion.for( 'downcast' )
 						.add( dispatcher => dispatcher.on( 'attribute:borderWidth:tableCell', ( evt, data, conversionApi ) => {
 							conversionApi.consumable.consume( data.item, evt.name );

+ 2 - 2
packages/ckeditor5-table/tests/tableproperties/tablepropertiesediting.js

@@ -293,7 +293,7 @@ describe( 'table properties', () => {
 					model.change( writer => writer.setAttribute( 'borderStyle', 'solid', table ) );
 				} );
 
-				it( 'should be overridable', () => {
+				it( 'should be overridable for borderStyle', () => {
 					editor.conversion.for( 'downcast' )
 						.add( dispatcher => dispatcher.on( 'attribute:borderStyle:table', ( evt, data, conversionApi ) => {
 							conversionApi.consumable.consume( data.item, evt.name );
@@ -335,7 +335,7 @@ describe( 'table properties', () => {
 					model.change( writer => writer.setAttribute( 'borderWidth', '2px', table ) );
 				} );
 
-				it( 'should be overridable', () => {
+				it( 'should be overridable for borderWidth', () => {
 					editor.conversion.for( 'downcast' )
 						.add( dispatcher => dispatcher.on( 'attribute:borderWidth:table', ( evt, data, conversionApi ) => {
 							conversionApi.consumable.consume( data.item, evt.name );

+ 1 - 1
packages/ckeditor5-ui/tests/toolbar/toolbarview.js

@@ -64,7 +64,7 @@ describe( 'ToolbarView', () => {
 				expect( view.options ).to.deep.equal( {} );
 			} );
 
-			it( 'should be an empty object if none were passed', () => {
+			it( 'should be an empty object if other options were passed', () => {
 				const options = {
 					foo: 'bar'
 				};

+ 0 - 3
packages/ckeditor5-ui/tests/viewcollection.js

@@ -100,9 +100,6 @@ describe( 'ViewCollection', () => {
 					children: collection
 				} );
 
-				// Render view#template along with collection of children.
-				view.element;
-
 				const viewC = getView( 'C' );
 
 				// Modify the collection, while the view#element has already

+ 4 - 4
packages/ckeditor5-utils/tests/config.js

@@ -396,9 +396,8 @@ describe( 'Config', () => {
 
 		it( 'should not be possible to retrieve value directly from config object', () => {
 			expect( config.creator ).to.be.undefined;
-			expect( () => {
-				config.resize.maxHeight;
-			} ).to.throw();
+			// Check if 'resize.maxHeight' would be accessible;
+			expect( config.resize ).to.be.undefined;
 		} );
 
 		it( 'should not be possible to alter config object by altering returned value', () => {
@@ -430,7 +429,8 @@ describe( 'Config', () => {
 		} );
 
 		it( 'should return class & functions references from config array', () => {
-			class Foo {}
+			class Foo {
+			}
 
 			function bar() {
 				return 'bar';

+ 1 - 1
packages/ckeditor5-utils/tests/diff.js

@@ -63,7 +63,7 @@ describe( 'diff', () => {
 		testUtils.sinon.assert.called( fastDiffSpy );
 	} );
 
-	it( 'should use fastDiff() internally for strings with length sum of 2000+', () => {
+	it( 'should use fastDiff() internally for strings with length sum of exaclty 2000', () => {
 		diff( getLongText( 10 ), getLongText( 1990 ) );
 		testUtils.sinon.assert.called( fastDiffSpy );
 	} );

+ 4 - 4
packages/ckeditor5-utils/tests/fastdiff.js

@@ -317,14 +317,14 @@ describe( 'fastDiff', () => {
 				], false );
 			} );
 
-			it( 'should diff insertion of duplicated content', () => {
+			it( 'should diff insertion of duplicated content (case 1)', () => {
 				expectDiff( '1234', '123123', [
 					{ index: 3, type: 'insert', values: [ '1', '2', '3' ] },
 					{ index: 6, type: 'delete', howMany: 1 }
 				], false );
 			} );
 
-			it( 'should diff insertion of duplicated content', () => {
+			it( 'should diff insertion of duplicated content (case 2)', () => {
 				expectDiff( '1234', '13424', [
 					{ index: 1, type: 'insert', values: [ '3', '4', '2' ] },
 					{ index: 4, type: 'delete', howMany: 2 }
@@ -584,11 +584,11 @@ describe( 'fastDiff', () => {
 				expectDiffLinear( '12345', '1231234', 'eeeiiiidd', false );
 			} );
 
-			it( 'should diff insertion of duplicated content', () => {
+			it( 'should diff insertion of duplicated content - case 1', () => {
 				expectDiffLinear( '1234', '123123', 'eeeiiid' );
 			} );
 
-			it( 'should diff insertion of duplicated content', () => {
+			it( 'should diff insertion of duplicated content - case 2', () => {
 				expectDiffLinear( '1234', '13424', 'eiiidde', false );
 			} );
 

+ 0 - 11
packages/ckeditor5-watchdog/tests/utils/areconnectedthroughproperties.js

@@ -285,16 +285,5 @@ describe( 'areConnectedThroughProperties()', () => {
 
 			expect( areConnectedThroughProperties( editor1, editor2 ) ).to.be.false;
 		} );
-
-		it( 'should return false for two different editors sharing builtin plugins', () => {
-			Editor.builtinPlugins = [
-				class Foo {}
-			];
-
-			const editor1 = new Editor();
-			const editor2 = new Editor();
-
-			expect( areConnectedThroughProperties( editor1, editor2 ) ).to.be.false;
-		} );
 	} );
 } );

+ 1 - 1
packages/ckeditor5-word-count/src/wordcount.js

@@ -120,7 +120,7 @@ export default class WordCount extends Plugin {
 		 * @readonly
 		 * @type {module:ui/view~View}
 		 */
-		this._outputView;
+		this._outputView = undefined;
 
 		/**
 		 * A regular expression used to recognize words in the editor's content.