8
0

renderer.js 46 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317
  1. /**
  2. * @license Copyright (c) 2003-2015, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals Range, document, window */
  6. /* bender-tags: view, browser-only */
  7. import ViewElement from 'ckeditor5/engine/view/element.js';
  8. import ViewText from 'ckeditor5/engine/view/text.js';
  9. import ViewRange from 'ckeditor5/engine/view/range.js';
  10. import Selection from 'ckeditor5/engine/view/selection.js';
  11. import DomConverter from 'ckeditor5/engine/view/domconverter.js';
  12. import Renderer from 'ckeditor5/engine/view/renderer.js';
  13. import CKEditorError from 'ckeditor5/utils/ckeditorerror.js';
  14. import { parse } from 'ckeditor5/engine/dev-utils/view.js';
  15. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from 'ckeditor5/engine/view/filler.js';
  16. import testUtils from 'tests/core/_utils/utils.js';
  17. import createElement from 'ckeditor5/utils/dom/createelement.js';
  18. testUtils.createSinonSandbox();
  19. describe( 'Renderer', () => {
  20. let selection, domConverter, renderer;
  21. beforeEach( () => {
  22. selection = new Selection();
  23. domConverter = new DomConverter();
  24. renderer = new Renderer( domConverter, selection );
  25. renderer.domDocuments.add( document );
  26. } );
  27. describe( 'markToSync', () => {
  28. let viewRoot;
  29. beforeEach( () => {
  30. viewRoot = new ViewElement( 'p' );
  31. const domRoot = document.createElement( 'p' );
  32. domConverter.bindElements( domRoot, viewRoot );
  33. viewRoot.appendChildren( new ViewText( 'foo' ) );
  34. renderer.markedTexts.clear();
  35. renderer.markedAttributes.clear();
  36. renderer.markedChildren.clear();
  37. } );
  38. it( 'should mark attributes which need update', () => {
  39. viewRoot.setAttribute( 'class', 'foo' );
  40. renderer.markToSync( 'attributes', viewRoot );
  41. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  42. } );
  43. it( 'should mark children which need update', () => {
  44. viewRoot.appendChildren( new ViewText( 'foo' ) );
  45. renderer.markToSync( 'children', viewRoot );
  46. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  47. } );
  48. it( 'should not mark children if element has no corresponding node', () => {
  49. // Overwrite viewRoot with node without coresponding DOM node.
  50. viewRoot = new ViewElement( 'p' );
  51. viewRoot.appendChildren( new ViewText( 'foo' ) );
  52. renderer.markToSync( 'children', viewRoot );
  53. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  54. } );
  55. it( 'should mark text which need update', () => {
  56. const viewText = new ViewText( 'foo' );
  57. viewRoot.appendChildren( viewText );
  58. viewText.data = 'bar';
  59. renderer.markToSync( 'text', viewText );
  60. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  61. } );
  62. it( 'should not mark text if parent has no corresponding node', () => {
  63. const viewText = new ViewText( 'foo' );
  64. // Overwrite viewRoot with node without coresponding DOM node.
  65. viewRoot = new ViewElement( 'p' );
  66. viewRoot.appendChildren( viewText );
  67. viewText.data = 'bar';
  68. renderer.markToSync( 'text', viewText );
  69. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  70. } );
  71. it( 'should throw if the type is unknown', () => {
  72. expect( () => {
  73. renderer.markToSync( 'UNKNOWN', viewRoot );
  74. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  75. } );
  76. } );
  77. describe( 'render', () => {
  78. let viewRoot, domRoot, selectionEditable;
  79. beforeEach( () => {
  80. viewRoot = new ViewElement( 'div' );
  81. domRoot = document.createElement( 'div' );
  82. document.body.appendChild( domRoot );
  83. domConverter.bindElements( domRoot, viewRoot );
  84. renderer.markedTexts.clear();
  85. renderer.markedAttributes.clear();
  86. renderer.markedChildren.clear();
  87. selection.removeAllRanges();
  88. selection.setFake( false );
  89. selectionEditable = viewRoot;
  90. renderer.isFocused = true;
  91. // Fake selection editable - it is needed to render selection properly.
  92. Object.defineProperty( selection, 'editableElement', {
  93. get: function() {
  94. return selectionEditable;
  95. }
  96. } );
  97. } );
  98. it( 'should update attributes', () => {
  99. viewRoot.setAttribute( 'class', 'foo' );
  100. renderer.markToSync( 'attributes', viewRoot );
  101. renderer.render();
  102. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  103. expect( renderer.markedAttributes.size ).to.equal( 0 );
  104. } );
  105. it( 'should remove attributes', () => {
  106. viewRoot.setAttribute( 'class', 'foo' );
  107. domRoot.setAttribute( 'id', 'bar' );
  108. domRoot.setAttribute( 'class', 'bar' );
  109. renderer.markToSync( 'attributes', viewRoot );
  110. renderer.render();
  111. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  112. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  113. expect( renderer.markedAttributes.size ).to.equal( 0 );
  114. } );
  115. it( 'should add children', () => {
  116. viewRoot.appendChildren( new ViewText( 'foo' ) );
  117. renderer.markToSync( 'children', viewRoot );
  118. renderer.render();
  119. expect( domRoot.childNodes.length ).to.equal( 1 );
  120. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  121. expect( renderer.markedChildren.size ).to.equal( 0 );
  122. } );
  123. it( 'should remove children', () => {
  124. viewRoot.appendChildren( new ViewText( 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. viewRoot.removeChildren( 0, 1 );
  130. renderer.markToSync( 'children', viewRoot );
  131. renderer.render();
  132. expect( domRoot.childNodes.length ).to.equal( 0 );
  133. expect( renderer.markedChildren.size ).to.equal( 0 );
  134. } );
  135. it( 'should update text', () => {
  136. const viewText = new ViewText( 'foo' );
  137. viewRoot.appendChildren( viewText );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 1 );
  141. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  142. viewText.data = 'bar';
  143. renderer.markToSync( 'text', viewText );
  144. renderer.render();
  145. expect( domRoot.childNodes.length ).to.equal( 1 );
  146. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  147. expect( renderer.markedTexts.size ).to.equal( 0 );
  148. } );
  149. it( 'should not update text parent child list changed', () => {
  150. const viewImg = new ViewElement( 'img' );
  151. const viewText = new ViewText( 'foo' );
  152. viewRoot.appendChildren( [ viewImg, viewText ] );
  153. renderer.markToSync( 'children', viewRoot );
  154. renderer.markToSync( 'text', viewText );
  155. renderer.render();
  156. expect( domRoot.childNodes.length ).to.equal( 2 );
  157. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  158. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  159. } );
  160. it( 'should not change text if it is the same during text rendering', () => {
  161. const viewText = new ViewText( 'foo' );
  162. viewRoot.appendChildren( viewText );
  163. renderer.markToSync( 'children', viewRoot );
  164. renderer.render();
  165. // This should not be changed during the render.
  166. const domText = domRoot.childNodes[ 0 ];
  167. renderer.markToSync( 'text', viewText );
  168. renderer.render();
  169. expect( domRoot.childNodes.length ).to.equal( 1 );
  170. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  171. } );
  172. it( 'should not change text if it is the same during children rendering', () => {
  173. const viewText = new ViewText( 'foo' );
  174. viewRoot.appendChildren( viewText );
  175. renderer.markToSync( 'children', viewRoot );
  176. renderer.render();
  177. // This should not be changed during the render.
  178. const domText = domRoot.childNodes[ 0 ];
  179. renderer.markToSync( 'children', viewRoot );
  180. renderer.render();
  181. expect( domRoot.childNodes.length ).to.equal( 1 );
  182. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  183. } );
  184. it( 'should not change element if it is the same', () => {
  185. const viewImg = new ViewElement( 'img' );
  186. viewRoot.appendChildren( viewImg );
  187. // This should not be changed during the render.
  188. const domImg = document.createElement( 'img' );
  189. domRoot.appendChild( domImg );
  190. domConverter.bindElements( domImg, viewImg );
  191. renderer.markToSync( 'children', viewRoot );
  192. renderer.render();
  193. expect( domRoot.childNodes.length ).to.equal( 1 );
  194. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  195. } );
  196. it( 'should change element if it is different', () => {
  197. const viewImg = new ViewElement( 'img' );
  198. viewRoot.appendChildren( viewImg );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. const viewP = new ViewElement( 'p' );
  202. viewRoot.removeChildren( 0, 1 );
  203. viewRoot.appendChildren( viewP );
  204. renderer.markToSync( 'children', viewRoot );
  205. renderer.render();
  206. expect( domRoot.childNodes.length ).to.equal( 1 );
  207. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  208. } );
  209. it( 'should not care about filler if there is no DOM', () => {
  210. selectionEditable = null;
  211. const { view: viewP, selection: newSelection } = parse(
  212. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  213. const viewRoot = new ViewElement( 'p' );
  214. viewRoot.appendChildren( viewP );
  215. selection.setTo( newSelection );
  216. renderer.markToSync( 'children', viewRoot );
  217. renderer.render();
  218. // Expect no error on render.
  219. expect( viewRoot ).to.be.ok;
  220. } );
  221. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  222. const domSelection = document.getSelection();
  223. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  224. const { view: viewP, selection: newSelection } = parse(
  225. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  226. viewRoot.appendChildren( viewP );
  227. selection.setTo( newSelection );
  228. renderer.markToSync( 'children', viewRoot );
  229. renderer.render();
  230. expect( domRoot.childNodes.length ).to.equal( 1 );
  231. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  232. const domP = domRoot.childNodes[ 0 ];
  233. expect( domP.childNodes.length ).to.equal( 3 );
  234. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  235. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  236. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  237. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  238. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  239. expect( domSelection.rangeCount ).to.equal( 1 );
  240. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  241. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  242. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  243. // Step 2: No mutation on second render
  244. renderer.markToSync( 'children', viewRoot );
  245. renderer.markToSync( 'children', viewP );
  246. renderAndExpectNoChanges( renderer, domRoot );
  247. // Step 3: <p>foo{}<b></b></p>
  248. selection.removeAllRanges();
  249. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  250. renderer.render();
  251. expect( domP.childNodes.length ).to.equal( 3 );
  252. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  253. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  254. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  255. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  256. expect( domSelection.rangeCount ).to.equal( 1 );
  257. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  258. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  259. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  260. // Step 4: No mutation on second render
  261. renderer.markToSync( 'children', viewRoot );
  262. renderer.markToSync( 'children', viewP );
  263. renderAndExpectNoChanges( renderer, domRoot );
  264. } );
  265. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  266. const domSelection = document.getSelection();
  267. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  268. const { view: viewP, selection: newSelection } = parse(
  269. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  270. viewRoot.appendChildren( viewP );
  271. selection.setTo( newSelection );
  272. renderer.markToSync( 'children', viewRoot );
  273. renderer.render();
  274. const domP = domRoot.childNodes[ 0 ];
  275. expect( domP.childNodes.length ).to.equal( 2 );
  276. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  277. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  278. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  279. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  280. expect( domSelection.rangeCount ).to.equal( 1 );
  281. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  282. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  283. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  284. // Step 2: No mutation on second render
  285. renderer.markToSync( 'children', viewP );
  286. renderAndExpectNoChanges( renderer, domRoot );
  287. // Step 3: <p><b>{}foo</b></p>
  288. selection.removeAllRanges();
  289. selection.addRange( ViewRange.createFromParentsAndOffsets(
  290. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  291. renderer.render();
  292. expect( domP.childNodes.length ).to.equal( 1 );
  293. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  294. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  295. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  296. expect( domSelection.rangeCount ).to.equal( 1 );
  297. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] .childNodes[ 0 ] );
  298. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  299. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  300. // Step 4: No mutation on second render
  301. renderer.markToSync( 'children', viewP );
  302. renderAndExpectNoChanges( renderer, domRoot );
  303. } );
  304. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  305. const domSelection = document.getSelection();
  306. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  307. const { view: viewP, selection: newSelection } = parse(
  308. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  309. viewRoot.appendChildren( viewP );
  310. selection.setTo( newSelection );
  311. renderer.markToSync( 'children', viewRoot );
  312. renderer.render();
  313. const domP = domRoot.childNodes[ 0 ];
  314. expect( domP.childNodes.length ).to.equal( 2 );
  315. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  316. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  317. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  318. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  319. expect( domSelection.rangeCount ).to.equal( 1 );
  320. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  321. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  322. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  323. // Step 2: No mutation on second render
  324. renderer.markToSync( 'children', viewP );
  325. renderAndExpectNoChanges( renderer, domRoot );
  326. // Step 3: <p><b>foo{}</b></p>
  327. selection.removeAllRanges();
  328. selection.addRange( ViewRange.createFromParentsAndOffsets(
  329. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  330. renderer.render();
  331. expect( domP.childNodes.length ).to.equal( 1 );
  332. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  333. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  334. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  335. expect( domSelection.rangeCount ).to.equal( 1 );
  336. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] .childNodes[ 0 ] );
  337. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  338. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  339. // Step 4: No mutation on second render
  340. renderer.markToSync( 'children', viewP );
  341. renderAndExpectNoChanges( renderer, domRoot );
  342. } );
  343. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  344. const domSelection = document.getSelection();
  345. const { view: viewP, selection: newSelection } = parse(
  346. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  347. viewRoot.appendChildren( viewP );
  348. selection.setTo( newSelection );
  349. renderer.markToSync( 'children', viewRoot );
  350. renderer.render();
  351. const domP = domRoot.childNodes[ 0 ];
  352. expect( domP.childNodes.length ).to.equal( 3 );
  353. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  354. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  355. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  356. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  357. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  358. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  359. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  360. expect( domSelection.rangeCount ).to.equal( 1 );
  361. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  362. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  363. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  364. } );
  365. it( 'should move filler when selection is moved', () => {
  366. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  367. const { view: viewP, selection: newSelection } = parse(
  368. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  369. viewRoot.appendChildren( viewP );
  370. selection.setTo( newSelection );
  371. renderer.markToSync( 'children', viewRoot );
  372. renderer.render();
  373. const domP = domRoot.childNodes[ 0 ];
  374. expect( domP.childNodes.length ).to.equal( 3 );
  375. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  376. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  377. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  378. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  379. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  380. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  381. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  382. selection.removeAllRanges();
  383. const viewI = viewP.getChild( 2 );
  384. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  385. renderer.render();
  386. expect( domP.childNodes.length ).to.equal( 3 );
  387. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  389. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  390. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  391. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  392. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  393. } );
  394. it( 'should remove filler when text is added and selection removed', () => {
  395. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  396. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  397. const viewB = viewP.getChild( 1 );
  398. viewRoot.appendChildren( viewP );
  399. selection.setTo( newSelection );
  400. renderer.markToSync( 'children', viewRoot );
  401. renderer.render();
  402. const domP = domRoot.childNodes[ 0 ];
  403. expect( domP.childNodes.length ).to.equal( 2 );
  404. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  405. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  406. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  407. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  408. // Step 2: Add text node.
  409. const viewText = new ViewText( 'x' );
  410. viewB.appendChildren( viewText );
  411. selection.removeAllRanges();
  412. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  413. renderer.markToSync( 'children', viewB );
  414. renderer.render();
  415. // Step 3: Remove selection from the view.
  416. selection.removeAllRanges();
  417. renderer.render();
  418. expect( domP.childNodes.length ).to.equal( 2 );
  419. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  420. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  421. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  422. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  423. } );
  424. // #659
  425. // The element before the filler is removed so the position of the filler
  426. // cannot be remembered as parent+offset.
  427. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  428. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  429. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  430. viewRoot.appendChildren( viewP );
  431. selection.setTo( newSelection );
  432. renderer.markToSync( 'children', viewRoot );
  433. renderer.render();
  434. const domP = domRoot.childNodes[ 0 ];
  435. expect( domP.childNodes.length ).to.equal( 3 );
  436. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  437. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  438. viewP.removeChildren( 1 );
  439. selection.removeAllRanges();
  440. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  441. renderer.markToSync( 'children', viewP );
  442. renderer.render();
  443. // Step 3: Check whether there's no filler in the DOM.
  444. expect( domP.childNodes.length ).to.equal( 1 );
  445. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  446. } );
  447. // #659
  448. it( 'should remove filler from a modified DOM when children moved', () => {
  449. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  450. const { view: viewFragment, selection: newSelection }
  451. = parse( '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>' );
  452. viewRoot.appendChildren( viewFragment );
  453. selection.setTo( newSelection );
  454. renderer.markToSync( 'children', viewRoot );
  455. renderer.render();
  456. expect( domRoot.childNodes.length ).to.equal( 2 );
  457. const domP = domRoot.childNodes[ 0 ];
  458. const domP2 = domRoot.childNodes[ 1 ];
  459. expect( domP.childNodes.length ).to.equal( 3 );
  460. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  461. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  462. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  463. const viewP = viewRoot.getChild( 0 );
  464. const viewP2 = viewRoot.getChild( 1 );
  465. const removedChildren = viewP.removeChildren( 0, 2 );
  466. viewP2.appendChildren( removedChildren );
  467. selection.removeAllRanges();
  468. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  469. renderer.markToSync( 'children', viewP );
  470. renderer.markToSync( 'children', viewP2 );
  471. renderer.render();
  472. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  473. // in the second one there are two <b> tags.
  474. expect( domP.childNodes.length ).to.equal( 1 );
  475. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  476. expect( domP2.childNodes.length ).to.equal( 2 );
  477. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  478. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  479. } );
  480. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  481. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  482. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  483. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  484. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  485. viewRoot.appendChildren( viewP );
  486. selection.setTo( newSelection );
  487. renderer.markToSync( 'children', viewRoot );
  488. renderer.render();
  489. const domP = domRoot.childNodes[ 0 ];
  490. expect( domP.childNodes.length ).to.equal( 2 );
  491. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  492. // Step 2: Move selection to a new attribute element and remove the previous one
  493. viewP.removeChildren( 1 ); // Remove <b>.
  494. const viewI = parse( '<attribute:i></attribute:i>' );
  495. viewP.appendChildren( viewI );
  496. selection.removeAllRanges();
  497. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  498. renderer.markToSync( 'children', viewP );
  499. renderer.render();
  500. // Step 3: Check whether new filler was created in the <i> element.
  501. expect( domP.childNodes.length ).to.equal( 2 );
  502. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  503. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  504. } );
  505. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  506. // that has not been yet rendered/bound to DOM.
  507. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  508. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  509. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  510. viewRoot.appendChildren( viewP );
  511. selection.setTo( newSelection );
  512. renderer.markToSync( 'children', viewRoot );
  513. renderer.render();
  514. const domP = domRoot.childNodes[ 0 ];
  515. expect( domP.childNodes.length ).to.equal( 3 );
  516. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  517. // Step 2: Move selection to a new attribute element.
  518. const viewAbc = parse( 'abc' );
  519. viewP.appendChildren( viewAbc );
  520. selection.removeAllRanges();
  521. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  522. renderer.markToSync( 'children', viewP );
  523. renderer.render();
  524. // Step 3: Check whether old filler was removed.
  525. expect( domP.childNodes.length ).to.equal( 3 );
  526. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  527. } );
  528. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  529. const domSelection = document.getSelection();
  530. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  531. viewRoot.appendChildren( viewP );
  532. selection.setTo( newSelection );
  533. renderer.markToSync( 'children', viewRoot );
  534. renderer.render();
  535. const domP = domRoot.childNodes[ 0 ];
  536. expect( domP.childNodes.length ).to.equal( 1 );
  537. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  538. expect( domSelection.rangeCount ).to.equal( 1 );
  539. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  540. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  541. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  542. // Remove filler and add text node to both DOM and View <p>x{}</p>
  543. domP.removeChild( domP.childNodes[ 0 ] );
  544. domP.appendChild( document.createTextNode( 'x' ) );
  545. domSelection.removeAllRanges();
  546. const domRange = new Range();
  547. domRange.setStart( domP.childNodes[ 0 ], 1 );
  548. domRange.collapse( true );
  549. domSelection.addRange( domRange );
  550. const viewText = new ViewText( 'x' );
  551. viewP.appendChildren( viewText );
  552. selection.removeAllRanges();
  553. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  554. renderer.markToSync( 'children', viewP );
  555. renderAndExpectNoChanges( renderer, domRoot );
  556. } );
  557. it( 'should handle typing in empty block, render if needed', () => {
  558. const domSelection = document.getSelection();
  559. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  560. viewRoot.appendChildren( viewP );
  561. selection.setTo( newSelection );
  562. renderer.markToSync( 'children', viewRoot );
  563. renderer.render();
  564. const domP = domRoot.childNodes[ 0 ];
  565. expect( domP.childNodes.length ).to.equal( 1 );
  566. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  567. expect( domSelection.rangeCount ).to.equal( 1 );
  568. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  569. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  570. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  571. // Add text node only in View <p>x{}</p>
  572. const viewText = new ViewText( 'x' );
  573. viewP.appendChildren( viewText );
  574. selection.removeAllRanges();
  575. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  576. renderer.markToSync( 'children', viewP );
  577. renderer.render();
  578. expect( domP.childNodes.length ).to.equal( 1 );
  579. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  580. expect( domSelection.rangeCount ).to.equal( 1 );
  581. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  582. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  583. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  584. } );
  585. it( 'should handle removing last character', () => {
  586. const domSelection = document.getSelection();
  587. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  588. viewRoot.appendChildren( viewP );
  589. selection.setTo( newSelection );
  590. renderer.markToSync( 'children', viewRoot );
  591. renderer.render();
  592. const domP = domRoot.childNodes[ 0 ];
  593. expect( domP.childNodes.length ).to.equal( 1 );
  594. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  595. expect( domSelection.rangeCount ).to.equal( 1 );
  596. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  597. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  598. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  599. // Remove text and add filler to both DOM and View <p>{}</p>
  600. domP.removeChild( domP.childNodes[ 0 ] );
  601. domP.appendChild( BR_FILLER( document ) );
  602. domSelection.removeAllRanges();
  603. const domRange = new Range();
  604. domRange.setStart( domP.childNodes[ 0 ], 0 );
  605. domRange.collapse( true );
  606. domSelection.addRange( domRange );
  607. viewP.removeChildren( 0 );
  608. selection.removeAllRanges();
  609. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  610. renderer.markToSync( 'children', viewP );
  611. renderAndExpectNoChanges( renderer, domRoot );
  612. } );
  613. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  614. const domSelection = document.getSelection();
  615. // 1. Render <p><b>FILLER{}</b>foo</p>.
  616. const { view: viewP, selection: newSelection } = parse(
  617. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  618. viewRoot.appendChildren( viewP );
  619. selection.setTo( newSelection );
  620. renderer.markToSync( 'children', viewRoot );
  621. renderer.render();
  622. // 2. Check the DOM.
  623. const domP = domRoot.childNodes[ 0 ];
  624. expect( domP.childNodes.length ).to.equal( 2 );
  625. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  626. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  627. const domB = domP.childNodes[ 0 ];
  628. const viewB = viewP.getChild( 0 );
  629. expect( domB.childNodes.length ).to.equal( 1 );
  630. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  631. expect( domSelection.rangeCount ).to.equal( 1 );
  632. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  633. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  634. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  635. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  636. domB.childNodes[ 0 ].data += 'x';
  637. domSelection.removeAllRanges();
  638. const domRange = new Range();
  639. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  640. domRange.collapse( true );
  641. domSelection.addRange( domRange );
  642. const viewText = new ViewText( 'x' );
  643. viewB.appendChildren( viewText );
  644. selection.removeAllRanges();
  645. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  646. renderer.markToSync( 'children', viewP );
  647. renderAndExpectNoChanges( renderer, domRoot );
  648. } );
  649. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  650. const domSelection = document.getSelection();
  651. // 1. Render <p><b>FILLER{}</b>foo</p>.
  652. const { view: viewP, selection: newSelection } = parse(
  653. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  654. viewRoot.appendChildren( viewP );
  655. selection.setTo( newSelection );
  656. renderer.markToSync( 'children', viewRoot );
  657. renderer.render();
  658. // 2. Check the DOM.
  659. const domP = domRoot.childNodes[ 0 ];
  660. expect( domP.childNodes.length ).to.equal( 2 );
  661. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  662. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  663. const domB = domP.childNodes[ 0 ];
  664. const viewB = viewP.getChild( 0 );
  665. expect( domB.childNodes.length ).to.equal( 1 );
  666. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  667. expect( domSelection.rangeCount ).to.equal( 1 );
  668. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  669. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  670. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  671. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  672. const viewText = new ViewText( 'x' );
  673. viewB.appendChildren( viewText );
  674. selection.removeAllRanges();
  675. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  676. renderer.markToSync( 'children', viewB );
  677. renderer.render();
  678. expect( domB.childNodes.length ).to.equal( 1 );
  679. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  680. expect( domSelection.rangeCount ).to.equal( 1 );
  681. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  682. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  683. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  684. } );
  685. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  686. const domSelection = document.getSelection();
  687. // 1. Render <p><b>FILLER{}</b>foo</p>.
  688. const { view: viewP, selection: newSelection } = parse(
  689. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  690. viewRoot.appendChildren( viewP );
  691. selection.setTo( newSelection );
  692. renderer.markToSync( 'children', viewRoot );
  693. renderer.render();
  694. // 2. Check the DOM.
  695. const domP = domRoot.childNodes[ 0 ];
  696. expect( domP.childNodes.length ).to.equal( 2 );
  697. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  698. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  699. const domB = domP.childNodes[ 0 ];
  700. const viewB = viewP.getChild( 0 );
  701. expect( domB.childNodes.length ).to.equal( 1 );
  702. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  703. expect( domSelection.rangeCount ).to.equal( 1 );
  704. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  705. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  706. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  707. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  708. const viewText = new ViewText( 'x' );
  709. viewB.appendChildren( viewText );
  710. selection.removeAllRanges();
  711. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  712. renderer.markToSync( 'text', viewText );
  713. renderer.render();
  714. // 4. Check the DOM.
  715. expect( domB.childNodes.length ).to.equal( 1 );
  716. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  717. expect( domSelection.rangeCount ).to.equal( 1 );
  718. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  719. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  720. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  721. } );
  722. it( 'should handle not collapsed range', () => {
  723. const domSelection = document.getSelection();
  724. const { view: viewP, selection: newSelection } = parse(
  725. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  726. viewRoot.appendChildren( viewP );
  727. selection.setTo( newSelection );
  728. renderer.markToSync( 'children', viewRoot );
  729. renderer.render();
  730. const domP = domRoot.childNodes[ 0 ];
  731. expect( domP.childNodes.length ).to.equal( 2 );
  732. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  733. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  734. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  735. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  736. expect( domSelection.rangeCount ).to.equal( 1 );
  737. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  738. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  739. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  740. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  741. renderer.markToSync( 'children', viewP );
  742. renderAndExpectNoChanges( renderer, domRoot );
  743. } );
  744. it( 'should not change selection if there is no editable with selection', () => {
  745. const domDiv = createElement( document, 'div', null, 'not editable' );
  746. document.body.appendChild( domDiv );
  747. const domSelection = document.getSelection();
  748. domSelection.removeAllRanges();
  749. const domRange = new Range();
  750. domRange.setStart( domDiv, 0 );
  751. domRange.collapse( true );
  752. domSelection.addRange( domRange );
  753. selectionEditable = null;
  754. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  755. viewRoot.appendChildren( viewP );
  756. selection.setTo( newSelection );
  757. renderer.render();
  758. expect( domSelection.rangeCount ).to.equal( 1 );
  759. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  760. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  761. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  762. } );
  763. it( 'should not change selection if there is no focus', () => {
  764. const domDiv = createElement( document, 'div', null, 'not editable' );
  765. document.body.appendChild( domDiv );
  766. const domSelection = document.getSelection();
  767. domSelection.removeAllRanges();
  768. const domRange = new Range();
  769. domRange.setStart( domDiv, 0 );
  770. domRange.collapse( true );
  771. domSelection.addRange( domRange );
  772. renderer.isFocused = false;
  773. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  774. viewRoot.appendChildren( viewP );
  775. selection.setTo( newSelection );
  776. renderer.render();
  777. expect( domSelection.rangeCount ).to.equal( 1 );
  778. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  779. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  780. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  781. } );
  782. it( 'should not add inline filler after text node', () => {
  783. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  784. viewRoot.appendChildren( viewP );
  785. selection.setTo( newSelection );
  786. renderer.markToSync( 'children', viewRoot );
  787. renderer.render();
  788. const domP = domRoot.childNodes[ 0 ];
  789. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  790. } );
  791. it( 'should throw if there is no filler in expected position', () => {
  792. const { view: viewP, selection: newSelection } = parse(
  793. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  794. viewRoot.appendChildren( viewP );
  795. selection.setTo( newSelection );
  796. renderer.markToSync( 'children', viewRoot );
  797. renderer.render();
  798. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  799. const viewB = viewP.getChild( 1 );
  800. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  801. // Remove filler.
  802. domB.childNodes[ 0 ].data = '';
  803. selection.removeAllRanges();
  804. renderer.markToSync( 'children', viewB );
  805. expect( () => {
  806. renderer.render();
  807. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  808. } );
  809. it( 'should handle focusing element', () => {
  810. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  811. const editable = selection.editableElement;
  812. renderer.render();
  813. expect( editable ).to.equal( viewRoot );
  814. expect( domFocusSpy.calledOnce ).to.be.true;
  815. } );
  816. it( 'should not focus editable if isFocues is set to false', () => {
  817. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  818. renderer.isFocused = false;
  819. renderer.render();
  820. expect( domFocusSpy.calledOnce ).to.be.false;
  821. } );
  822. it( 'should not focus already focused DOM element', () => {
  823. domRoot.setAttribute( 'contentEditable', true );
  824. domRoot.focus();
  825. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  826. renderer.render();
  827. expect( domFocusSpy.called ).to.be.false;
  828. } );
  829. describe( 'fake selection', () => {
  830. beforeEach( () => {
  831. const { view: viewP, selection: newSelection } = parse(
  832. '<container:p>[foo bar]</container:p>'
  833. );
  834. viewRoot.appendChildren( viewP );
  835. selection.setTo( newSelection );
  836. renderer.markToSync( 'children', viewRoot );
  837. renderer.render();
  838. } );
  839. it( 'should render fake selection', () => {
  840. const label = 'fake selection label';
  841. selection.setFake( true, { label } );
  842. renderer.render();
  843. expect( domRoot.childNodes.length ).to.equal( 2 );
  844. const container = domRoot.childNodes[ 1 ];
  845. expect( domConverter.getCorrespondingViewElement( container ) ).to.be.undefined;
  846. expect( container.childNodes.length ).to.equal( 1 );
  847. const textNode = container.childNodes[ 0 ];
  848. expect( textNode.textContent ).to.equal( label );
  849. const domSelection = domRoot.ownerDocument.getSelection();
  850. expect( domSelection.anchorNode ).to.equal( textNode );
  851. expect( domSelection.anchorOffset ).to.equal( 0 );
  852. expect( domSelection.focusNode ).to.equal( textNode );
  853. expect( domSelection.focusOffset ).to.equal( label.length );
  854. } );
  855. it( 'should render &nbsp; if no selection label is provided', () => {
  856. selection.setFake( true );
  857. renderer.render();
  858. expect( domRoot.childNodes.length ).to.equal( 2 );
  859. const container = domRoot.childNodes[ 1 ];
  860. expect( container.childNodes.length ).to.equal( 1 );
  861. const textNode = container.childNodes[ 0 ];
  862. expect( textNode.textContent ).to.equal( '\u00A0' );
  863. const domSelection = domRoot.ownerDocument.getSelection();
  864. expect( domSelection.anchorNode ).to.equal( textNode );
  865. expect( domSelection.anchorOffset ).to.equal( 0 );
  866. expect( domSelection.focusNode ).to.equal( textNode );
  867. expect( domSelection.focusOffset ).to.equal( 1 );
  868. } );
  869. it( 'should remove fake selection container when selection is no longer fake', () => {
  870. selection.setFake( true );
  871. renderer.render();
  872. selection.setFake( false );
  873. renderer.render();
  874. expect( domRoot.childNodes.length ).to.equal( 1 );
  875. const domParagraph = domRoot.childNodes[ 0 ];
  876. expect( domParagraph.childNodes.length ).to.equal( 1 );
  877. const textNode = domParagraph.childNodes[ 0 ];
  878. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  879. const domSelection = domRoot.ownerDocument.getSelection();
  880. expect( domSelection.anchorNode ).to.equal( textNode );
  881. expect( domSelection.anchorOffset ).to.equal( 0 );
  882. expect( domSelection.focusNode ).to.equal( textNode );
  883. expect( domSelection.focusOffset ).to.equal( 7 );
  884. } );
  885. it( 'should reuse fake selection container #1', () => {
  886. const label = 'fake selection label';
  887. selection.setFake( true, { label } );
  888. renderer.render();
  889. expect( domRoot.childNodes.length ).to.equal( 2 );
  890. const container = domRoot.childNodes[ 1 ];
  891. selection.setFake( true, { label } );
  892. renderer.render();
  893. expect( domRoot.childNodes.length ).to.equal( 2 );
  894. const newContainer = domRoot.childNodes[ 1 ];
  895. expect( newContainer ).equals( container );
  896. expect( newContainer.childNodes.length ).to.equal( 1 );
  897. const textNode = newContainer.childNodes[ 0 ];
  898. expect( textNode.textContent ).to.equal( label );
  899. } );
  900. it( 'should reuse fake selection container #2', () => {
  901. selection.setFake( true, { label: 'label 1' } );
  902. renderer.render();
  903. expect( domRoot.childNodes.length ).to.equal( 2 );
  904. const container = domRoot.childNodes[ 1 ];
  905. selection.setFake( false );
  906. renderer.render();
  907. expect( domRoot.childNodes.length ).to.equal( 1 );
  908. selection.setFake( true, { label: 'label 2' } );
  909. renderer.render();
  910. expect( domRoot.childNodes.length ).to.equal( 2 );
  911. const newContainer = domRoot.childNodes[ 1 ];
  912. expect( newContainer ).equals( container );
  913. expect( newContainer.childNodes.length ).to.equal( 1 );
  914. const textNode = newContainer.childNodes[ 0 ];
  915. expect( textNode.textContent ).to.equal( 'label 2' );
  916. } );
  917. it( 'should reuse fake selection container #3', () => {
  918. selection.setFake( true, { label: 'label 1' } );
  919. renderer.render();
  920. expect( domRoot.childNodes.length ).to.equal( 2 );
  921. const container = domRoot.childNodes[ 1 ];
  922. selection.setFake( true, { label: 'label 2' } );
  923. renderer.render();
  924. expect( domRoot.childNodes.length ).to.equal( 2 );
  925. const newContainer = domRoot.childNodes[ 1 ];
  926. expect( newContainer ).equals( container );
  927. expect( newContainer.childNodes.length ).to.equal( 1 );
  928. const textNode = newContainer.childNodes[ 0 ];
  929. expect( textNode.textContent ).to.equal( 'label 2' );
  930. } );
  931. it( 'should style fake selection container properly', () => {
  932. selection.setFake( true, { label: 'fake selection' } );
  933. renderer.render();
  934. expect( domRoot.childNodes.length ).to.equal( 2 );
  935. const container = domRoot.childNodes[ 1 ];
  936. expect( container.style.position ).to.equal( 'fixed' );
  937. expect( container.style.top ).to.equal( '0px' );
  938. expect( container.style.left ).to.equal( '-9999px' );
  939. } );
  940. it( 'should bind fake selection container to view selection', () => {
  941. selection.setFake( true, { label: 'fake selection' } );
  942. renderer.render();
  943. expect( domRoot.childNodes.length ).to.equal( 2 );
  944. const container = domRoot.childNodes[ 1 ];
  945. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  946. expect( bindSelection ).to.be.defined;
  947. expect( bindSelection.isEqual( selection ) ).to.be.true;
  948. } );
  949. } );
  950. } );
  951. } );
  952. function renderAndExpectNoChanges( renderer, domRoot ) {
  953. const config = {
  954. childList: true,
  955. characterData: true,
  956. characterDataOldValue: true,
  957. subtree: true
  958. };
  959. const mutationObserver = new window.MutationObserver( () => {
  960. throw 'There should be not mutations';
  961. } );
  962. mutationObserver.observe( domRoot, config );
  963. renderer.render();
  964. const records = mutationObserver.takeRecords();
  965. mutationObserver.disconnect();
  966. expect( records.length ).to.equal( 0 );
  967. }