renderer.js 85 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewContainerElement from '../../src/view/containerelement';
  9. import ViewAttributeElement from '../../src/view/attributeelement';
  10. import ViewText from '../../src/view/text';
  11. import ViewRange from '../../src/view/range';
  12. import ViewPosition from '../../src/view/position';
  13. import DocumentSelection from '../../src/view/documentselection';
  14. import DomConverter from '../../src/view/domconverter';
  15. import Renderer from '../../src/view/renderer';
  16. import DocumentFragment from '../../src/view/documentfragment';
  17. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  18. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  19. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  20. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  21. import createViewRoot from './_utils/createroot';
  22. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  23. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  24. testUtils.createSinonSandbox();
  25. describe( 'Renderer', () => {
  26. let selection, domConverter, renderer;
  27. beforeEach( () => {
  28. selection = new DocumentSelection();
  29. domConverter = new DomConverter();
  30. renderer = new Renderer( domConverter, selection );
  31. renderer.domDocuments.add( document );
  32. } );
  33. describe( 'markToSync', () => {
  34. let viewRoot;
  35. beforeEach( () => {
  36. viewRoot = new ViewElement( 'p' );
  37. const domRoot = document.createElement( 'p' );
  38. domConverter.bindElements( domRoot, viewRoot );
  39. viewRoot._appendChild( new ViewText( 'foo' ) );
  40. renderer.markedTexts.clear();
  41. renderer.markedAttributes.clear();
  42. renderer.markedChildren.clear();
  43. } );
  44. it( 'should mark attributes which need update', () => {
  45. viewRoot._setAttribute( 'class', 'foo' );
  46. renderer.markToSync( 'attributes', viewRoot );
  47. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  48. } );
  49. it( 'should mark children which need update', () => {
  50. viewRoot._appendChild( new ViewText( 'foo' ) );
  51. renderer.markToSync( 'children', viewRoot );
  52. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  53. } );
  54. it( 'should not mark children if element has no corresponding node', () => {
  55. // Overwrite viewRoot with node without coresponding DOM node.
  56. viewRoot = new ViewElement( 'p' );
  57. viewRoot._appendChild( new ViewText( 'foo' ) );
  58. renderer.markToSync( 'children', viewRoot );
  59. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  60. } );
  61. it( 'should mark text which need update', () => {
  62. const viewText = new ViewText( 'foo' );
  63. viewRoot._appendChild( viewText );
  64. viewText._data = 'bar';
  65. renderer.markToSync( 'text', viewText );
  66. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  67. } );
  68. it( 'should not mark text if parent has no corresponding node', () => {
  69. const viewText = new ViewText( 'foo' );
  70. // Overwrite viewRoot with node without coresponding DOM node.
  71. viewRoot = new ViewElement( 'p' );
  72. viewRoot._appendChild( viewText );
  73. viewText._data = 'bar';
  74. renderer.markToSync( 'text', viewText );
  75. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  76. } );
  77. it( 'should throw if the type is unknown', () => {
  78. expect( () => {
  79. renderer.markToSync( 'UNKNOWN', viewRoot );
  80. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  81. } );
  82. } );
  83. describe( 'render', () => {
  84. let viewRoot, domRoot, selectionEditable;
  85. beforeEach( () => {
  86. viewRoot = new ViewElement( 'div' );
  87. domRoot = document.createElement( 'div' );
  88. document.body.appendChild( domRoot );
  89. domConverter.bindElements( domRoot, viewRoot );
  90. renderer.markedTexts.clear();
  91. renderer.markedAttributes.clear();
  92. renderer.markedChildren.clear();
  93. selection._setTo( null );
  94. selectionEditable = viewRoot;
  95. renderer.isFocused = true;
  96. // Fake selection editable - it is needed to render selection properly.
  97. Object.defineProperty( selection, 'editableElement', {
  98. get() {
  99. return selectionEditable;
  100. }
  101. } );
  102. } );
  103. afterEach( () => {
  104. domRoot.remove();
  105. } );
  106. it( 'should update attributes', () => {
  107. viewRoot._setAttribute( 'class', 'foo' );
  108. renderer.markToSync( 'attributes', viewRoot );
  109. renderer.render();
  110. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  111. expect( renderer.markedAttributes.size ).to.equal( 0 );
  112. } );
  113. it( 'should remove attributes', () => {
  114. viewRoot._setAttribute( 'class', 'foo' );
  115. domRoot.setAttribute( 'id', 'bar' );
  116. domRoot.setAttribute( 'class', 'bar' );
  117. renderer.markToSync( 'attributes', viewRoot );
  118. renderer.render();
  119. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  120. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  121. expect( renderer.markedAttributes.size ).to.equal( 0 );
  122. } );
  123. it( 'should add children', () => {
  124. viewRoot._appendChild( new ViewText( 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. expect( renderer.markedChildren.size ).to.equal( 0 );
  130. } );
  131. it( 'should remove children', () => {
  132. viewRoot._appendChild( new ViewText( 'foo' ) );
  133. renderer.markToSync( 'children', viewRoot );
  134. renderer.render();
  135. expect( domRoot.childNodes.length ).to.equal( 1 );
  136. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  137. viewRoot._removeChildren( 0, 1 );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 0 );
  141. expect( renderer.markedChildren.size ).to.equal( 0 );
  142. } );
  143. it( 'should update text', () => {
  144. const viewText = new ViewText( 'foo' );
  145. viewRoot._appendChild( viewText );
  146. renderer.markToSync( 'children', viewRoot );
  147. renderer.render();
  148. expect( domRoot.childNodes.length ).to.equal( 1 );
  149. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  150. viewText._data = 'bar';
  151. renderer.markToSync( 'text', viewText );
  152. renderer.render();
  153. expect( domRoot.childNodes.length ).to.equal( 1 );
  154. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  155. expect( renderer.markedTexts.size ).to.equal( 0 );
  156. } );
  157. it( 'should not update text parent child list changed', () => {
  158. const viewImg = new ViewElement( 'img' );
  159. const viewText = new ViewText( 'foo' );
  160. viewRoot._appendChild( [ viewImg, viewText ] );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.markToSync( 'text', viewText );
  163. renderer.render();
  164. expect( domRoot.childNodes.length ).to.equal( 2 );
  165. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  166. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  167. } );
  168. it( 'should not change text if it is the same during text rendering', () => {
  169. const viewText = new ViewText( 'foo' );
  170. viewRoot._appendChild( viewText );
  171. renderer.markToSync( 'children', viewRoot );
  172. renderer.render();
  173. // This should not be changed during the render.
  174. const domText = domRoot.childNodes[ 0 ];
  175. renderer.markToSync( 'text', viewText );
  176. renderer.render();
  177. expect( domRoot.childNodes.length ).to.equal( 1 );
  178. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  179. } );
  180. it( 'should not change text if it is the same during children rendering', () => {
  181. const viewText = new ViewText( 'foo' );
  182. viewRoot._appendChild( viewText );
  183. renderer.markToSync( 'children', viewRoot );
  184. renderer.render();
  185. // This should not be changed during the render.
  186. const domText = domRoot.childNodes[ 0 ];
  187. renderer.markToSync( 'children', viewRoot );
  188. renderer.render();
  189. expect( domRoot.childNodes.length ).to.equal( 1 );
  190. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  191. } );
  192. it( 'should not change element if it is the same', () => {
  193. const viewImg = new ViewElement( 'img' );
  194. viewRoot._appendChild( viewImg );
  195. // This should not be changed during the render.
  196. const domImg = document.createElement( 'img' );
  197. domRoot.appendChild( domImg );
  198. domConverter.bindElements( domImg, viewImg );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. expect( domRoot.childNodes.length ).to.equal( 1 );
  202. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  203. } );
  204. it( 'should change element if it is different', () => {
  205. const viewImg = new ViewElement( 'img' );
  206. viewRoot._appendChild( viewImg );
  207. renderer.markToSync( 'children', viewRoot );
  208. renderer.render();
  209. const viewP = new ViewElement( 'p' );
  210. viewRoot._removeChildren( 0, 1 );
  211. viewRoot._appendChild( viewP );
  212. renderer.markToSync( 'children', viewRoot );
  213. renderer.render();
  214. expect( domRoot.childNodes.length ).to.equal( 1 );
  215. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  216. } );
  217. it( 'should update removed item when it is reinserted', () => {
  218. const viewFoo = new ViewText( 'foo' );
  219. const viewP = new ViewElement( 'p', null, viewFoo );
  220. const viewDiv = new ViewElement( 'div', null, viewP );
  221. viewRoot._appendChild( viewDiv );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. viewDiv._removeChildren( 0, 1 );
  225. renderer.markToSync( 'children', viewDiv );
  226. renderer.render();
  227. viewP._removeChildren( 0, 1 );
  228. viewDiv._appendChild( viewP );
  229. renderer.markToSync( 'children', viewDiv );
  230. renderer.render();
  231. expect( domRoot.childNodes.length ).to.equal( 1 );
  232. const domDiv = domRoot.childNodes[ 0 ];
  233. expect( domDiv.tagName ).to.equal( 'DIV' );
  234. expect( domDiv.childNodes.length ).to.equal( 1 );
  235. const domP = domDiv.childNodes[ 0 ];
  236. expect( domP.tagName ).to.equal( 'P' );
  237. expect( domP.childNodes.length ).to.equal( 0 );
  238. } );
  239. it( 'should update removed item when it is reinserted #2', () => {
  240. // Prepare view: root -> div "outer" -> div "inner" -> p.
  241. const viewP = new ViewElement( 'p' );
  242. const viewDivInner = new ViewElement( 'div', null, viewP );
  243. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  244. viewRoot._appendChild( viewDivOuter );
  245. // Render view tree to DOM.
  246. renderer.markToSync( 'children', viewRoot );
  247. renderer.render();
  248. // Remove div "outer" from root and render it.
  249. viewDivOuter._remove();
  250. renderer.markToSync( 'children', viewRoot );
  251. renderer.render();
  252. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  253. viewP._remove();
  254. // Add div "outer" back to root.
  255. viewRoot._appendChild( viewDivOuter );
  256. renderer.markToSync( 'children', viewRoot );
  257. // Render changes, view is: root -> div "outer" -> div "inner".
  258. renderer.render();
  259. // Same is expected in DOM.
  260. expect( domRoot.childNodes.length ).to.equal( 1 );
  261. const domDivOuter = domRoot.childNodes[ 0 ];
  262. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  263. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  264. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  265. const domDivInner = domDivOuter.childNodes[ 0 ];
  266. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  267. expect( domDivInner.tagName ).to.equal( 'DIV' );
  268. expect( domDivInner.childNodes.length ).to.equal( 0 );
  269. } );
  270. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  271. const viewFoo = new ViewText( 'foo' );
  272. const viewP = new ViewElement( 'p', null, viewFoo );
  273. const viewDiv = new ViewElement( 'div', null, viewP );
  274. viewRoot._appendChild( viewDiv );
  275. renderer.markToSync( 'children', viewRoot );
  276. renderer.render();
  277. viewRoot._removeChildren( 0, 1 );
  278. renderer.markToSync( 'children', viewRoot );
  279. viewDiv._removeChildren( 0, 1 );
  280. renderer.markToSync( 'children', viewDiv );
  281. viewP._removeChildren( 0, 1 );
  282. renderer.markToSync( 'children', viewP );
  283. renderer.render();
  284. expect( domRoot.childNodes.length ).to.equal( 0 );
  285. } );
  286. it( 'should not care about filler if there is no DOM', () => {
  287. selectionEditable = null;
  288. const { view: viewP, selection: newSelection } = parse(
  289. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  290. const viewRoot = new ViewElement( 'p' );
  291. viewRoot._appendChild( viewP );
  292. selection._setTo( newSelection );
  293. renderer.markToSync( 'children', viewRoot );
  294. renderer.render();
  295. // Expect no error on render.
  296. expect( viewRoot ).to.be.ok;
  297. } );
  298. it( 'should not add filler when inside contenteditable=false parent', () => {
  299. const { view: viewP, selection: newSelection } = parse(
  300. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  301. viewRoot._appendChild( viewP );
  302. selection._setTo( newSelection );
  303. renderer.markToSync( 'children', viewRoot );
  304. renderer.render();
  305. expect( domRoot.childNodes.length ).to.equal( 1 );
  306. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  307. const domP = domRoot.childNodes[ 0 ];
  308. expect( domP.childNodes.length ).to.equal( 3 );
  309. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  310. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  311. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  312. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  313. } );
  314. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  315. const { view: viewP, selection: newSelection } = parse(
  316. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  317. viewRoot._appendChild( viewP );
  318. selection._setTo( newSelection );
  319. renderer.markToSync( 'children', viewRoot );
  320. renderer.render();
  321. expect( domRoot.childNodes.length ).to.equal( 1 );
  322. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  323. const domP = domRoot.childNodes[ 0 ];
  324. expect( domP.childNodes.length ).to.equal( 3 );
  325. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  326. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  327. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  328. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  329. } );
  330. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  331. const domSelection = document.getSelection();
  332. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  333. const { view: viewP, selection: newSelection } = parse(
  334. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  335. viewRoot._appendChild( viewP );
  336. selection._setTo( newSelection );
  337. renderer.markToSync( 'children', viewRoot );
  338. renderer.render();
  339. expect( domRoot.childNodes.length ).to.equal( 1 );
  340. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  341. const domP = domRoot.childNodes[ 0 ];
  342. expect( domP.childNodes.length ).to.equal( 3 );
  343. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  344. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  345. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  346. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  347. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  348. expect( domSelection.rangeCount ).to.equal( 1 );
  349. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  350. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  351. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  352. // Step 2: No mutation on second render
  353. renderer.markToSync( 'children', viewRoot );
  354. renderer.markToSync( 'children', viewP );
  355. renderAndExpectNoChanges( renderer, domRoot );
  356. // Step 3: <p>foo{}<b></b></p>
  357. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  358. renderer.render();
  359. expect( domP.childNodes.length ).to.equal( 3 );
  360. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  361. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  362. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  363. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  364. expect( domSelection.rangeCount ).to.equal( 1 );
  365. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  366. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  367. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  368. // Step 4: No mutation on second render
  369. renderer.markToSync( 'children', viewRoot );
  370. renderer.markToSync( 'children', viewP );
  371. renderAndExpectNoChanges( renderer, domRoot );
  372. } );
  373. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  374. const domSelection = document.getSelection();
  375. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  376. const { view: viewP, selection: newSelection } = parse(
  377. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  378. viewRoot._appendChild( viewP );
  379. selection._setTo( newSelection );
  380. renderer.markToSync( 'children', viewRoot );
  381. renderer.render();
  382. const domP = domRoot.childNodes[ 0 ];
  383. expect( domP.childNodes.length ).to.equal( 2 );
  384. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  385. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  386. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  387. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domSelection.rangeCount ).to.equal( 1 );
  389. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  390. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  391. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  392. // Step 2: No mutation on second render
  393. renderer.markToSync( 'children', viewP );
  394. renderAndExpectNoChanges( renderer, domRoot );
  395. // Step 3: <p><b>{}foo</b></p>
  396. selection._setTo( ViewRange.createFromParentsAndOffsets(
  397. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  398. renderer.render();
  399. expect( domP.childNodes.length ).to.equal( 1 );
  400. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  401. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  402. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  403. expect( domSelection.rangeCount ).to.equal( 1 );
  404. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  405. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  406. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  407. // Step 4: No mutation on second render
  408. renderer.markToSync( 'children', viewP );
  409. renderAndExpectNoChanges( renderer, domRoot );
  410. } );
  411. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  412. const domSelection = document.getSelection();
  413. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  414. const { view: viewP, selection: newSelection } = parse(
  415. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  416. viewRoot._appendChild( viewP );
  417. selection._setTo( newSelection );
  418. renderer.markToSync( 'children', viewRoot );
  419. renderer.render();
  420. const domP = domRoot.childNodes[ 0 ];
  421. expect( domP.childNodes.length ).to.equal( 2 );
  422. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  423. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  424. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  425. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  426. expect( domSelection.rangeCount ).to.equal( 1 );
  427. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  428. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  429. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  430. // Step 2: No mutation on second render
  431. renderer.markToSync( 'children', viewP );
  432. renderAndExpectNoChanges( renderer, domRoot );
  433. // Step 3: <p><b>foo{}</b></p>
  434. selection._setTo( ViewRange.createFromParentsAndOffsets(
  435. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  436. renderer.render();
  437. expect( domP.childNodes.length ).to.equal( 1 );
  438. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  439. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  440. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  441. expect( domSelection.rangeCount ).to.equal( 1 );
  442. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  443. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  444. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  445. // Step 4: No mutation on second render
  446. renderer.markToSync( 'children', viewP );
  447. renderAndExpectNoChanges( renderer, domRoot );
  448. } );
  449. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  450. const domSelection = document.getSelection();
  451. const { view: viewP, selection: newSelection } = parse(
  452. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  453. viewRoot._appendChild( viewP );
  454. selection._setTo( newSelection );
  455. renderer.markToSync( 'children', viewRoot );
  456. renderer.render();
  457. const domP = domRoot.childNodes[ 0 ];
  458. expect( domP.childNodes.length ).to.equal( 3 );
  459. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  460. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  461. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  462. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  463. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  464. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  465. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  466. expect( domSelection.rangeCount ).to.equal( 1 );
  467. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  468. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  469. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  470. } );
  471. it( 'should move filler when selection is moved', () => {
  472. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  473. const { view: viewP, selection: newSelection } = parse(
  474. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  475. viewRoot._appendChild( viewP );
  476. selection._setTo( newSelection );
  477. renderer.markToSync( 'children', viewRoot );
  478. renderer.render();
  479. const domP = domRoot.childNodes[ 0 ];
  480. expect( domP.childNodes.length ).to.equal( 3 );
  481. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  482. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  483. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  484. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  485. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  486. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  487. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  488. const viewI = viewP.getChild( 2 );
  489. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  490. renderer.render();
  491. expect( domP.childNodes.length ).to.equal( 3 );
  492. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  493. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  494. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  495. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  496. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  497. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  498. } );
  499. it( 'should remove filler when text is added and selection removed', () => {
  500. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  501. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  502. const viewB = viewP.getChild( 1 );
  503. viewRoot._appendChild( viewP );
  504. selection._setTo( newSelection );
  505. renderer.markToSync( 'children', viewRoot );
  506. renderer.render();
  507. const domP = domRoot.childNodes[ 0 ];
  508. expect( domP.childNodes.length ).to.equal( 2 );
  509. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  510. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  511. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  512. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  513. // Step 2: Add text node.
  514. const viewText = new ViewText( 'x' );
  515. viewB._appendChild( viewText );
  516. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  517. renderer.markToSync( 'children', viewB );
  518. renderer.render();
  519. // Step 3: Remove selection from the view.
  520. selection._setTo( null );
  521. renderer.render();
  522. expect( domP.childNodes.length ).to.equal( 2 );
  523. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  524. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  525. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  526. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  527. } );
  528. // #659
  529. // The element before the filler is removed so the position of the filler
  530. // cannot be remembered as parent+offset.
  531. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  532. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  533. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  534. viewRoot._appendChild( viewP );
  535. selection._setTo( newSelection );
  536. renderer.markToSync( 'children', viewRoot );
  537. renderer.render();
  538. const domP = domRoot.childNodes[ 0 ];
  539. expect( domP.childNodes.length ).to.equal( 3 );
  540. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  541. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  542. viewP._removeChildren( 1 );
  543. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  544. renderer.markToSync( 'children', viewP );
  545. renderer.render();
  546. // Step 3: Check whether there's no filler in the DOM.
  547. expect( domP.childNodes.length ).to.equal( 1 );
  548. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  549. } );
  550. // #659
  551. it( 'should remove filler from a modified DOM when children moved', () => {
  552. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  553. const { view: viewFragment, selection: newSelection } = parse(
  554. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  555. );
  556. viewRoot._appendChild( viewFragment );
  557. selection._setTo( newSelection );
  558. renderer.markToSync( 'children', viewRoot );
  559. renderer.render();
  560. expect( domRoot.childNodes.length ).to.equal( 2 );
  561. const domP = domRoot.childNodes[ 0 ];
  562. const domP2 = domRoot.childNodes[ 1 ];
  563. expect( domP.childNodes.length ).to.equal( 3 );
  564. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  565. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  566. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  567. const viewP = viewRoot.getChild( 0 );
  568. const viewP2 = viewRoot.getChild( 1 );
  569. const removedChildren = viewP._removeChildren( 0, 2 );
  570. viewP2._appendChild( removedChildren );
  571. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  572. renderer.markToSync( 'children', viewP );
  573. renderer.markToSync( 'children', viewP2 );
  574. renderer.render();
  575. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  576. // in the second one there are two <b> tags.
  577. expect( domP.childNodes.length ).to.equal( 1 );
  578. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  579. expect( domP2.childNodes.length ).to.equal( 2 );
  580. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  581. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  582. } );
  583. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  584. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  585. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  586. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  587. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  588. viewRoot._appendChild( viewP );
  589. selection._setTo( newSelection );
  590. renderer.markToSync( 'children', viewRoot );
  591. renderer.render();
  592. const domP = domRoot.childNodes[ 0 ];
  593. expect( domP.childNodes.length ).to.equal( 2 );
  594. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  595. // Step 2: Move selection to a new attribute element and remove the previous one
  596. viewP._removeChildren( 1 ); // Remove <b>.
  597. const viewI = parse( '<attribute:i></attribute:i>' );
  598. viewP._appendChild( viewI );
  599. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  600. renderer.markToSync( 'children', viewP );
  601. renderer.render();
  602. // Step 3: Check whether new filler was created in the <i> element.
  603. expect( domP.childNodes.length ).to.equal( 2 );
  604. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  605. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  606. } );
  607. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  608. // that has not been yet rendered/bound to DOM.
  609. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  610. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  611. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  612. viewRoot._appendChild( viewP );
  613. selection._setTo( newSelection );
  614. renderer.markToSync( 'children', viewRoot );
  615. renderer.render();
  616. const domP = domRoot.childNodes[ 0 ];
  617. expect( domP.childNodes.length ).to.equal( 3 );
  618. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  619. // Step 2: Move selection to a new attribute element.
  620. const viewAbc = parse( 'abc' );
  621. viewP._appendChild( viewAbc );
  622. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  623. renderer.markToSync( 'children', viewP );
  624. renderer.render();
  625. // Step 3: Check whether old filler was removed.
  626. expect( domP.childNodes.length ).to.equal( 3 );
  627. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  628. } );
  629. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  630. const domSelection = document.getSelection();
  631. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  632. viewRoot._appendChild( viewP );
  633. selection._setTo( newSelection );
  634. renderer.markToSync( 'children', viewRoot );
  635. renderer.render();
  636. const domP = domRoot.childNodes[ 0 ];
  637. expect( domP.childNodes.length ).to.equal( 1 );
  638. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  639. expect( domSelection.rangeCount ).to.equal( 1 );
  640. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  641. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  642. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  643. // Remove filler and add text node to both DOM and View <p>x{}</p>
  644. domP.removeChild( domP.childNodes[ 0 ] );
  645. domP.appendChild( document.createTextNode( 'x' ) );
  646. domSelection.removeAllRanges();
  647. const domRange = document.createRange();
  648. domRange.setStart( domP.childNodes[ 0 ], 1 );
  649. domRange.collapse( true );
  650. domSelection.addRange( domRange );
  651. const viewText = new ViewText( 'x' );
  652. viewP._appendChild( viewText );
  653. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  654. renderer.markToSync( 'children', viewP );
  655. renderAndExpectNoChanges( renderer, domRoot );
  656. } );
  657. it( 'should handle typing in empty block, render if needed', () => {
  658. const domSelection = document.getSelection();
  659. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  660. viewRoot._appendChild( viewP );
  661. selection._setTo( newSelection );
  662. renderer.markToSync( 'children', viewRoot );
  663. renderer.render();
  664. const domP = domRoot.childNodes[ 0 ];
  665. expect( domP.childNodes.length ).to.equal( 1 );
  666. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  667. expect( domSelection.rangeCount ).to.equal( 1 );
  668. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  669. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  670. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  671. // Add text node only in View <p>x{}</p>
  672. const viewText = new ViewText( 'x' );
  673. viewP._appendChild( viewText );
  674. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  675. renderer.markToSync( 'children', viewP );
  676. renderer.render();
  677. expect( domP.childNodes.length ).to.equal( 1 );
  678. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  679. expect( domSelection.rangeCount ).to.equal( 1 );
  680. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  681. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  682. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  683. } );
  684. it( 'should handle removing last character', () => {
  685. const domSelection = document.getSelection();
  686. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  687. viewRoot._appendChild( viewP );
  688. selection._setTo( newSelection );
  689. renderer.markToSync( 'children', viewRoot );
  690. renderer.render();
  691. const domP = domRoot.childNodes[ 0 ];
  692. expect( domP.childNodes.length ).to.equal( 1 );
  693. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  694. expect( domSelection.rangeCount ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  696. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  697. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  698. // Remove text and add filler to both DOM and View <p>{}</p>
  699. domP.removeChild( domP.childNodes[ 0 ] );
  700. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  701. domSelection.removeAllRanges();
  702. const domRange = document.createRange();
  703. domRange.setStart( domP.childNodes[ 0 ], 0 );
  704. domRange.collapse( true );
  705. domSelection.addRange( domRange );
  706. viewP._removeChildren( 0 );
  707. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  708. renderer.markToSync( 'children', viewP );
  709. renderAndExpectNoChanges( renderer, domRoot );
  710. } );
  711. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  712. const domSelection = document.getSelection();
  713. // 1. Render <p><b>FILLER{}</b>foo</p>.
  714. const { view: viewP, selection: newSelection } = parse(
  715. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  716. viewRoot._appendChild( viewP );
  717. selection._setTo( newSelection );
  718. renderer.markToSync( 'children', viewRoot );
  719. renderer.render();
  720. // 2. Check the DOM.
  721. const domP = domRoot.childNodes[ 0 ];
  722. expect( domP.childNodes.length ).to.equal( 2 );
  723. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  724. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  725. const domB = domP.childNodes[ 0 ];
  726. const viewB = viewP.getChild( 0 );
  727. expect( domB.childNodes.length ).to.equal( 1 );
  728. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  729. expect( domSelection.rangeCount ).to.equal( 1 );
  730. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  731. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  732. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  733. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  734. domB.childNodes[ 0 ].data += 'x';
  735. domSelection.removeAllRanges();
  736. const domRange = document.createRange();
  737. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  738. domRange.collapse( true );
  739. domSelection.addRange( domRange );
  740. const viewText = new ViewText( 'x' );
  741. viewB._appendChild( viewText );
  742. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  743. renderer.markToSync( 'children', viewP );
  744. renderAndExpectNoChanges( renderer, domRoot );
  745. } );
  746. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  747. const domSelection = document.getSelection();
  748. // 1. Render <p><b>FILLER{}</b>foo</p>.
  749. const { view: viewP, selection: newSelection } = parse(
  750. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  751. viewRoot._appendChild( viewP );
  752. selection._setTo( newSelection );
  753. renderer.markToSync( 'children', viewRoot );
  754. renderer.render();
  755. // 2. Check the DOM.
  756. const domP = domRoot.childNodes[ 0 ];
  757. expect( domP.childNodes.length ).to.equal( 2 );
  758. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  759. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  760. const domB = domP.childNodes[ 0 ];
  761. const viewB = viewP.getChild( 0 );
  762. expect( domB.childNodes.length ).to.equal( 1 );
  763. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  764. expect( domSelection.rangeCount ).to.equal( 1 );
  765. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  766. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  767. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  768. domSelection.removeAllRanges();
  769. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  770. const viewText = new ViewText( 'x' );
  771. viewB._appendChild( viewText );
  772. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  773. renderer.markToSync( 'children', viewB );
  774. renderer.render();
  775. expect( domB.childNodes.length ).to.equal( 1 );
  776. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  777. expect( domSelection.rangeCount ).to.equal( 1 );
  778. // Depending on the browser selection may end up at the end of the text node or after the text node.
  779. const firstRange = domSelection.getRangeAt( 0 );
  780. const assertSelectionAtEndOfTextNode = () => {
  781. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  782. };
  783. const assertSelectionInsideTextNode = () => {
  784. expect( firstRange.startContainer ).to.equal( domB );
  785. expect( firstRange.startOffset ).to.equal( 1 );
  786. };
  787. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  788. expect( firstRange.collapsed ).to.be.true;
  789. } );
  790. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  791. const domSelection = document.getSelection();
  792. // 1. Render <p><b>FILLER{}</b>foo</p>.
  793. const { view: viewP, selection: newSelection } = parse(
  794. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  795. viewRoot._appendChild( viewP );
  796. selection._setTo( newSelection );
  797. renderer.markToSync( 'children', viewRoot );
  798. renderer.render();
  799. // 2. Check the DOM.
  800. const domP = domRoot.childNodes[ 0 ];
  801. expect( domP.childNodes.length ).to.equal( 2 );
  802. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  803. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  804. const domB = domP.childNodes[ 0 ];
  805. const viewB = viewP.getChild( 0 );
  806. expect( domB.childNodes.length ).to.equal( 1 );
  807. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  808. expect( domSelection.rangeCount ).to.equal( 1 );
  809. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  810. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  811. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  812. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  813. const viewText = new ViewText( 'x' );
  814. viewB._appendChild( viewText );
  815. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  816. renderer.markToSync( 'text', viewText );
  817. renderer.render();
  818. // 4. Check the DOM.
  819. expect( domB.childNodes.length ).to.equal( 1 );
  820. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  821. expect( domSelection.rangeCount ).to.equal( 1 );
  822. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  823. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  824. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  825. } );
  826. it( 'should handle not collapsed range', () => {
  827. const domSelection = document.getSelection();
  828. const { view: viewP, selection: newSelection } = parse(
  829. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  830. viewRoot._appendChild( viewP );
  831. selection._setTo( newSelection );
  832. renderer.markToSync( 'children', viewRoot );
  833. renderer.render();
  834. const domP = domRoot.childNodes[ 0 ];
  835. expect( domP.childNodes.length ).to.equal( 2 );
  836. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  837. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  838. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  839. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  840. expect( domSelection.rangeCount ).to.equal( 1 );
  841. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  842. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  843. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  844. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  845. renderer.markToSync( 'children', viewP );
  846. renderAndExpectNoChanges( renderer, domRoot );
  847. } );
  848. it( 'should not change selection if there is no editable with selection', () => {
  849. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  850. document.body.appendChild( domDiv );
  851. domDiv.focus();
  852. const domSelection = document.getSelection();
  853. domSelection.removeAllRanges();
  854. domSelection.collapse( domDiv, 0 );
  855. selectionEditable = null;
  856. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  857. viewRoot._appendChild( viewP );
  858. selection._setTo( newSelection );
  859. renderer.render();
  860. expect( domSelection.rangeCount ).to.equal( 1 );
  861. // Depending on the browser selection may end up before the text node or at the beginning of it.
  862. const domRange = domSelection.getRangeAt( 0 );
  863. const assertSelectionAtEndOfTextNode = () => {
  864. expect( domRange.startContainer ).to.equal( domDiv );
  865. };
  866. const assertSelectionInsideTextNode = () => {
  867. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  868. };
  869. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  870. expect( domRange.startOffset ).to.equal( 0 );
  871. expect( domRange.collapsed ).to.be.true;
  872. domDiv.remove();
  873. } );
  874. it( 'should not change selection if there is no focus', () => {
  875. const domDiv = createElement( document, 'div', null, 'not editable' );
  876. document.body.appendChild( domDiv );
  877. const domSelection = document.getSelection();
  878. domSelection.removeAllRanges();
  879. const domRange = document.createRange();
  880. domRange.setStart( domDiv, 0 );
  881. domRange.collapse( true );
  882. domSelection.addRange( domRange );
  883. renderer.isFocused = false;
  884. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  885. viewRoot._appendChild( viewP );
  886. selection._setTo( newSelection );
  887. renderer.render();
  888. expect( domSelection.rangeCount ).to.equal( 1 );
  889. // Depending on the browser selection may end up before the text node or at the beginning of it.
  890. const domSelectionRange = domSelection.getRangeAt( 0 );
  891. const assertSelectionAtEndOfTextNode = () => {
  892. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  893. };
  894. const assertSelectionInsideTextNode = () => {
  895. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  896. };
  897. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  898. expect( domSelectionRange.startOffset ).to.equal( 0 );
  899. expect( domSelectionRange.collapsed ).to.be.true;
  900. domDiv.remove();
  901. } );
  902. it( 'should not add inline filler after text node', () => {
  903. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  904. viewRoot._appendChild( viewP );
  905. selection._setTo( newSelection );
  906. renderer.markToSync( 'children', viewRoot );
  907. renderer.render();
  908. const domP = domRoot.childNodes[ 0 ];
  909. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  910. } );
  911. it( 'should throw if there is no filler in expected position', () => {
  912. const { view: viewP, selection: newSelection } = parse(
  913. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  914. viewRoot._appendChild( viewP );
  915. selection._setTo( newSelection );
  916. renderer.markToSync( 'children', viewRoot );
  917. renderer.render();
  918. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  919. const viewB = viewP.getChild( 1 );
  920. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  921. // Remove filler.
  922. domB.childNodes[ 0 ].data = '';
  923. selection._setTo( null );
  924. renderer.markToSync( 'children', viewB );
  925. expect( () => {
  926. renderer.render();
  927. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  928. } );
  929. // #1014.
  930. it( 'should create inline filler in newly created dom nodes', () => {
  931. // 1. Create the view structure which needs inline filler.
  932. const inputView =
  933. '<container:ul>' +
  934. '<container:li>Foobar.</container:li>' +
  935. '<container:li>[]<container:div></container:div></container:li>' +
  936. '</container:ul>';
  937. const { view: view, selection: newSelection } = parse( inputView );
  938. viewRoot._appendChild( view );
  939. selection._setTo( newSelection );
  940. renderer.markToSync( 'children', viewRoot );
  941. renderer.render();
  942. // 2. Check if filler element has been (correctly) created.
  943. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  944. // 3. Move the inline filler parent to a newly created element.
  945. const viewLi = view.getChild( 0 );
  946. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  947. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  948. viewLi._appendChild( viewUl );
  949. // 4. Mark changed items and render the view.
  950. renderer.markToSync( 'children', view );
  951. renderer.markToSync( 'children', viewLi );
  952. renderer.render();
  953. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  954. const domSelection = document.getSelection();
  955. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  956. } );
  957. it( 'should handle focusing element', () => {
  958. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  959. const editable = selection.editableElement;
  960. renderer.render();
  961. expect( editable ).to.equal( viewRoot );
  962. expect( domFocusSpy.calledOnce ).to.be.true;
  963. } );
  964. it( 'should not focus editable if isFocues is set to false', () => {
  965. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  966. renderer.isFocused = false;
  967. renderer.render();
  968. expect( domFocusSpy.calledOnce ).to.be.false;
  969. } );
  970. it( 'should not focus already focused DOM element', () => {
  971. domRoot.setAttribute( 'contentEditable', true );
  972. domRoot.focus();
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. renderer.render();
  975. expect( domFocusSpy.called ).to.be.false;
  976. } );
  977. it( 'should render NBSP as first space in inline element after another space', () => {
  978. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  979. viewRoot._appendChildren( viewP );
  980. renderer.markToSync( 'children', viewRoot );
  981. renderer.render();
  982. const domP = domRoot.childNodes[ 0 ];
  983. const domB = domP.childNodes[ 1 ];
  984. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  985. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  986. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  987. // Insert space resulting in '<p>x <b> y</b></p>'.
  988. const viewB = viewP.getChild( 1 );
  989. viewB._removeChildren( 0 );
  990. viewB._appendChildren( new ViewText( ' y' ) );
  991. renderer.markToSync( 'children', viewP );
  992. renderer.render();
  993. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  994. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  995. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  996. } );
  997. it( 'should update sibling after, when node before is removed', () => {
  998. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  999. viewRoot._appendChildren( viewP );
  1000. renderer.markToSync( 'children', viewRoot );
  1001. renderer.render();
  1002. const domP = domRoot.childNodes[ 0 ];
  1003. const domB = domP.childNodes[ 1 ];
  1004. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1005. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1006. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1007. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1008. viewP._removeChildren( 0 );
  1009. renderer.markToSync( 'children', viewP );
  1010. renderer.render();
  1011. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1012. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1013. } );
  1014. it( 'should update sibling before, when node after is removed', () => {
  1015. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1016. viewRoot._appendChildren( viewP );
  1017. renderer.markToSync( 'children', viewRoot );
  1018. renderer.render();
  1019. const domP = domRoot.childNodes[ 0 ];
  1020. const domB = domP.childNodes[ 1 ];
  1021. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1022. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1023. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1024. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1025. viewP._removeChildren( 1 );
  1026. renderer.markToSync( 'children', viewP );
  1027. renderer.render();
  1028. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1029. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1030. } );
  1031. // #1093
  1032. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1033. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1034. viewRoot._appendChildren( viewP );
  1035. renderer.markToSync( 'children', viewRoot );
  1036. renderer.render();
  1037. const domP = domRoot.childNodes[ 0 ];
  1038. const domB = domP.childNodes[ 1 ];
  1039. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1040. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1041. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1042. // Insert space resulting in '<p>x <b> y</b></p>'.
  1043. viewP._removeChildren( 0 );
  1044. viewP._insertChildren( 0, new ViewText( 'x ' ) );
  1045. renderer.markToSync( 'children', viewP );
  1046. renderer.render();
  1047. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1048. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1049. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1050. } );
  1051. // #1093
  1052. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1053. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1054. viewRoot._appendChildren( viewP );
  1055. renderer.markToSync( 'children', viewRoot );
  1056. renderer.render();
  1057. const domP = domRoot.childNodes[ 0 ];
  1058. const domB = domP.childNodes[ 0 ];
  1059. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1060. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1061. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1062. // Insert space resulting in '<p><b>x </b> y</p>'.
  1063. const viewB = viewP.getChild( 0 );
  1064. viewB._removeChildren( 0 );
  1065. viewB._insertChildren( 0, new ViewText( 'x ' ) );
  1066. renderer.markToSync( 'children', viewP );
  1067. renderer.render();
  1068. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1069. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1070. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1071. } );
  1072. // #1093
  1073. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1074. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1075. viewRoot._appendChildren( viewP );
  1076. renderer.markToSync( 'children', viewRoot );
  1077. renderer.render();
  1078. const domP = domRoot.childNodes[ 0 ];
  1079. const domB = domP.childNodes[ 0 ];
  1080. const domI = domP.childNodes[ 1 ];
  1081. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1082. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1083. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1084. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1085. const viewB = viewP.getChild( 0 );
  1086. viewB._removeChildren( 0 );
  1087. viewB._insertChildren( 0, new ViewText( 'x ' ) );
  1088. renderer.markToSync( 'children', viewP );
  1089. renderer.render();
  1090. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1091. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1092. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1093. } );
  1094. // #1125
  1095. it( 'should properly rerender many changes done in one batch', () => {
  1096. // This test transforms:
  1097. //
  1098. // <h2>He<strong>ding 1</strong></h2>
  1099. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1100. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1101. //
  1102. // into:
  1103. //
  1104. // <h2>Heading 2</h2>
  1105. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1106. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1107. //
  1108. // during one rerender to check if complex structure changes are rerendered correctly.
  1109. const viewContent = parse( '' +
  1110. '<container:h2>He' +
  1111. '<attribute:i>ading 1</attribute:i>' +
  1112. '</container:h2>' +
  1113. '<container:p>Ph ' +
  1114. '<attribute:strong>Bold</attribute:strong> ' +
  1115. '<attribute:i>It' +
  1116. '<attribute:strong>alic</attribute:strong>' +
  1117. '</attribute:i> ' +
  1118. '<attribute:a href="https://ckeditor.com">' +
  1119. '<attribute:strong>Lin</attribute:strong>' +
  1120. 'k</attribute:a>' +
  1121. '</container:p>' +
  1122. '<container:blockquote>' +
  1123. '<container:ul>' +
  1124. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1125. '</container:ul>' +
  1126. '</container:blockquote>' );
  1127. viewRoot._appendChildren( viewContent );
  1128. renderer.markToSync( 'children', viewRoot );
  1129. renderer.render();
  1130. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1131. const viewHeading = viewRoot.getChild( 0 );
  1132. viewHeading._removeChildren( 0, viewHeading.childCount );
  1133. viewHeading._insertChildren( 0, new ViewText( 'Heading 2' ) );
  1134. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1135. renderer.markToSync( 'children', viewRoot );
  1136. renderer.markToSync( 'children', viewHeading );
  1137. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1138. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1139. // ->
  1140. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1141. const viewP = viewRoot.getChild( 1 );
  1142. viewP._removeChildren( 0, viewP.childCount );
  1143. viewP._insertChildren(
  1144. 0,
  1145. parse(
  1146. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1147. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1148. )
  1149. );
  1150. renderer.markToSync( 'children', viewRoot );
  1151. renderer.markToSync( 'children', viewP );
  1152. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1153. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1154. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1155. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1156. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1157. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1158. const viewBq = viewRoot.getChild( 2 );
  1159. viewBq._removeChildren( 0, viewBq.childCount );
  1160. viewBq._insertChildren(
  1161. 0,
  1162. parse(
  1163. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1164. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1165. )
  1166. );
  1167. renderer.markToSync( 'children', viewRoot );
  1168. renderer.markToSync( 'children', viewBq );
  1169. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1170. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1171. renderer.render();
  1172. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1173. '<h2>Heading 2</h2>' +
  1174. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1175. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1176. );
  1177. } );
  1178. // #1125
  1179. it( 'should properly rerender changes when whole content replaced at once', () => {
  1180. // This test replaces:
  1181. //
  1182. // <h1>Header</h1>
  1183. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1184. //
  1185. // with:
  1186. //
  1187. // <h2>Header</h2>
  1188. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1189. //
  1190. // during one rerender to check if complex structure changes are rerendered correctly.
  1191. const viewContent = parse(
  1192. '<container:h1>Header</container:h1>' +
  1193. '<container:blockquote>' +
  1194. '<container:ul>' +
  1195. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1196. '<container:li>Item 2</container:li>' +
  1197. '</container:ul>' +
  1198. '</container:blockquote>'
  1199. );
  1200. viewRoot._appendChildren( viewContent );
  1201. renderer.markToSync( 'children', viewRoot );
  1202. renderer.render();
  1203. const newViewContent = parse(
  1204. '<container:h2>Header</container:h2>' +
  1205. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1206. );
  1207. viewRoot._removeChildren( 0, viewRoot.childCount );
  1208. viewRoot._appendChildren( newViewContent );
  1209. renderer.markToSync( 'children', viewRoot );
  1210. renderer.render();
  1211. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1212. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1213. );
  1214. } );
  1215. describe( 'fake selection', () => {
  1216. beforeEach( () => {
  1217. const { view: viewP, selection: newSelection } = parse(
  1218. '<container:p>[foo bar]</container:p>'
  1219. );
  1220. viewRoot._appendChild( viewP );
  1221. selection._setTo( newSelection );
  1222. renderer.markToSync( 'children', viewRoot );
  1223. renderer.render();
  1224. } );
  1225. it( 'should render fake selection', () => {
  1226. const label = 'fake selection label';
  1227. selection._setTo( selection.getRanges(), { fake: true, label } );
  1228. renderer.render();
  1229. expect( domRoot.childNodes.length ).to.equal( 2 );
  1230. const container = domRoot.childNodes[ 1 ];
  1231. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1232. expect( container.childNodes.length ).to.equal( 1 );
  1233. const textNode = container.childNodes[ 0 ];
  1234. expect( textNode.textContent ).to.equal( label );
  1235. const domSelection = domRoot.ownerDocument.getSelection();
  1236. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1237. } );
  1238. it( 'should render &nbsp; if no selection label is provided', () => {
  1239. selection._setTo( selection.getRanges(), { fake: true } );
  1240. renderer.render();
  1241. expect( domRoot.childNodes.length ).to.equal( 2 );
  1242. const container = domRoot.childNodes[ 1 ];
  1243. expect( container.childNodes.length ).to.equal( 1 );
  1244. const textNode = container.childNodes[ 0 ];
  1245. expect( textNode.textContent ).to.equal( '\u00A0' );
  1246. const domSelection = domRoot.ownerDocument.getSelection();
  1247. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1248. } );
  1249. it( 'should remove fake selection container when selection is no longer fake', () => {
  1250. selection._setTo( selection.getRanges(), { fake: true } );
  1251. renderer.render();
  1252. selection._setTo( selection.getRanges(), { fake: false } );
  1253. renderer.render();
  1254. expect( domRoot.childNodes.length ).to.equal( 1 );
  1255. const domParagraph = domRoot.childNodes[ 0 ];
  1256. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1257. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1258. const domSelection = domRoot.ownerDocument.getSelection();
  1259. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1260. } );
  1261. it( 'should reuse fake selection container #1', () => {
  1262. const label = 'fake selection label';
  1263. selection._setTo( selection.getRanges(), { fake: true, label } );
  1264. renderer.render();
  1265. expect( domRoot.childNodes.length ).to.equal( 2 );
  1266. const container = domRoot.childNodes[ 1 ];
  1267. selection._setTo( selection.getRanges(), { fake: true, label } );
  1268. renderer.render();
  1269. expect( domRoot.childNodes.length ).to.equal( 2 );
  1270. const newContainer = domRoot.childNodes[ 1 ];
  1271. expect( newContainer ).equals( container );
  1272. expect( newContainer.childNodes.length ).to.equal( 1 );
  1273. const textNode = newContainer.childNodes[ 0 ];
  1274. expect( textNode.textContent ).to.equal( label );
  1275. } );
  1276. it( 'should reuse fake selection container #2', () => {
  1277. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1278. renderer.render();
  1279. expect( domRoot.childNodes.length ).to.equal( 2 );
  1280. const container = domRoot.childNodes[ 1 ];
  1281. selection._setTo( selection.getRanges(), { fake: false } );
  1282. renderer.render();
  1283. expect( domRoot.childNodes.length ).to.equal( 1 );
  1284. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1285. renderer.render();
  1286. expect( domRoot.childNodes.length ).to.equal( 2 );
  1287. const newContainer = domRoot.childNodes[ 1 ];
  1288. expect( newContainer ).equals( container );
  1289. expect( newContainer.childNodes.length ).to.equal( 1 );
  1290. const textNode = newContainer.childNodes[ 0 ];
  1291. expect( textNode.textContent ).to.equal( 'label 2' );
  1292. } );
  1293. it( 'should reuse fake selection container #3', () => {
  1294. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1295. renderer.render();
  1296. expect( domRoot.childNodes.length ).to.equal( 2 );
  1297. const container = domRoot.childNodes[ 1 ];
  1298. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1299. renderer.render();
  1300. expect( domRoot.childNodes.length ).to.equal( 2 );
  1301. const newContainer = domRoot.childNodes[ 1 ];
  1302. expect( newContainer ).equals( container );
  1303. expect( newContainer.childNodes.length ).to.equal( 1 );
  1304. const textNode = newContainer.childNodes[ 0 ];
  1305. expect( textNode.textContent ).to.equal( 'label 2' );
  1306. } );
  1307. it( 'should style fake selection container properly', () => {
  1308. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1309. renderer.render();
  1310. expect( domRoot.childNodes.length ).to.equal( 2 );
  1311. const container = domRoot.childNodes[ 1 ];
  1312. expect( container.style.position ).to.equal( 'fixed' );
  1313. expect( container.style.top ).to.equal( '0px' );
  1314. expect( container.style.left ).to.equal( '-9999px' );
  1315. } );
  1316. it( 'should bind fake selection container to view selection', () => {
  1317. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1318. renderer.render();
  1319. expect( domRoot.childNodes.length ).to.equal( 2 );
  1320. const container = domRoot.childNodes[ 1 ];
  1321. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1322. expect( bindSelection ).to.not.be.undefined;
  1323. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1324. } );
  1325. // Use a forgiving way of checking what the selection contains
  1326. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1327. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1328. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1329. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1330. expect( domSelection.toString() ).to.match( expectedText );
  1331. expect(
  1332. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1333. ).to.be.true;
  1334. }
  1335. } );
  1336. // #887
  1337. describe( 'similar selection', () => {
  1338. // Use spies to check selection updates. Some selection positions are not achievable in some
  1339. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1340. let selectionCollapseSpy, selectionExtendSpy;
  1341. afterEach( () => {
  1342. if ( selectionCollapseSpy ) {
  1343. selectionCollapseSpy.restore();
  1344. selectionCollapseSpy = null;
  1345. }
  1346. if ( selectionExtendSpy ) {
  1347. selectionExtendSpy.restore();
  1348. selectionExtendSpy = null;
  1349. }
  1350. } );
  1351. it( 'should always render collapsed selection even if it is similar', () => {
  1352. const domSelection = document.getSelection();
  1353. const { view: viewP, selection: newSelection } = parse(
  1354. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1355. viewRoot._appendChild( viewP );
  1356. selection._setTo( newSelection );
  1357. renderer.markToSync( 'children', viewRoot );
  1358. renderer.render();
  1359. const domP = domRoot.childNodes[ 0 ];
  1360. const domB = domP.childNodes[ 1 ];
  1361. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1362. expect( domSelection.isCollapsed ).to.true;
  1363. expect( domSelection.rangeCount ).to.equal( 1 );
  1364. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1365. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1366. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1367. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1368. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1369. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1370. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1371. selection._setTo( [
  1372. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1373. ] );
  1374. renderer.markToSync( 'children', viewP );
  1375. renderer.render();
  1376. expect( selectionCollapseSpy.calledOnce ).to.true;
  1377. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1378. expect( selectionExtendSpy.calledOnce ).to.true;
  1379. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1380. } );
  1381. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1382. const domSelection = document.getSelection();
  1383. const { view: viewP, selection: newSelection } = parse(
  1384. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1385. viewRoot._appendChild( viewP );
  1386. selection._setTo( newSelection );
  1387. renderer.markToSync( 'children', viewRoot );
  1388. renderer.render();
  1389. const domP = domRoot.childNodes[ 0 ];
  1390. const domB = domP.childNodes[ 1 ];
  1391. expect( domSelection.isCollapsed ).to.true;
  1392. expect( domSelection.rangeCount ).to.equal( 1 );
  1393. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1394. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1395. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1396. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1397. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1398. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1399. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1400. selection._setTo( [
  1401. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1402. ] );
  1403. renderer.markToSync( 'children', viewP );
  1404. renderer.render();
  1405. expect( selectionCollapseSpy.calledOnce ).to.true;
  1406. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1407. expect( selectionExtendSpy.calledOnce ).to.true;
  1408. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1409. } );
  1410. it( 'should always render non-collapsed selection if it not is similar', () => {
  1411. const domSelection = document.getSelection();
  1412. const { view: viewP, selection: newSelection } = parse(
  1413. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1414. viewRoot._appendChild( viewP );
  1415. selection._setTo( newSelection );
  1416. renderer.markToSync( 'children', viewRoot );
  1417. renderer.render();
  1418. const domP = domRoot.childNodes[ 0 ];
  1419. const domB = domP.childNodes[ 1 ];
  1420. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1421. expect( domSelection.isCollapsed ).to.false;
  1422. expect( domSelection.rangeCount ).to.equal( 1 );
  1423. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1424. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1425. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1426. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1427. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1428. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1429. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1430. selection._setTo( [
  1431. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1432. ] );
  1433. renderer.markToSync( 'children', viewP );
  1434. renderer.render();
  1435. expect( selectionCollapseSpy.calledOnce ).to.true;
  1436. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1437. expect( selectionExtendSpy.calledOnce ).to.true;
  1438. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1439. } );
  1440. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1441. const domSelection = document.getSelection();
  1442. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1443. viewRoot._appendChild( viewP );
  1444. selection._setTo( newSelection );
  1445. renderer.markToSync( 'children', viewRoot );
  1446. renderer.render();
  1447. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1448. // Do not change view selection.
  1449. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1450. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1451. // because DOM selection is in incorrect place.
  1452. const domP = domRoot.childNodes[ 0 ];
  1453. const domSpan = domP.childNodes[ 1 ];
  1454. domSelection.collapse( domSpan, 0 );
  1455. renderer.render();
  1456. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1457. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1458. const assertSelectionAtEndOfTextNode = () => {
  1459. expect( domSelection.anchorNode ).to.equal( domP );
  1460. expect( domSelection.anchorOffset ).to.equal( 1 );
  1461. };
  1462. const assertSelectionInsideTextNode = () => {
  1463. const textNode = domP.childNodes[ 0 ];
  1464. expect( domSelection.anchorNode ).to.equal( textNode );
  1465. expect( domSelection.anchorOffset ).to.equal( 3 );
  1466. };
  1467. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1468. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1469. } );
  1470. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1471. const domSelection = document.getSelection();
  1472. const { view: viewP, selection: newSelection } = parse(
  1473. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1474. viewRoot._appendChild( viewP );
  1475. selection._setTo( newSelection );
  1476. renderer.markToSync( 'children', viewRoot );
  1477. renderer.render();
  1478. const domP = domRoot.childNodes[ 0 ];
  1479. const domB = domP.childNodes[ 1 ];
  1480. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1481. expect( domSelection.isCollapsed ).to.false;
  1482. expect( domSelection.rangeCount ).to.equal( 1 );
  1483. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1484. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1485. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1486. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1487. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1488. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1489. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1490. selection._setTo( [
  1491. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1492. ] );
  1493. renderer.markToSync( 'children', viewP );
  1494. renderer.render();
  1495. expect( selectionCollapseSpy.notCalled ).to.true;
  1496. expect( selectionExtendSpy.notCalled ).to.true;
  1497. } );
  1498. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1499. const domSelection = document.getSelection();
  1500. const { view: viewP, selection: newSelection } = parse(
  1501. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1502. viewRoot._appendChild( viewP );
  1503. selection._setTo( newSelection );
  1504. renderer.markToSync( 'children', viewRoot );
  1505. renderer.render();
  1506. const domP = domRoot.childNodes[ 0 ];
  1507. const domB = domP.childNodes[ 1 ];
  1508. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1509. expect( domSelection.isCollapsed ).to.false;
  1510. expect( domSelection.rangeCount ).to.equal( 1 );
  1511. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1512. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1513. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1514. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1515. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1516. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1517. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1518. selection._setTo( [
  1519. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1520. ] );
  1521. renderer.markToSync( 'children', viewP );
  1522. renderer.render();
  1523. expect( selectionCollapseSpy.notCalled ).to.true;
  1524. expect( selectionExtendSpy.notCalled ).to.true;
  1525. } );
  1526. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1527. const domSelection = document.getSelection();
  1528. const { view: viewP, selection: newSelection } = parse(
  1529. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1530. viewRoot._appendChild( viewP );
  1531. selection._setTo( newSelection );
  1532. renderer.markToSync( 'children', viewRoot );
  1533. renderer.render();
  1534. const domP = domRoot.childNodes[ 0 ];
  1535. const domB = domP.childNodes[ 1 ];
  1536. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1537. expect( domSelection.isCollapsed ).to.false;
  1538. expect( domSelection.rangeCount ).to.equal( 1 );
  1539. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1540. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1541. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1542. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1543. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1544. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1545. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1546. selection._setTo( [
  1547. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1548. ] );
  1549. renderer.markToSync( 'children', viewP );
  1550. renderer.render();
  1551. expect( selectionCollapseSpy.notCalled ).to.true;
  1552. expect( selectionExtendSpy.notCalled ).to.true;
  1553. } );
  1554. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1555. const domSelection = document.getSelection();
  1556. const { view: viewP, selection: newSelection } = parse(
  1557. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1558. viewRoot._appendChild( viewP );
  1559. selection._setTo( newSelection );
  1560. renderer.markToSync( 'children', viewRoot );
  1561. renderer.render();
  1562. const domP = domRoot.childNodes[ 0 ];
  1563. const domB = domP.childNodes[ 1 ];
  1564. expect( domSelection.isCollapsed ).to.false;
  1565. expect( domSelection.rangeCount ).to.equal( 1 );
  1566. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1567. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1568. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1569. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1570. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1571. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1572. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1573. selection._setTo( [
  1574. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1575. ] );
  1576. renderer.markToSync( 'children', viewP );
  1577. renderer.render();
  1578. expect( selectionCollapseSpy.notCalled ).to.true;
  1579. expect( selectionExtendSpy.notCalled ).to.true;
  1580. } );
  1581. } );
  1582. } );
  1583. describe( '#922', () => {
  1584. let view, viewDoc, viewRoot, domRoot, converter;
  1585. beforeEach( () => {
  1586. view = new View();
  1587. viewDoc = view.document;
  1588. domRoot = document.createElement( 'div' );
  1589. document.body.appendChild( domRoot );
  1590. viewRoot = createViewRoot( viewDoc );
  1591. view.attachDomRoot( domRoot );
  1592. converter = view.domConverter;
  1593. } );
  1594. it( 'should properly render unwrapped attributes #1', () => {
  1595. setViewData( view,
  1596. '<container:p>' +
  1597. '[<attribute:italic>' +
  1598. '<attribute:strong>f</attribute:strong>' +
  1599. '</attribute:italic>]' +
  1600. '<attribute:strong>oo</attribute:strong>' +
  1601. '</container:p>'
  1602. );
  1603. // Render it to DOM to create initial DOM <-> view mappings.
  1604. view.render();
  1605. // Unwrap italic attribute element.
  1606. view.change( writer => {
  1607. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1608. } );
  1609. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  1610. // Re-render changes in view to DOM.
  1611. view.render();
  1612. // Check if DOM is rendered correctly.
  1613. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  1614. expect( checkMappings() ).to.be.true;
  1615. } );
  1616. it( 'should properly render unwrapped attributes #2', () => {
  1617. setViewData( view,
  1618. '<container:p>' +
  1619. '[<attribute:italic>' +
  1620. '<attribute:strong>foo</attribute:strong>' +
  1621. '</attribute:italic>]' +
  1622. '</container:p>' );
  1623. // Render it to DOM to create initial DOM <-> view mappings.
  1624. view.render();
  1625. // Unwrap italic attribute element and change text inside.
  1626. view.change( writer => {
  1627. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1628. } );
  1629. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  1630. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  1631. // Re-render changes in view to DOM.
  1632. view.render();
  1633. // Check if DOM is rendered correctly.
  1634. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  1635. expect( checkMappings() ).to.be.true;
  1636. } );
  1637. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  1638. setViewData( view,
  1639. '<container:p>foo</container:p>'
  1640. );
  1641. // Render it to DOM to create initial DOM <-> view mappings.
  1642. view.render();
  1643. // Change text and insert new element into paragraph.
  1644. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1645. textNode._data = 'foobar';
  1646. view.change( writer => {
  1647. writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  1648. } );
  1649. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  1650. // Re-render changes in view to DOM.
  1651. view.render();
  1652. // Check if DOM is rendered correctly.
  1653. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  1654. expect( checkMappings() ).to.be.true;
  1655. } );
  1656. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  1657. setViewData( view,
  1658. '<container:p>foo</container:p>'
  1659. );
  1660. // Render it to DOM to create initial DOM <-> view mappings.
  1661. view.render();
  1662. // Change text and insert new element into paragraph.
  1663. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1664. textNode._data = 'foobar';
  1665. view.change( writer => {
  1666. writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  1667. } );
  1668. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  1669. // Re-render changes in view to DOM.
  1670. view.render();
  1671. // Check if DOM is rendered correctly.
  1672. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  1673. expect( checkMappings() ).to.be.true;
  1674. } );
  1675. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  1676. setViewData( view,
  1677. '<container:p>' +
  1678. '<attribute:b></attribute:b>' +
  1679. '<attribute:i></attribute:i>' +
  1680. '<attribute:span></attribute:span>' +
  1681. '</container:p>'
  1682. );
  1683. // Render it to DOM to create initial DOM <-> view mappings.
  1684. view.render();
  1685. // Remove first element and reinsert it at the end.
  1686. const container = viewRoot.getChild( 0 );
  1687. const firstElement = container.getChild( 0 );
  1688. view.change( writer => {
  1689. writer.remove( ViewRange.createOn( firstElement ) );
  1690. writer.insert( new ViewPosition( container, 2 ), firstElement );
  1691. } );
  1692. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1693. // Re-render changes in view to DOM.
  1694. view.render();
  1695. // Check if DOM is rendered correctly.
  1696. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1697. expect( checkMappings() ).to.be.true;
  1698. } );
  1699. // Checks if every node in DOM tree is mapped to the view.
  1700. function checkMappings() {
  1701. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  1702. while ( domWalker.nextNode() ) {
  1703. const node = domWalker.currentNode;
  1704. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  1705. return false;
  1706. }
  1707. }
  1708. return true;
  1709. }
  1710. } );
  1711. describe( '_markDescendantTextToSync', () => {
  1712. let viewRoot;
  1713. beforeEach( () => {
  1714. viewRoot = new ViewElement( 'div' );
  1715. renderer.markedTexts.clear();
  1716. renderer.markedAttributes.clear();
  1717. renderer.markedChildren.clear();
  1718. } );
  1719. it( 'should handle null values', () => {
  1720. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  1721. renderer._markDescendantTextToSync( null );
  1722. expect( renderer.markedChildren.size ).to.equal( 0 );
  1723. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1724. expect( renderer.markedTexts.size ).to.equal( 0 );
  1725. } );
  1726. it( 'should handle element nodes', () => {
  1727. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  1728. viewRoot._appendChildren( viewP );
  1729. renderer._markDescendantTextToSync( viewP );
  1730. expect( renderer.markedChildren.size ).to.equal( 0 );
  1731. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1732. expect( renderer.markedTexts.size ).to.equal( 3 );
  1733. } );
  1734. it( 'should handle text nodes', () => {
  1735. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  1736. viewRoot._appendChildren( viewP );
  1737. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  1738. expect( renderer.markedChildren.size ).to.equal( 0 );
  1739. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1740. expect( renderer.markedTexts.size ).to.equal( 1 );
  1741. } );
  1742. it( 'should handle document fragment', () => {
  1743. const fragment = new DocumentFragment();
  1744. renderer._markDescendantTextToSync( fragment );
  1745. expect( renderer.markedChildren.size ).to.equal( 0 );
  1746. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1747. expect( renderer.markedTexts.size ).to.equal( 0 );
  1748. } );
  1749. it( 'should handle empty element nodes', () => {
  1750. const viewP = parse( '<container:p></container:p>' );
  1751. viewRoot._appendChildren( viewP );
  1752. renderer._markDescendantTextToSync( viewP );
  1753. expect( renderer.markedChildren.size ).to.equal( 0 );
  1754. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1755. expect( renderer.markedTexts.size ).to.equal( 0 );
  1756. } );
  1757. } );
  1758. } );
  1759. function renderAndExpectNoChanges( renderer, domRoot ) {
  1760. const config = {
  1761. childList: true,
  1762. characterData: true,
  1763. characterDataOldValue: true,
  1764. subtree: true
  1765. };
  1766. const mutationObserver = new window.MutationObserver( () => {
  1767. throw 'There should be not mutations';
  1768. } );
  1769. mutationObserver.observe( domRoot, config );
  1770. renderer.render();
  1771. const records = mutationObserver.takeRecords();
  1772. mutationObserver.disconnect();
  1773. expect( records.length ).to.equal( 0 );
  1774. }