renderer.js 150 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264
  1. /**
  2. * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  4. */
  5. /* globals document, window, NodeFilter, MutationObserver */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewEditableElement from '../../src/view/editableelement';
  9. import ViewContainerElement from '../../src/view/containerelement';
  10. import ViewAttributeElement from '../../src/view/attributeelement';
  11. import ViewText from '../../src/view/text';
  12. import ViewRange from '../../src/view/range';
  13. import ViewPosition from '../../src/view/position';
  14. import UIElement from '../../src/view/uielement';
  15. import DocumentSelection from '../../src/view/documentselection';
  16. import DomConverter from '../../src/view/domconverter';
  17. import Renderer from '../../src/view/renderer';
  18. import DocumentFragment from '../../src/view/documentfragment';
  19. import ViewDocument from '../../src/view/document';
  20. import DowncastWriter from '../../src/view/downcastwriter';
  21. import { parse, stringify, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  22. import { BR_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../../src/view/filler';
  23. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  24. import createViewRoot from './_utils/createroot';
  25. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  26. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  27. import env from '@ckeditor/ckeditor5-utils/src/env';
  28. import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
  29. import { StylesProcessor } from '../../src/view/stylesmap';
  30. describe( 'Renderer', () => {
  31. let selection, domConverter, renderer, viewDocument;
  32. testUtils.createSinonSandbox();
  33. beforeEach( () => {
  34. viewDocument = new ViewDocument( new StylesProcessor() );
  35. selection = new DocumentSelection();
  36. domConverter = new DomConverter( viewDocument );
  37. renderer = new Renderer( domConverter, selection );
  38. renderer.domDocuments.add( document );
  39. } );
  40. describe( 'markToSync', () => {
  41. let viewRoot;
  42. beforeEach( () => {
  43. viewRoot = new ViewElement( viewDocument, 'p' );
  44. const domRoot = document.createElement( 'p' );
  45. domConverter.bindElements( domRoot, viewRoot );
  46. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  47. renderer.markedTexts.clear();
  48. renderer.markedAttributes.clear();
  49. renderer.markedChildren.clear();
  50. } );
  51. it( 'should mark attributes which need update', () => {
  52. viewRoot._setAttribute( 'class', 'foo' );
  53. renderer.markToSync( 'attributes', viewRoot );
  54. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  55. } );
  56. it( 'should mark children which need update', () => {
  57. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  58. renderer.markToSync( 'children', viewRoot );
  59. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  60. } );
  61. it( 'should not mark children if element has no corresponding node', () => {
  62. // Overwrite viewRoot with node without coresponding DOM node.
  63. viewRoot = new ViewElement( viewDocument, 'p' );
  64. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  65. renderer.markToSync( 'children', viewRoot );
  66. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  67. } );
  68. it( 'should mark text which need update', () => {
  69. const viewText = new ViewText( viewDocument, 'foo' );
  70. viewRoot._appendChild( viewText );
  71. viewText._data = 'bar';
  72. renderer.markToSync( 'text', viewText );
  73. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  74. } );
  75. it( 'should not mark text if parent has no corresponding node', () => {
  76. const viewText = new ViewText( viewDocument, 'foo' );
  77. // Overwrite viewRoot with node without coresponding DOM node.
  78. viewRoot = new ViewElement( viewDocument, 'p' );
  79. viewRoot._appendChild( viewText );
  80. viewText._data = 'bar';
  81. renderer.markToSync( 'text', viewText );
  82. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  83. } );
  84. it( 'should throw if the type is unknown', () => {
  85. expectToThrowCKEditorError( () => {
  86. renderer.markToSync( 'UNKNOWN', viewRoot );
  87. }, /^view-renderer-unknown-type/, selection );
  88. } );
  89. } );
  90. describe( 'render', () => {
  91. let viewRoot, domRoot;
  92. beforeEach( () => {
  93. viewRoot = new ViewEditableElement( viewDocument, 'div' );
  94. viewRoot.getFillerOffset = () => null;
  95. domRoot = document.createElement( 'div' );
  96. document.body.appendChild( domRoot );
  97. domConverter.bindElements( domRoot, viewRoot );
  98. renderer.markedTexts.clear();
  99. renderer.markedAttributes.clear();
  100. renderer.markedChildren.clear();
  101. selection._setTo( null );
  102. renderer.isFocused = true;
  103. } );
  104. afterEach( () => {
  105. domRoot.remove();
  106. } );
  107. it( 'should update attributes', () => {
  108. viewRoot._setAttribute( 'class', 'foo' );
  109. renderer.markToSync( 'attributes', viewRoot );
  110. renderer.render();
  111. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  112. expect( renderer.markedAttributes.size ).to.equal( 0 );
  113. } );
  114. it( 'should remove attributes', () => {
  115. viewRoot._setAttribute( 'class', 'foo' );
  116. domRoot.setAttribute( 'id', 'bar' );
  117. domRoot.setAttribute( 'class', 'bar' );
  118. renderer.markToSync( 'attributes', viewRoot );
  119. renderer.render();
  120. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  121. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  122. expect( renderer.markedAttributes.size ).to.equal( 0 );
  123. } );
  124. it( 'should add children', () => {
  125. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  126. renderer.markToSync( 'children', viewRoot );
  127. renderer.render();
  128. expect( domRoot.childNodes.length ).to.equal( 1 );
  129. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  130. expect( renderer.markedChildren.size ).to.equal( 0 );
  131. } );
  132. it( 'should remove children', () => {
  133. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  134. renderer.markToSync( 'children', viewRoot );
  135. renderer.render();
  136. expect( domRoot.childNodes.length ).to.equal( 1 );
  137. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  138. viewRoot._removeChildren( 0, 1 );
  139. renderer.markToSync( 'children', viewRoot );
  140. renderer.render();
  141. expect( domRoot.childNodes.length ).to.equal( 0 );
  142. expect( renderer.markedChildren.size ).to.equal( 0 );
  143. } );
  144. it( 'should update text', () => {
  145. const viewText = new ViewText( viewDocument, 'foo' );
  146. viewRoot._appendChild( viewText );
  147. renderer.markToSync( 'children', viewRoot );
  148. renderer.render();
  149. expect( domRoot.childNodes.length ).to.equal( 1 );
  150. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  151. viewText._data = 'bar';
  152. renderer.markToSync( 'text', viewText );
  153. renderer.render();
  154. expect( domRoot.childNodes.length ).to.equal( 1 );
  155. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  156. expect( renderer.markedTexts.size ).to.equal( 0 );
  157. } );
  158. it( 'should not update same text', () => {
  159. const viewText = new ViewText( viewDocument, 'foo' );
  160. viewRoot._appendChild( viewText );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.render();
  163. expect( domRoot.childNodes.length ).to.equal( 1 );
  164. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  165. viewText._data = 'foo';
  166. renderer.markToSync( 'text', viewText );
  167. renderAndExpectNoChanges( renderer, domRoot );
  168. expect( domRoot.childNodes.length ).to.equal( 1 );
  169. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  170. expect( renderer.markedTexts.size ).to.equal( 0 );
  171. } );
  172. it( 'should not update text parent child list changed', () => {
  173. const viewImg = new ViewElement( viewDocument, 'img' );
  174. const viewText = new ViewText( viewDocument, 'foo' );
  175. viewRoot._appendChild( [ viewImg, viewText ] );
  176. renderer.markToSync( 'children', viewRoot );
  177. renderer.markToSync( 'text', viewText );
  178. renderer.render();
  179. expect( domRoot.childNodes.length ).to.equal( 2 );
  180. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  181. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  182. } );
  183. it( 'should not change text if it is the same during text rendering', () => {
  184. const viewText = new ViewText( viewDocument, 'foo' );
  185. viewRoot._appendChild( viewText );
  186. renderer.markToSync( 'children', viewRoot );
  187. renderer.render();
  188. // This should not be changed during the render.
  189. const domText = domRoot.childNodes[ 0 ];
  190. renderer.markToSync( 'text', viewText );
  191. renderer.render();
  192. expect( domRoot.childNodes.length ).to.equal( 1 );
  193. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  194. } );
  195. it( 'should not change text if it is the same during children rendering', () => {
  196. const viewText = new ViewText( viewDocument, 'foo' );
  197. viewRoot._appendChild( viewText );
  198. renderer.markToSync( 'children', viewRoot );
  199. renderer.render();
  200. // This should not be changed during the render.
  201. const domText = domRoot.childNodes[ 0 ];
  202. renderer.markToSync( 'children', viewRoot );
  203. renderer.render();
  204. expect( domRoot.childNodes.length ).to.equal( 1 );
  205. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  206. } );
  207. it( 'should not change element if it is the same', () => {
  208. const viewImg = new ViewElement( viewDocument, 'img' );
  209. viewRoot._appendChild( viewImg );
  210. // This should not be changed during the render.
  211. const domImg = document.createElement( 'img' );
  212. domRoot.appendChild( domImg );
  213. domConverter.bindElements( domImg, viewImg );
  214. renderer.markToSync( 'children', viewRoot );
  215. renderer.render();
  216. expect( domRoot.childNodes.length ).to.equal( 1 );
  217. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  218. } );
  219. it( 'should change element if it is different', () => {
  220. const viewImg = new ViewElement( viewDocument, 'img' );
  221. viewRoot._appendChild( viewImg );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. const viewP = new ViewElement( viewDocument, 'p' );
  225. viewRoot._removeChildren( 0, 1 );
  226. viewRoot._appendChild( viewP );
  227. renderer.markToSync( 'children', viewRoot );
  228. renderer.render();
  229. expect( domRoot.childNodes.length ).to.equal( 1 );
  230. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  231. } );
  232. it( 'should update removed item when it is reinserted', () => {
  233. const viewFoo = new ViewText( viewDocument, 'foo' );
  234. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  235. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  236. viewRoot._appendChild( viewDiv );
  237. renderer.markToSync( 'children', viewRoot );
  238. renderer.render();
  239. viewDiv._removeChildren( 0, 1 );
  240. renderer.markToSync( 'children', viewDiv );
  241. renderer.render();
  242. viewP._removeChildren( 0, 1 );
  243. viewDiv._appendChild( viewP );
  244. renderer.markToSync( 'children', viewDiv );
  245. renderer.render();
  246. expect( domRoot.childNodes.length ).to.equal( 1 );
  247. const domDiv = domRoot.childNodes[ 0 ];
  248. expect( domDiv.tagName ).to.equal( 'DIV' );
  249. expect( domDiv.childNodes.length ).to.equal( 1 );
  250. const domP = domDiv.childNodes[ 0 ];
  251. expect( domP.tagName ).to.equal( 'P' );
  252. expect( domP.childNodes.length ).to.equal( 0 );
  253. } );
  254. it( 'should update removed item when it is reinserted #2', () => {
  255. // Prepare view: root -> div "outer" -> div "inner" -> p.
  256. const viewP = new ViewElement( viewDocument, 'p' );
  257. const viewDivInner = new ViewElement( viewDocument, 'div', null, viewP );
  258. const viewDivOuter = new ViewElement( viewDocument, 'div', null, viewDivInner );
  259. viewRoot._appendChild( viewDivOuter );
  260. // Render view tree to DOM.
  261. renderer.markToSync( 'children', viewRoot );
  262. renderer.render();
  263. // Remove div "outer" from root and render it.
  264. viewDivOuter._remove();
  265. renderer.markToSync( 'children', viewRoot );
  266. renderer.render();
  267. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  268. viewP._remove();
  269. // Add div "outer" back to root.
  270. viewRoot._appendChild( viewDivOuter );
  271. renderer.markToSync( 'children', viewRoot );
  272. // Render changes, view is: root -> div "outer" -> div "inner".
  273. renderer.render();
  274. // Same is expected in DOM.
  275. expect( domRoot.childNodes.length ).to.equal( 1 );
  276. const domDivOuter = domRoot.childNodes[ 0 ];
  277. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  278. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  279. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  280. const domDivInner = domDivOuter.childNodes[ 0 ];
  281. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  282. expect( domDivInner.tagName ).to.equal( 'DIV' );
  283. expect( domDivInner.childNodes.length ).to.equal( 0 );
  284. } );
  285. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  286. const viewFoo = new ViewText( viewDocument, 'foo' );
  287. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  288. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  289. viewRoot._appendChild( viewDiv );
  290. renderer.markToSync( 'children', viewRoot );
  291. renderer.render();
  292. viewRoot._removeChildren( 0, 1 );
  293. renderer.markToSync( 'children', viewRoot );
  294. viewDiv._removeChildren( 0, 1 );
  295. renderer.markToSync( 'children', viewDiv );
  296. viewP._removeChildren( 0, 1 );
  297. renderer.markToSync( 'children', viewP );
  298. renderer.render();
  299. expect( domRoot.childNodes.length ).to.equal( 0 );
  300. } );
  301. it( 'should not care about filler if there is no DOM', () => {
  302. const { view: viewP, selection: newSelection } = parse(
  303. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  304. const viewRoot = new ViewElement( viewDocument, 'p' );
  305. viewRoot._appendChild( viewP );
  306. selection._setTo( newSelection );
  307. renderer.markToSync( 'children', viewRoot );
  308. renderer.render();
  309. // Expect no error on render.
  310. expect( viewRoot ).to.be.ok;
  311. } );
  312. it( 'should not add filler when inside contenteditable=false parent', () => {
  313. const { view: viewP, selection: newSelection } = parse(
  314. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  315. viewRoot._appendChild( viewP );
  316. selection._setTo( newSelection );
  317. renderer.markToSync( 'children', viewRoot );
  318. renderer.render();
  319. expect( domRoot.childNodes.length ).to.equal( 1 );
  320. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  321. const domP = domRoot.childNodes[ 0 ];
  322. expect( domP.childNodes.length ).to.equal( 3 );
  323. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  324. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  325. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  326. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  327. } );
  328. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  329. const { view: viewP, selection: newSelection } = parse(
  330. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  331. viewRoot._appendChild( viewP );
  332. selection._setTo( newSelection );
  333. renderer.markToSync( 'children', viewRoot );
  334. renderer.render();
  335. expect( domRoot.childNodes.length ).to.equal( 1 );
  336. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  337. const domP = domRoot.childNodes[ 0 ];
  338. expect( domP.childNodes.length ).to.equal( 3 );
  339. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  340. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  341. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  342. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  343. } );
  344. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  345. const domSelection = document.getSelection();
  346. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  347. const { view: viewP, selection: newSelection } = parse(
  348. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  349. viewRoot._appendChild( viewP );
  350. selection._setTo( newSelection );
  351. renderer.markToSync( 'children', viewRoot );
  352. renderer.render();
  353. expect( domRoot.childNodes.length ).to.equal( 1 );
  354. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  355. const domP = domRoot.childNodes[ 0 ];
  356. expect( domP.childNodes.length ).to.equal( 3 );
  357. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  358. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  359. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  360. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  361. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  362. expect( domSelection.rangeCount ).to.equal( 1 );
  363. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  364. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  365. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  366. // Step 2: No mutation on second render
  367. renderer.markToSync( 'children', viewRoot );
  368. renderer.markToSync( 'children', viewP );
  369. renderAndExpectNoChanges( renderer, domRoot );
  370. // Step 3: <p>foo{}<b></b></p>
  371. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  372. renderer.render();
  373. expect( domP.childNodes.length ).to.equal( 3 );
  374. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  375. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  376. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  377. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  378. expect( domSelection.rangeCount ).to.equal( 1 );
  379. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  380. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  381. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  382. // Step 4: No mutation on second render
  383. renderer.markToSync( 'children', viewRoot );
  384. renderer.markToSync( 'children', viewP );
  385. renderAndExpectNoChanges( renderer, domRoot );
  386. } );
  387. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  388. const domSelection = document.getSelection();
  389. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  390. const { view: viewP, selection: newSelection } = parse(
  391. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  392. viewRoot._appendChild( viewP );
  393. selection._setTo( newSelection );
  394. renderer.markToSync( 'children', viewRoot );
  395. renderer.render();
  396. const domP = domRoot.childNodes[ 0 ];
  397. expect( domP.childNodes.length ).to.equal( 2 );
  398. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  399. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  400. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  401. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  402. expect( domSelection.rangeCount ).to.equal( 1 );
  403. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  404. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  405. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  406. // Step 2: No mutation on second render
  407. renderer.markToSync( 'children', viewP );
  408. renderAndExpectNoChanges( renderer, domRoot );
  409. // Step 3: <p><b>{}foo</b></p>
  410. selection._setTo( ViewRange._createFromParentsAndOffsets(
  411. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  412. renderer.render();
  413. expect( domP.childNodes.length ).to.equal( 1 );
  414. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  415. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  416. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  417. expect( domSelection.rangeCount ).to.equal( 1 );
  418. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  419. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  420. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  421. // Step 4: No mutation on second render
  422. renderer.markToSync( 'children', viewP );
  423. renderAndExpectNoChanges( renderer, domRoot );
  424. } );
  425. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  426. const domSelection = document.getSelection();
  427. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  428. const { view: viewP, selection: newSelection } = parse(
  429. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  430. viewRoot._appendChild( viewP );
  431. selection._setTo( newSelection );
  432. renderer.markToSync( 'children', viewRoot );
  433. renderer.render();
  434. const domP = domRoot.childNodes[ 0 ];
  435. expect( domP.childNodes.length ).to.equal( 2 );
  436. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  437. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  438. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  439. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  440. expect( domSelection.rangeCount ).to.equal( 1 );
  441. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  442. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  443. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  444. // Step 2: No mutation on second render
  445. renderer.markToSync( 'children', viewP );
  446. renderAndExpectNoChanges( renderer, domRoot );
  447. // Step 3: <p><b>foo{}</b></p>
  448. selection._setTo( ViewRange._createFromParentsAndOffsets(
  449. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  450. renderer.render();
  451. expect( domP.childNodes.length ).to.equal( 1 );
  452. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  453. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  454. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  455. expect( domSelection.rangeCount ).to.equal( 1 );
  456. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  457. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  458. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  459. // Step 4: No mutation on second render
  460. renderer.markToSync( 'children', viewP );
  461. renderAndExpectNoChanges( renderer, domRoot );
  462. } );
  463. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  464. const domSelection = document.getSelection();
  465. const { view: viewP, selection: newSelection } = parse(
  466. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  467. viewRoot._appendChild( viewP );
  468. selection._setTo( newSelection );
  469. renderer.markToSync( 'children', viewRoot );
  470. renderer.render();
  471. const domP = domRoot.childNodes[ 0 ];
  472. expect( domP.childNodes.length ).to.equal( 3 );
  473. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  474. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  475. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  476. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  477. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  478. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  479. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  480. expect( domSelection.rangeCount ).to.equal( 1 );
  481. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  482. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  483. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  484. } );
  485. it( 'should move filler when selection is moved', () => {
  486. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  487. const { view: viewP, selection: newSelection } = parse(
  488. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  489. viewRoot._appendChild( viewP );
  490. selection._setTo( newSelection );
  491. renderer.markToSync( 'children', viewRoot );
  492. renderer.render();
  493. const domP = domRoot.childNodes[ 0 ];
  494. expect( domP.childNodes.length ).to.equal( 3 );
  495. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  496. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  497. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  498. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  499. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  500. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  501. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  502. const viewI = viewP.getChild( 2 );
  503. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  504. renderer.render();
  505. expect( domP.childNodes.length ).to.equal( 3 );
  506. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  507. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  508. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  509. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  510. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  511. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  512. } );
  513. it( 'should remove filler when text is added and selection removed', () => {
  514. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  515. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  516. const viewB = viewP.getChild( 1 );
  517. viewRoot._appendChild( viewP );
  518. selection._setTo( newSelection );
  519. renderer.markToSync( 'children', viewRoot );
  520. renderer.render();
  521. const domP = domRoot.childNodes[ 0 ];
  522. expect( domP.childNodes.length ).to.equal( 2 );
  523. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  524. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  525. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  526. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  527. // Step 2: Add text node.
  528. const viewText = new ViewText( viewDocument, 'x' );
  529. viewB._appendChild( viewText );
  530. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  531. renderer.markToSync( 'children', viewB );
  532. renderer.render();
  533. // Step 3: Remove selection from the view.
  534. selection._setTo( null );
  535. renderer.render();
  536. expect( domP.childNodes.length ).to.equal( 2 );
  537. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  538. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  539. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  540. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  541. } );
  542. // #659
  543. // The element before the filler is removed so the position of the filler
  544. // cannot be remembered as parent+offset.
  545. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  546. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  547. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  548. viewRoot._appendChild( viewP );
  549. selection._setTo( newSelection );
  550. renderer.markToSync( 'children', viewRoot );
  551. renderer.render();
  552. const domP = domRoot.childNodes[ 0 ];
  553. expect( domP.childNodes.length ).to.equal( 3 );
  554. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  555. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  556. viewP._removeChildren( 1 );
  557. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  558. renderer.markToSync( 'children', viewP );
  559. renderer.render();
  560. // Step 3: Check whether there's no filler in the DOM.
  561. expect( domP.childNodes.length ).to.equal( 1 );
  562. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  563. } );
  564. // #659
  565. it( 'should remove filler from a modified DOM when children moved', () => {
  566. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  567. const { view: viewFragment, selection: newSelection } = parse(
  568. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  569. );
  570. viewRoot._appendChild( viewFragment );
  571. selection._setTo( newSelection );
  572. renderer.markToSync( 'children', viewRoot );
  573. renderer.render();
  574. expect( domRoot.childNodes.length ).to.equal( 2 );
  575. const domP = domRoot.childNodes[ 0 ];
  576. const domP2 = domRoot.childNodes[ 1 ];
  577. expect( domP.childNodes.length ).to.equal( 3 );
  578. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  579. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  580. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  581. const viewP = viewRoot.getChild( 0 );
  582. const viewP2 = viewRoot.getChild( 1 );
  583. const removedChildren = viewP._removeChildren( 0, 2 );
  584. viewP2._appendChild( removedChildren );
  585. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  586. renderer.markToSync( 'children', viewP );
  587. renderer.markToSync( 'children', viewP2 );
  588. renderer.render();
  589. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  590. // in the second one there are two <b> tags.
  591. expect( domP.childNodes.length ).to.equal( 1 );
  592. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  593. expect( domP2.childNodes.length ).to.equal( 2 );
  594. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  595. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  596. } );
  597. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  598. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  599. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  600. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  601. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  602. viewRoot._appendChild( viewP );
  603. selection._setTo( newSelection );
  604. renderer.markToSync( 'children', viewRoot );
  605. renderer.render();
  606. const domP = domRoot.childNodes[ 0 ];
  607. expect( domP.childNodes.length ).to.equal( 2 );
  608. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  609. // Step 2: Move selection to a new attribute element and remove the previous one
  610. viewP._removeChildren( 1 ); // Remove <b>.
  611. const viewI = parse( '<attribute:i></attribute:i>' );
  612. viewP._appendChild( viewI );
  613. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  614. renderer.markToSync( 'children', viewP );
  615. renderer.render();
  616. // Step 3: Check whether new filler was created in the <i> element.
  617. expect( domP.childNodes.length ).to.equal( 2 );
  618. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  619. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  620. } );
  621. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  622. // that has not been yet rendered/bound to DOM.
  623. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  624. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  625. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  626. viewRoot._appendChild( viewP );
  627. selection._setTo( newSelection );
  628. renderer.markToSync( 'children', viewRoot );
  629. renderer.render();
  630. const domP = domRoot.childNodes[ 0 ];
  631. expect( domP.childNodes.length ).to.equal( 3 );
  632. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  633. // Step 2: Move selection to a new attribute element.
  634. const viewAbc = parse( 'abc' );
  635. viewP._appendChild( viewAbc );
  636. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  637. renderer.markToSync( 'children', viewP );
  638. renderer.render();
  639. // Step 3: Check whether old filler was removed.
  640. expect( domP.childNodes.length ).to.equal( 3 );
  641. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  642. } );
  643. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  644. const domSelection = document.getSelection();
  645. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  646. viewRoot._appendChild( viewP );
  647. selection._setTo( newSelection );
  648. renderer.markToSync( 'children', viewRoot );
  649. renderer.render();
  650. const domP = domRoot.childNodes[ 0 ];
  651. expect( domP.childNodes.length ).to.equal( 1 );
  652. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  653. expect( domSelection.rangeCount ).to.equal( 1 );
  654. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  655. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  656. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  657. // Remove filler and add text node to both DOM and View <p>x{}</p>
  658. domP.removeChild( domP.childNodes[ 0 ] );
  659. domP.appendChild( document.createTextNode( 'x' ) );
  660. domSelection.removeAllRanges();
  661. const domRange = document.createRange();
  662. domRange.setStart( domP.childNodes[ 0 ], 1 );
  663. domRange.collapse( true );
  664. domSelection.addRange( domRange );
  665. const viewText = new ViewText( viewDocument, 'x' );
  666. viewP._appendChild( viewText );
  667. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  668. renderer.markToSync( 'children', viewP );
  669. renderAndExpectNoChanges( renderer, domRoot );
  670. } );
  671. it( 'should handle typing in empty block, render if needed', () => {
  672. const domSelection = document.getSelection();
  673. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  674. viewRoot._appendChild( viewP );
  675. selection._setTo( newSelection );
  676. renderer.markToSync( 'children', viewRoot );
  677. renderer.render();
  678. const domP = domRoot.childNodes[ 0 ];
  679. expect( domP.childNodes.length ).to.equal( 1 );
  680. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  681. expect( domSelection.rangeCount ).to.equal( 1 );
  682. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  683. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  684. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  685. // Add text node only in View <p>x{}</p>
  686. const viewText = new ViewText( viewDocument, 'x' );
  687. viewP._appendChild( viewText );
  688. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  689. renderer.markToSync( 'children', viewP );
  690. renderer.render();
  691. expect( domP.childNodes.length ).to.equal( 1 );
  692. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  693. expect( domSelection.rangeCount ).to.equal( 1 );
  694. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  695. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  696. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  697. } );
  698. it( 'should handle removing last character', () => {
  699. const domSelection = document.getSelection();
  700. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  701. viewRoot._appendChild( viewP );
  702. selection._setTo( newSelection );
  703. renderer.markToSync( 'children', viewRoot );
  704. renderer.render();
  705. const domP = domRoot.childNodes[ 0 ];
  706. expect( domP.childNodes.length ).to.equal( 1 );
  707. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  708. expect( domSelection.rangeCount ).to.equal( 1 );
  709. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  710. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  711. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  712. // Remove text and add filler to both DOM and View <p>{}</p>
  713. domP.removeChild( domP.childNodes[ 0 ] );
  714. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  715. domSelection.removeAllRanges();
  716. const domRange = document.createRange();
  717. domRange.setStart( domP.childNodes[ 0 ], 0 );
  718. domRange.collapse( true );
  719. domSelection.addRange( domRange );
  720. viewP._removeChildren( 0 );
  721. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  722. renderer.markToSync( 'children', viewP );
  723. renderAndExpectNoChanges( renderer, domRoot );
  724. } );
  725. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  726. const domSelection = document.getSelection();
  727. // 1. Render <p><b>FILLER{}</b>foo</p>.
  728. const { view: viewP, selection: newSelection } = parse(
  729. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  730. viewRoot._appendChild( viewP );
  731. selection._setTo( newSelection );
  732. renderer.markToSync( 'children', viewRoot );
  733. renderer.render();
  734. // 2. Check the DOM.
  735. const domP = domRoot.childNodes[ 0 ];
  736. expect( domP.childNodes.length ).to.equal( 2 );
  737. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  738. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  739. const domB = domP.childNodes[ 0 ];
  740. const viewB = viewP.getChild( 0 );
  741. expect( domB.childNodes.length ).to.equal( 1 );
  742. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  743. expect( domSelection.rangeCount ).to.equal( 1 );
  744. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  745. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  746. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  747. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  748. domB.childNodes[ 0 ].data += 'x';
  749. domSelection.removeAllRanges();
  750. const domRange = document.createRange();
  751. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  752. domRange.collapse( true );
  753. domSelection.addRange( domRange );
  754. const viewText = new ViewText( viewDocument, 'x' );
  755. viewB._appendChild( viewText );
  756. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  757. renderer.markToSync( 'children', viewP );
  758. renderAndExpectNoChanges( renderer, domRoot );
  759. } );
  760. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  761. const domSelection = document.getSelection();
  762. // 1. Render <p><b>FILLER{}</b>foo</p>.
  763. const { view: viewP, selection: newSelection } = parse(
  764. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  765. viewRoot._appendChild( viewP );
  766. selection._setTo( newSelection );
  767. renderer.markToSync( 'children', viewRoot );
  768. renderer.render();
  769. // 2. Check the DOM.
  770. const domP = domRoot.childNodes[ 0 ];
  771. expect( domP.childNodes.length ).to.equal( 2 );
  772. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  773. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  774. const domB = domP.childNodes[ 0 ];
  775. const viewB = viewP.getChild( 0 );
  776. expect( domB.childNodes.length ).to.equal( 1 );
  777. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  778. expect( domSelection.rangeCount ).to.equal( 1 );
  779. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  780. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  781. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  782. domSelection.removeAllRanges();
  783. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  784. const viewText = new ViewText( viewDocument, 'x' );
  785. viewB._appendChild( viewText );
  786. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  787. renderer.markToSync( 'children', viewB );
  788. renderer.render();
  789. expect( domB.childNodes.length ).to.equal( 1 );
  790. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  791. expect( domSelection.rangeCount ).to.equal( 1 );
  792. // Depending on the browser selection may end up at the end of the text node or after the text node.
  793. const firstRange = domSelection.getRangeAt( 0 );
  794. const assertSelectionAtEndOfTextNode = () => {
  795. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  796. };
  797. const assertSelectionInsideTextNode = () => {
  798. expect( firstRange.startContainer ).to.equal( domB );
  799. expect( firstRange.startOffset ).to.equal( 1 );
  800. };
  801. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  802. expect( firstRange.collapsed ).to.be.true;
  803. } );
  804. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  805. const domSelection = document.getSelection();
  806. // 1. Render <p><b>FILLER{}</b>foo</p>.
  807. const { view: viewP, selection: newSelection } = parse(
  808. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  809. viewRoot._appendChild( viewP );
  810. selection._setTo( newSelection );
  811. renderer.markToSync( 'children', viewRoot );
  812. renderer.render();
  813. // 2. Check the DOM.
  814. const domP = domRoot.childNodes[ 0 ];
  815. expect( domP.childNodes.length ).to.equal( 2 );
  816. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  817. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  818. const domB = domP.childNodes[ 0 ];
  819. const viewB = viewP.getChild( 0 );
  820. expect( domB.childNodes.length ).to.equal( 1 );
  821. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  822. expect( domSelection.rangeCount ).to.equal( 1 );
  823. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  824. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  825. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  826. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  827. const viewText = new ViewText( viewDocument, 'x' );
  828. viewB._appendChild( viewText );
  829. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  830. renderer.markToSync( 'text', viewText );
  831. renderer.render();
  832. // 4. Check the DOM.
  833. expect( domB.childNodes.length ).to.equal( 1 );
  834. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  835. expect( domSelection.rangeCount ).to.equal( 1 );
  836. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  837. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  838. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  839. } );
  840. it( 'should handle not collapsed range', () => {
  841. const domSelection = document.getSelection();
  842. const { view: viewP, selection: newSelection } = parse(
  843. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  844. viewRoot._appendChild( viewP );
  845. selection._setTo( newSelection );
  846. renderer.markToSync( 'children', viewRoot );
  847. renderer.render();
  848. const domP = domRoot.childNodes[ 0 ];
  849. expect( domP.childNodes.length ).to.equal( 2 );
  850. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  851. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  852. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  853. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  854. expect( domSelection.rangeCount ).to.equal( 1 );
  855. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  856. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  857. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  858. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  859. renderer.markToSync( 'children', viewP );
  860. renderAndExpectNoChanges( renderer, domRoot );
  861. } );
  862. it( 'should not change selection if there is no editable with selection', () => {
  863. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  864. document.body.appendChild( domDiv );
  865. domDiv.focus();
  866. const domSelection = document.getSelection();
  867. domSelection.removeAllRanges();
  868. domSelection.collapse( domDiv, 0 );
  869. const viewDiv = new ViewElement( viewDocument, 'div' );
  870. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  871. viewDiv._appendChild( viewP );
  872. selection._setTo( newSelection );
  873. renderer.render();
  874. expect( domSelection.rangeCount ).to.equal( 1 );
  875. // Depending on the browser selection may end up before the text node or at the beginning of it.
  876. const domRange = domSelection.getRangeAt( 0 );
  877. const assertSelectionAtEndOfTextNode = () => {
  878. expect( domRange.startContainer ).to.equal( domDiv );
  879. };
  880. const assertSelectionInsideTextNode = () => {
  881. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  882. };
  883. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  884. expect( domRange.startOffset ).to.equal( 0 );
  885. expect( domRange.collapsed ).to.be.true;
  886. domDiv.remove();
  887. } );
  888. it( 'should not change selection if there is no focus', () => {
  889. const domDiv = createElement( document, 'div', null, 'not editable' );
  890. document.body.appendChild( domDiv );
  891. const domSelection = document.getSelection();
  892. domSelection.removeAllRanges();
  893. const domRange = document.createRange();
  894. domRange.setStart( domDiv, 0 );
  895. domRange.collapse( true );
  896. domSelection.addRange( domRange );
  897. renderer.isFocused = false;
  898. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  899. viewRoot._appendChild( viewP );
  900. selection._setTo( newSelection );
  901. renderer.render();
  902. expect( domSelection.rangeCount ).to.equal( 1 );
  903. // Depending on the browser selection may end up before the text node or at the beginning of it.
  904. const domSelectionRange = domSelection.getRangeAt( 0 );
  905. const assertSelectionAtEndOfTextNode = () => {
  906. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  907. };
  908. const assertSelectionInsideTextNode = () => {
  909. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  910. };
  911. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  912. expect( domSelectionRange.startOffset ).to.equal( 0 );
  913. expect( domSelectionRange.collapsed ).to.be.true;
  914. domDiv.remove();
  915. } );
  916. it( 'should not add inline filler after text node', () => {
  917. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  918. viewRoot._appendChild( viewP );
  919. selection._setTo( newSelection );
  920. renderer.markToSync( 'children', viewRoot );
  921. renderer.render();
  922. const domP = domRoot.childNodes[ 0 ];
  923. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  924. } );
  925. it( 'should throw if there is no filler in expected position', () => {
  926. const { view: viewP, selection: newSelection } = parse(
  927. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  928. viewRoot._appendChild( viewP );
  929. selection._setTo( newSelection );
  930. renderer.markToSync( 'children', viewRoot );
  931. renderer.render();
  932. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  933. const viewB = viewP.getChild( 1 );
  934. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  935. // Remove filler.
  936. domB.childNodes[ 0 ].data = '';
  937. selection._setTo( null );
  938. renderer.markToSync( 'children', viewB );
  939. expectToThrowCKEditorError( () => {
  940. renderer.render();
  941. }, /^view-renderer-filler-was-lost/, selection );
  942. } );
  943. // #1014.
  944. it( 'should create inline filler in newly created dom nodes', () => {
  945. // 1. Create the view structure which needs inline filler.
  946. const inputView =
  947. '<container:ul>' +
  948. '<container:li>Foobar.</container:li>' +
  949. '<container:li>[]<container:div></container:div></container:li>' +
  950. '</container:ul>';
  951. const { view: view, selection: newSelection } = parse( inputView );
  952. viewRoot._appendChild( view );
  953. selection._setTo( newSelection );
  954. renderer.markToSync( 'children', viewRoot );
  955. renderer.render();
  956. // 2. Check if filler element has been (correctly) created.
  957. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  958. // 3. Move the inline filler parent to a newly created element.
  959. const viewLi = view.getChild( 0 );
  960. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  961. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  962. viewLi._appendChild( viewUl );
  963. // 4. Mark changed items and render the view.
  964. renderer.markToSync( 'children', view );
  965. renderer.markToSync( 'children', viewLi );
  966. renderer.render();
  967. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  968. const domSelection = document.getSelection();
  969. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  970. } );
  971. it( 'should handle focusing element', () => {
  972. selection._setTo( viewRoot, 0 );
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. renderer.render();
  975. expect( domFocusSpy.called ).to.be.true;
  976. } );
  977. it( 'should not focus editable if isFocues is set to false', () => {
  978. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  979. renderer.isFocused = false;
  980. renderer.render();
  981. expect( domFocusSpy.calledOnce ).to.be.false;
  982. } );
  983. it( 'should not focus already focused DOM element', () => {
  984. domRoot.setAttribute( 'contentEditable', true );
  985. domRoot.focus();
  986. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  987. renderer.render();
  988. expect( domFocusSpy.called ).to.be.false;
  989. } );
  990. it( 'should render NBSP as last space in the previous inline element', () => {
  991. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  992. viewRoot._appendChild( viewP );
  993. renderer.markToSync( 'children', viewRoot );
  994. renderer.render();
  995. const domP = domRoot.childNodes[ 0 ];
  996. const domB = domP.childNodes[ 1 ];
  997. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  998. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  999. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1000. // Insert space resulting in '<p>x <b> y</b></p>'.
  1001. const viewB = viewP.getChild( 1 );
  1002. viewB._removeChildren( 0 );
  1003. viewB._appendChild( new ViewText( viewDocument, ' y' ) );
  1004. renderer.markToSync( 'children', viewP );
  1005. renderer.render();
  1006. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1007. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1008. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1009. } );
  1010. it( 'should update sibling after, when node before is removed', () => {
  1011. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1012. viewRoot._appendChild( viewP );
  1013. renderer.markToSync( 'children', viewRoot );
  1014. renderer.render();
  1015. const domP = domRoot.childNodes[ 0 ];
  1016. const domB = domP.childNodes[ 1 ];
  1017. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1018. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1019. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1020. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1021. viewP._removeChildren( 0 );
  1022. renderer.markToSync( 'children', viewP );
  1023. renderer.render();
  1024. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1025. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1026. } );
  1027. it( 'should update sibling before, when node after is removed', () => {
  1028. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1029. viewRoot._appendChild( viewP );
  1030. renderer.markToSync( 'children', viewRoot );
  1031. renderer.render();
  1032. const domP = domRoot.childNodes[ 0 ];
  1033. const domB = domP.childNodes[ 1 ];
  1034. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1035. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1036. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1037. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1038. viewP._removeChildren( 1 );
  1039. renderer.markToSync( 'children', viewP );
  1040. renderer.render();
  1041. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1042. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1043. } );
  1044. // #1093
  1045. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1046. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1047. viewRoot._appendChild( viewP );
  1048. renderer.markToSync( 'children', viewRoot );
  1049. renderer.render();
  1050. const domP = domRoot.childNodes[ 0 ];
  1051. const domB = domP.childNodes[ 1 ];
  1052. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1053. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1054. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1055. // Insert space resulting in '<p>x <b> y</b></p>'.
  1056. viewP._removeChildren( 0 );
  1057. viewP._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1058. renderer.markToSync( 'children', viewP );
  1059. renderer.render();
  1060. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1061. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1062. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1063. } );
  1064. // #1093
  1065. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1066. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1067. viewRoot._appendChild( viewP );
  1068. renderer.markToSync( 'children', viewRoot );
  1069. renderer.render();
  1070. const domP = domRoot.childNodes[ 0 ];
  1071. const domB = domP.childNodes[ 0 ];
  1072. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1073. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1074. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1075. // Insert space resulting in '<p><b>x </b> y</p>'.
  1076. const viewB = viewP.getChild( 0 );
  1077. viewB._removeChildren( 0 );
  1078. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1079. renderer.markToSync( 'children', viewP );
  1080. renderer.render();
  1081. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1082. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1083. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b> y' );
  1084. } );
  1085. // #1093
  1086. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1087. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1088. viewRoot._appendChild( viewP );
  1089. renderer.markToSync( 'children', viewRoot );
  1090. renderer.render();
  1091. const domP = domRoot.childNodes[ 0 ];
  1092. const domB = domP.childNodes[ 0 ];
  1093. const domI = domP.childNodes[ 1 ];
  1094. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1095. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1096. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1097. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1098. const viewB = viewP.getChild( 0 );
  1099. viewB._removeChildren( 0 );
  1100. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1101. renderer.markToSync( 'children', viewP );
  1102. renderer.render();
  1103. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1104. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1105. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b><i> y</i>' );
  1106. } );
  1107. // #1125
  1108. it( 'should properly rerender many changes done in one batch', () => {
  1109. // This test transforms:
  1110. //
  1111. // <h2>He<strong>ding 1</strong></h2>
  1112. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1113. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1114. //
  1115. // into:
  1116. //
  1117. // <h2>Heading 2</h2>
  1118. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1119. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1120. //
  1121. // during one rerender to check if complex structure changes are rerendered correctly.
  1122. const viewContent = parse( '' +
  1123. '<container:h2>He' +
  1124. '<attribute:i>ading 1</attribute:i>' +
  1125. '</container:h2>' +
  1126. '<container:p>Ph ' +
  1127. '<attribute:strong>Bold</attribute:strong> ' +
  1128. '<attribute:i>It' +
  1129. '<attribute:strong>alic</attribute:strong>' +
  1130. '</attribute:i> ' +
  1131. '<attribute:a href="https://ckeditor.com">' +
  1132. '<attribute:strong>Lin</attribute:strong>' +
  1133. 'k</attribute:a>' +
  1134. '</container:p>' +
  1135. '<container:blockquote>' +
  1136. '<container:ul>' +
  1137. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1138. '</container:ul>' +
  1139. '</container:blockquote>' );
  1140. viewRoot._appendChild( viewContent );
  1141. renderer.markToSync( 'children', viewRoot );
  1142. renderer.render();
  1143. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1144. const viewHeading = viewRoot.getChild( 0 );
  1145. viewHeading._removeChildren( 0, viewHeading.childCount );
  1146. viewHeading._insertChild( 0, new ViewText( viewDocument, 'Heading 2' ) );
  1147. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1148. renderer.markToSync( 'children', viewRoot );
  1149. renderer.markToSync( 'children', viewHeading );
  1150. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1151. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1152. // ->
  1153. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1154. const viewP = viewRoot.getChild( 1 );
  1155. viewP._removeChildren( 0, viewP.childCount );
  1156. viewP._insertChild(
  1157. 0,
  1158. parse(
  1159. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1160. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1161. )
  1162. );
  1163. renderer.markToSync( 'children', viewRoot );
  1164. renderer.markToSync( 'children', viewP );
  1165. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1166. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1167. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1168. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1169. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1170. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1171. const viewBq = viewRoot.getChild( 2 );
  1172. viewBq._removeChildren( 0, viewBq.childCount );
  1173. viewBq._insertChild(
  1174. 0,
  1175. parse(
  1176. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1177. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1178. )
  1179. );
  1180. renderer.markToSync( 'children', viewRoot );
  1181. renderer.markToSync( 'children', viewBq );
  1182. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1183. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1184. renderer.render();
  1185. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1186. '<h2>Heading 2</h2>' +
  1187. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1188. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1189. );
  1190. } );
  1191. // #1125
  1192. it( 'should properly rerender changes when whole content replaced at once', () => {
  1193. // This test replaces:
  1194. //
  1195. // <h1>Header</h1>
  1196. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1197. //
  1198. // with:
  1199. //
  1200. // <h2>Header</h2>
  1201. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1202. //
  1203. // during one rerender to check if complex structure changes are rerendered correctly.
  1204. const viewContent = parse(
  1205. '<container:h1>Header</container:h1>' +
  1206. '<container:blockquote>' +
  1207. '<container:ul>' +
  1208. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1209. '<container:li>Item 2</container:li>' +
  1210. '</container:ul>' +
  1211. '</container:blockquote>'
  1212. );
  1213. viewRoot._appendChild( viewContent );
  1214. renderer.markToSync( 'children', viewRoot );
  1215. renderer.render();
  1216. const newViewContent = parse(
  1217. '<container:h2>Header</container:h2>' +
  1218. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1219. );
  1220. viewRoot._removeChildren( 0, viewRoot.childCount );
  1221. viewRoot._appendChild( newViewContent );
  1222. renderer.markToSync( 'children', viewRoot );
  1223. renderer.render();
  1224. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1225. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1226. );
  1227. } );
  1228. // #1451
  1229. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1230. const inputView =
  1231. '<container:ul>' +
  1232. '<container:li>Foo</container:li>' +
  1233. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1234. '</container:ul>';
  1235. const view = parse( inputView );
  1236. viewRoot._appendChild( view );
  1237. renderer.markToSync( 'children', viewRoot );
  1238. renderer.render();
  1239. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1240. const viewLi = view.getChild( 0 );
  1241. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1242. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1243. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  1244. viewLi._appendChild( viewUl );
  1245. renderer.markToSync( 'children', view );
  1246. renderer.markToSync( 'children', viewLi );
  1247. renderer.render();
  1248. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1249. } );
  1250. // #1439
  1251. it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
  1252. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1253. testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
  1254. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1255. // <p>foo<br/>[]</p>
  1256. const { view: viewP, selection: newSelection } = parse(
  1257. '<container:p>' +
  1258. 'foo[]' +
  1259. '<empty:br></empty:br>[]' +
  1260. '</container:p>' );
  1261. viewRoot._appendChild( viewP );
  1262. selection._setTo( newSelection );
  1263. renderer.markToSync( 'children', viewRoot );
  1264. renderer.render();
  1265. sinon.assert.notCalled( spy );
  1266. } );
  1267. // #1439
  1268. it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
  1269. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1270. testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
  1271. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1272. // <p>foo[]<b>bar</b></p>
  1273. let { view: viewP, selection: newSelection } = parse(
  1274. '<container:p>' +
  1275. 'foo[]' +
  1276. '<attribute:b>bar</attribute:b>' +
  1277. '</container:p>' );
  1278. viewRoot._appendChild( viewP );
  1279. selection._setTo( newSelection );
  1280. renderer.markToSync( 'children', viewRoot );
  1281. renderer.render();
  1282. sinon.assert.notCalled( spy );
  1283. // <p>foo<b>bar</b></p><p>foo[]<br/></p>
  1284. ( { view: viewP, selection: newSelection } = parse(
  1285. '<container:p>' +
  1286. 'foo[]' +
  1287. '<empty:br></empty:br>' +
  1288. '</container:p>' ) );
  1289. viewRoot._appendChild( viewP );
  1290. selection._setTo( newSelection );
  1291. renderer.markToSync( 'children', viewRoot );
  1292. renderer.render();
  1293. sinon.assert.notCalled( spy );
  1294. // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
  1295. selection._setTo( [
  1296. new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
  1297. ] );
  1298. renderer.markToSync( 'children', viewRoot );
  1299. renderer.render();
  1300. sinon.assert.calledOnce( spy );
  1301. } );
  1302. describe( 'fake selection', () => {
  1303. beforeEach( () => {
  1304. const { view: viewP, selection: newSelection } = parse(
  1305. '<container:p>[foo bar]</container:p>'
  1306. );
  1307. viewRoot._appendChild( viewP );
  1308. selection._setTo( newSelection );
  1309. renderer.markToSync( 'children', viewRoot );
  1310. renderer.render();
  1311. } );
  1312. it( 'should render fake selection', () => {
  1313. const label = 'fake selection label';
  1314. selection._setTo( selection.getRanges(), { fake: true, label } );
  1315. renderer.render();
  1316. expect( domRoot.childNodes.length ).to.equal( 2 );
  1317. const container = domRoot.childNodes[ 1 ];
  1318. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1319. expect( container.childNodes.length ).to.equal( 1 );
  1320. const textNode = container.childNodes[ 0 ];
  1321. expect( textNode.textContent ).to.equal( label );
  1322. const domSelection = domRoot.ownerDocument.getSelection();
  1323. assertDomSelectionContents( domSelection, container, 'fake selection label' );
  1324. } );
  1325. describe( 'subsequent call optimization', () => {
  1326. // https://github.com/ckeditor/ckeditor5-engine/issues/1791
  1327. it( 'doesn\'t render the same selection multiple times', () => {
  1328. const createRangeSpy = sinon.spy( document, 'createRange' );
  1329. const label = 'subsequent fake selection calls';
  1330. selection._setTo( selection.getRanges(), { fake: true, label } );
  1331. renderer.render();
  1332. selection._setTo( selection.getRanges(), { fake: true, label } );
  1333. renderer.render();
  1334. expect( createRangeSpy.callCount ).to.be.equal( 1 );
  1335. } );
  1336. it( 'different subsequent fake selections sets do change native selection', () => {
  1337. const createRangeSpy = sinon.spy( document, 'createRange' );
  1338. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 1' } );
  1339. renderer.render();
  1340. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 2' } );
  1341. renderer.render();
  1342. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1343. } );
  1344. it( 'rerenders selection if disturbed externally', () => {
  1345. const interruptingRange = document.createRange();
  1346. interruptingRange.setStartBefore( domRoot.children[ 0 ] );
  1347. interruptingRange.setEndAfter( domRoot.children[ 0 ] );
  1348. const createRangeSpy = sinon.spy( document, 'createRange' );
  1349. const label = 'selection 1';
  1350. selection._setTo( selection.getRanges(), { fake: true, label } );
  1351. renderer.render();
  1352. document.getSelection().removeAllRanges();
  1353. document.getSelection().addRange( interruptingRange );
  1354. selection._setTo( selection.getRanges(), { fake: true, label } );
  1355. renderer.render();
  1356. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1357. } );
  1358. it( 'correctly maps fake selection ', () => {
  1359. // See https://github.com/ckeditor/ckeditor5-engine/pull/1792#issuecomment-529814641
  1360. const label = 'subsequent fake selection calls';
  1361. const { view: newParagraph, selection: newSelection } = parse( '<container:p>[baz]</container:p>' );
  1362. viewRoot._appendChild( newParagraph );
  1363. selection._setTo( selection.getRanges(), { fake: true, label } );
  1364. renderer.render();
  1365. selection._setTo( newSelection.getRanges(), { fake: true, label } );
  1366. renderer.render();
  1367. const fakeSelectionContainer = domRoot.childNodes[ 1 ];
  1368. const mappedSelection = renderer.domConverter.fakeSelectionToView( fakeSelectionContainer );
  1369. expect( stringify( viewRoot, mappedSelection ) ).to.be.equal( '<div><p>foo bar</p><p>[baz]</p></div>' );
  1370. } );
  1371. } );
  1372. it( 'should render &nbsp; if no selection label is provided', () => {
  1373. selection._setTo( selection.getRanges(), { fake: true } );
  1374. renderer.render();
  1375. expect( domRoot.childNodes.length ).to.equal( 2 );
  1376. const container = domRoot.childNodes[ 1 ];
  1377. expect( container.childNodes.length ).to.equal( 1 );
  1378. const textNode = container.childNodes[ 0 ];
  1379. expect( textNode.textContent ).to.equal( '\u00A0' );
  1380. const domSelection = domRoot.ownerDocument.getSelection();
  1381. assertDomSelectionContents( domSelection, container, '\u00A0' );
  1382. } );
  1383. it( 'should remove fake selection container when selection is no longer fake', () => {
  1384. selection._setTo( selection.getRanges(), { fake: true } );
  1385. renderer.render();
  1386. selection._setTo( selection.getRanges(), { fake: false } );
  1387. renderer.render();
  1388. expect( domRoot.childNodes.length ).to.equal( 1 );
  1389. const domParagraph = domRoot.childNodes[ 0 ];
  1390. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1391. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1392. const domSelection = domRoot.ownerDocument.getSelection();
  1393. assertDomSelectionContents( domSelection, domParagraph, 'foo bar' );
  1394. } );
  1395. it( 'should reuse fake selection container #1', () => {
  1396. const label = 'fake selection label';
  1397. selection._setTo( selection.getRanges(), { fake: true, label } );
  1398. renderer.render();
  1399. expect( domRoot.childNodes.length ).to.equal( 2 );
  1400. const container = domRoot.childNodes[ 1 ];
  1401. selection._setTo( selection.getRanges(), { fake: true, label } );
  1402. renderer.render();
  1403. expect( domRoot.childNodes.length ).to.equal( 2 );
  1404. const newContainer = domRoot.childNodes[ 1 ];
  1405. expect( newContainer ).equals( container );
  1406. expect( newContainer.childNodes.length ).to.equal( 1 );
  1407. const textNode = newContainer.childNodes[ 0 ];
  1408. expect( textNode.textContent ).to.equal( label );
  1409. } );
  1410. it( 'should reuse fake selection container #2', () => {
  1411. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1412. renderer.render();
  1413. expect( domRoot.childNodes.length ).to.equal( 2 );
  1414. const container = domRoot.childNodes[ 1 ];
  1415. selection._setTo( selection.getRanges(), { fake: false } );
  1416. renderer.render();
  1417. expect( domRoot.childNodes.length ).to.equal( 1 );
  1418. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1419. renderer.render();
  1420. expect( domRoot.childNodes.length ).to.equal( 2 );
  1421. const newContainer = domRoot.childNodes[ 1 ];
  1422. expect( newContainer ).equals( container );
  1423. expect( newContainer.childNodes.length ).to.equal( 1 );
  1424. const textNode = newContainer.childNodes[ 0 ];
  1425. expect( textNode.textContent ).to.equal( 'label 2' );
  1426. } );
  1427. it( 'should reuse fake selection container #3', () => {
  1428. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1429. renderer.render();
  1430. expect( domRoot.childNodes.length ).to.equal( 2 );
  1431. const container = domRoot.childNodes[ 1 ];
  1432. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1433. renderer.render();
  1434. expect( domRoot.childNodes.length ).to.equal( 2 );
  1435. const newContainer = domRoot.childNodes[ 1 ];
  1436. expect( newContainer ).equals( container );
  1437. expect( newContainer.childNodes.length ).to.equal( 1 );
  1438. const textNode = newContainer.childNodes[ 0 ];
  1439. expect( textNode.textContent ).to.equal( 'label 2' );
  1440. } );
  1441. it( 'should style fake selection container properly', () => {
  1442. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1443. renderer.render();
  1444. expect( domRoot.childNodes.length ).to.equal( 2 );
  1445. const container = domRoot.childNodes[ 1 ];
  1446. expect( container.style.position ).to.equal( 'fixed' );
  1447. expect( container.style.top ).to.equal( '0px' );
  1448. expect( container.style.left ).to.equal( '-9999px' );
  1449. } );
  1450. it( 'should move fake selection container between editables', () => {
  1451. const viewEditable = new ViewEditableElement( viewDocument, 'div' );
  1452. viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
  1453. const domEditable = document.createElement( 'div' );
  1454. document.body.appendChild( domEditable );
  1455. domConverter.bindElements( domEditable, viewEditable );
  1456. renderer.markToSync( 'children', viewEditable );
  1457. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1458. renderer.render();
  1459. let container = document.getSelection().anchorNode;
  1460. expect( domRoot.contains( container ) ).to.be.true;
  1461. selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
  1462. renderer.render();
  1463. container = document.getSelection().anchorNode;
  1464. expect( domEditable.contains( container ) ).to.be.true;
  1465. domEditable.remove();
  1466. } );
  1467. it( 'should bind fake selection container to view selection', () => {
  1468. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1469. renderer.render();
  1470. expect( domRoot.childNodes.length ).to.equal( 2 );
  1471. const container = domRoot.childNodes[ 1 ];
  1472. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1473. expect( bindSelection ).to.not.be.undefined;
  1474. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1475. } );
  1476. // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
  1477. it( 'should handle situation when label got removed from the fake selection container', () => {
  1478. const label = 'fake selection label';
  1479. selection._setTo( selection.getRanges(), { fake: true, label } );
  1480. renderer.render();
  1481. expect( domRoot.childNodes.length ).to.equal( 2 );
  1482. const container = domRoot.childNodes[ 1 ];
  1483. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1484. expect( container.childNodes.length ).to.equal( 1 );
  1485. const textNode = container.childNodes[ 0 ];
  1486. expect( textNode.textContent ).to.equal( label );
  1487. // Remove a text node (label) from the fake selection container.
  1488. // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
  1489. textNode.remove();
  1490. renderer.render();
  1491. const domSelection = domRoot.ownerDocument.getSelection();
  1492. assertDomSelectionContents( domSelection, container, 'fake selection label' );
  1493. } );
  1494. // Use a forgiving way of checking what the selection contains
  1495. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1496. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1497. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1498. expect( domSelection.toString() ).to.equal( expectedText );
  1499. expect(
  1500. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1501. ).to.be.true;
  1502. }
  1503. } );
  1504. // #887
  1505. describe( 'similar selection', () => {
  1506. // Use spies to check selection updates. Some selection positions are not achievable in some
  1507. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1508. let selectionCollapseSpy, selectionExtendSpy;
  1509. afterEach( () => {
  1510. if ( selectionCollapseSpy ) {
  1511. selectionCollapseSpy.restore();
  1512. selectionCollapseSpy = null;
  1513. }
  1514. if ( selectionExtendSpy ) {
  1515. selectionExtendSpy.restore();
  1516. selectionExtendSpy = null;
  1517. }
  1518. } );
  1519. it( 'should always render collapsed selection even if it is similar', () => {
  1520. const domSelection = document.getSelection();
  1521. const { view: viewP, selection: newSelection } = parse(
  1522. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1523. viewRoot._appendChild( viewP );
  1524. selection._setTo( newSelection );
  1525. renderer.markToSync( 'children', viewRoot );
  1526. renderer.render();
  1527. const domP = domRoot.childNodes[ 0 ];
  1528. const domB = domP.childNodes[ 1 ];
  1529. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1530. expect( domSelection.isCollapsed ).to.true;
  1531. expect( domSelection.rangeCount ).to.equal( 1 );
  1532. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1533. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1534. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1535. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1536. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1537. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1538. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1539. selection._setTo( [
  1540. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1541. ] );
  1542. renderer.markToSync( 'children', viewP );
  1543. renderer.render();
  1544. expect( selectionCollapseSpy.calledOnce ).to.true;
  1545. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1546. expect( selectionExtendSpy.calledOnce ).to.true;
  1547. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1548. } );
  1549. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1550. const domSelection = document.getSelection();
  1551. const { view: viewP, selection: newSelection } = parse(
  1552. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1553. viewRoot._appendChild( viewP );
  1554. selection._setTo( newSelection );
  1555. renderer.markToSync( 'children', viewRoot );
  1556. renderer.render();
  1557. const domP = domRoot.childNodes[ 0 ];
  1558. const domB = domP.childNodes[ 1 ];
  1559. expect( domSelection.isCollapsed ).to.true;
  1560. expect( domSelection.rangeCount ).to.equal( 1 );
  1561. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1562. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1563. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1564. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1565. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1566. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1567. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1568. selection._setTo( [
  1569. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1570. ] );
  1571. renderer.markToSync( 'children', viewP );
  1572. renderer.render();
  1573. expect( selectionCollapseSpy.calledOnce ).to.true;
  1574. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1575. expect( selectionExtendSpy.calledOnce ).to.true;
  1576. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1577. } );
  1578. it( 'should always render non-collapsed selection if it not is similar', () => {
  1579. const domSelection = document.getSelection();
  1580. const { view: viewP, selection: newSelection } = parse(
  1581. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1582. viewRoot._appendChild( viewP );
  1583. selection._setTo( newSelection );
  1584. renderer.markToSync( 'children', viewRoot );
  1585. renderer.render();
  1586. const domP = domRoot.childNodes[ 0 ];
  1587. const domB = domP.childNodes[ 1 ];
  1588. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1589. expect( domSelection.isCollapsed ).to.false;
  1590. expect( domSelection.rangeCount ).to.equal( 1 );
  1591. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1592. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1593. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1594. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1595. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1596. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1597. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1598. selection._setTo( [
  1599. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1600. ] );
  1601. renderer.markToSync( 'children', viewP );
  1602. renderer.render();
  1603. expect( selectionCollapseSpy.calledOnce ).to.true;
  1604. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1605. expect( selectionExtendSpy.calledOnce ).to.true;
  1606. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1607. } );
  1608. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1609. const domSelection = document.getSelection();
  1610. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1611. viewRoot._appendChild( viewP );
  1612. selection._setTo( newSelection );
  1613. renderer.markToSync( 'children', viewRoot );
  1614. renderer.render();
  1615. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1616. // Do not change view selection.
  1617. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1618. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1619. // because DOM selection is in incorrect place.
  1620. const domP = domRoot.childNodes[ 0 ];
  1621. const domSpan = domP.childNodes[ 1 ];
  1622. domSelection.collapse( domSpan, 0 );
  1623. renderer.render();
  1624. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1625. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1626. const assertSelectionAtEndOfTextNode = () => {
  1627. expect( domSelection.anchorNode ).to.equal( domP );
  1628. expect( domSelection.anchorOffset ).to.equal( 1 );
  1629. };
  1630. const assertSelectionInsideTextNode = () => {
  1631. const textNode = domP.childNodes[ 0 ];
  1632. expect( domSelection.anchorNode ).to.equal( textNode );
  1633. expect( domSelection.anchorOffset ).to.equal( 3 );
  1634. };
  1635. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1636. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1637. } );
  1638. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1639. const domSelection = document.getSelection();
  1640. const { view: viewP, selection: newSelection } = parse(
  1641. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1642. viewRoot._appendChild( viewP );
  1643. selection._setTo( newSelection );
  1644. renderer.markToSync( 'children', viewRoot );
  1645. renderer.render();
  1646. const domP = domRoot.childNodes[ 0 ];
  1647. const domB = domP.childNodes[ 1 ];
  1648. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1649. expect( domSelection.isCollapsed ).to.false;
  1650. expect( domSelection.rangeCount ).to.equal( 1 );
  1651. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1652. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1653. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1654. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1655. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1656. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1657. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1658. selection._setTo( [
  1659. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1660. ] );
  1661. renderer.markToSync( 'children', viewP );
  1662. renderer.render();
  1663. expect( selectionCollapseSpy.notCalled ).to.true;
  1664. expect( selectionExtendSpy.notCalled ).to.true;
  1665. } );
  1666. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1667. const domSelection = document.getSelection();
  1668. const { view: viewP, selection: newSelection } = parse(
  1669. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1670. viewRoot._appendChild( viewP );
  1671. selection._setTo( newSelection );
  1672. renderer.markToSync( 'children', viewRoot );
  1673. renderer.render();
  1674. const domP = domRoot.childNodes[ 0 ];
  1675. const domB = domP.childNodes[ 1 ];
  1676. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1677. expect( domSelection.isCollapsed ).to.false;
  1678. expect( domSelection.rangeCount ).to.equal( 1 );
  1679. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1680. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1681. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1682. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1683. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1684. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1685. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1686. selection._setTo( [
  1687. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1688. ] );
  1689. renderer.markToSync( 'children', viewP );
  1690. renderer.render();
  1691. expect( selectionCollapseSpy.notCalled ).to.true;
  1692. expect( selectionExtendSpy.notCalled ).to.true;
  1693. } );
  1694. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1695. const domSelection = document.getSelection();
  1696. const { view: viewP, selection: newSelection } = parse(
  1697. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1698. viewRoot._appendChild( viewP );
  1699. selection._setTo( newSelection );
  1700. renderer.markToSync( 'children', viewRoot );
  1701. renderer.render();
  1702. const domP = domRoot.childNodes[ 0 ];
  1703. const domB = domP.childNodes[ 1 ];
  1704. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1705. expect( domSelection.isCollapsed ).to.false;
  1706. expect( domSelection.rangeCount ).to.equal( 1 );
  1707. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1708. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1709. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1710. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1711. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1712. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1713. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1714. selection._setTo( [
  1715. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1716. ] );
  1717. renderer.markToSync( 'children', viewP );
  1718. renderer.render();
  1719. expect( selectionCollapseSpy.notCalled ).to.true;
  1720. expect( selectionExtendSpy.notCalled ).to.true;
  1721. } );
  1722. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1723. const domSelection = document.getSelection();
  1724. const { view: viewP, selection: newSelection } = parse(
  1725. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1726. viewRoot._appendChild( viewP );
  1727. selection._setTo( newSelection );
  1728. renderer.markToSync( 'children', viewRoot );
  1729. renderer.render();
  1730. const domP = domRoot.childNodes[ 0 ];
  1731. const domB = domP.childNodes[ 1 ];
  1732. expect( domSelection.isCollapsed ).to.false;
  1733. expect( domSelection.rangeCount ).to.equal( 1 );
  1734. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1735. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1736. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1737. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1738. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1739. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1740. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1741. selection._setTo( [
  1742. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1743. ] );
  1744. renderer.markToSync( 'children', viewP );
  1745. renderer.render();
  1746. expect( selectionCollapseSpy.notCalled ).to.true;
  1747. expect( selectionExtendSpy.notCalled ).to.true;
  1748. } );
  1749. } );
  1750. // #1417
  1751. describe( 'optimal rendering – reusing existing nodes', () => {
  1752. it( 'should render inline element replacement (before text)', () => {
  1753. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1754. renderer.markToSync( 'children', viewRoot );
  1755. renderer.render();
  1756. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1757. const viewP = viewRoot.getChild( 0 );
  1758. viewP._removeChildren( 0, 2 );
  1759. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1760. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1761. renderer.markToSync( 'children', viewRoot );
  1762. renderer.markToSync( 'children', viewP );
  1763. renderer.render();
  1764. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1765. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1766. } );
  1767. it( 'should render inline element replacement (after text)', () => {
  1768. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1769. renderer.markToSync( 'children', viewRoot );
  1770. renderer.render();
  1771. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1772. const viewP = viewRoot.getChild( 0 );
  1773. viewP._removeChildren( 0, 2 );
  1774. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1775. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1776. renderer.markToSync( 'children', viewRoot );
  1777. renderer.markToSync( 'children', viewP );
  1778. renderer.render();
  1779. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1780. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1781. } );
  1782. it( 'should render inline element replacement (before text swapped order)', () => {
  1783. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1784. renderer.markToSync( 'children', viewRoot );
  1785. renderer.render();
  1786. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1787. const viewP = viewRoot.getChild( 0 );
  1788. viewP._removeChildren( 0, 2 );
  1789. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1790. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1791. renderer.markToSync( 'children', viewRoot );
  1792. renderer.markToSync( 'children', viewP );
  1793. renderer.render();
  1794. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1795. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1796. } );
  1797. it( 'should render inline element replacement (after text swapped order)', () => {
  1798. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1799. renderer.markToSync( 'children', viewRoot );
  1800. renderer.render();
  1801. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1802. const viewP = viewRoot.getChild( 0 );
  1803. viewP._removeChildren( 0, 2 );
  1804. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1805. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1806. renderer.markToSync( 'children', viewRoot );
  1807. renderer.markToSync( 'children', viewP );
  1808. renderer.render();
  1809. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1810. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1811. } );
  1812. it( 'should render single replacement in p group', () => {
  1813. const content = '' +
  1814. '<container:p>1</container:p>' +
  1815. '<container:p>2</container:p>' +
  1816. '<container:p>3</container:p>';
  1817. viewRoot._appendChild( parse( content ) );
  1818. renderer.markToSync( 'children', viewRoot );
  1819. renderer.render();
  1820. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1821. viewRoot._removeChildren( 1 );
  1822. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1823. const domP = domRoot.childNodes[ 1 ];
  1824. renderer.markToSync( 'children', viewRoot );
  1825. renderer.render();
  1826. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1827. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1828. } );
  1829. it( 'should render replacement and insertion in p group', () => {
  1830. const content = '' +
  1831. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1832. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1833. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1834. const replacement = '' +
  1835. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1836. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1837. viewRoot._appendChild( parse( content ) );
  1838. renderer.markToSync( 'children', viewRoot );
  1839. renderer.render();
  1840. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1841. viewRoot._removeChildren( 1 );
  1842. viewRoot._insertChild( 1, parse( replacement ) );
  1843. const domP2 = domRoot.childNodes[ 1 ];
  1844. const domP3 = domRoot.childNodes[ 2 ];
  1845. renderer.markToSync( 'children', viewRoot );
  1846. renderer.render();
  1847. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1848. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1849. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1850. } );
  1851. it( 'should render replacement and deletion in p group', () => {
  1852. const content = '' +
  1853. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1854. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1855. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1856. viewRoot._appendChild( parse( content ) );
  1857. renderer.markToSync( 'children', viewRoot );
  1858. renderer.render();
  1859. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1860. viewRoot._removeChildren( 0, 2 );
  1861. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1862. const domP0 = domRoot.childNodes[ 0 ];
  1863. const domP2 = domRoot.childNodes[ 2 ];
  1864. renderer.markToSync( 'children', viewRoot );
  1865. renderer.render();
  1866. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1867. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1868. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1869. } );
  1870. it( 'should render multiple continuous replacement in p group', () => {
  1871. const content = '' +
  1872. '<container:p>1</container:p>' +
  1873. '<container:p>2</container:p>' +
  1874. '<container:p>3</container:p>' +
  1875. '<container:p>4</container:p>' +
  1876. '<container:p>5</container:p>';
  1877. viewRoot._appendChild( parse( content ) );
  1878. renderer.markToSync( 'children', viewRoot );
  1879. renderer.render();
  1880. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1881. viewRoot._removeChildren( 0, 3 );
  1882. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1883. const domP1 = domRoot.childNodes[ 0 ];
  1884. const domP2 = domRoot.childNodes[ 1 ];
  1885. const domP4 = domRoot.childNodes[ 3 ];
  1886. const domP5 = domRoot.childNodes[ 4 ];
  1887. renderer.markToSync( 'children', viewRoot );
  1888. renderer.render();
  1889. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1890. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1891. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1892. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1893. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1894. } );
  1895. it( 'should render multiple replacement in p group', () => {
  1896. const content = '' +
  1897. '<container:p>1</container:p>' +
  1898. '<container:p>2</container:p>' +
  1899. '<container:p>3</container:p>' +
  1900. '<container:p>4</container:p>' +
  1901. '<container:p>5</container:p>';
  1902. viewRoot._appendChild( parse( content ) );
  1903. renderer.markToSync( 'children', viewRoot );
  1904. renderer.render();
  1905. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1906. viewRoot._removeChildren( 4 );
  1907. viewRoot._removeChildren( 1, 2 );
  1908. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1909. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1910. const domP1 = domRoot.childNodes[ 0 ];
  1911. const domP2 = domRoot.childNodes[ 1 ];
  1912. const domP4 = domRoot.childNodes[ 3 ];
  1913. const domP5 = domRoot.childNodes[ 4 ];
  1914. renderer.markToSync( 'children', viewRoot );
  1915. renderer.render();
  1916. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1917. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1918. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1919. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1920. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1921. } );
  1922. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1923. const content = '' +
  1924. '<container:h2>He' +
  1925. '<attribute:i>ading 1</attribute:i>' +
  1926. '</container:h2>' +
  1927. '<container:p>Ph ' +
  1928. '<attribute:strong>Bold</attribute:strong>' +
  1929. '<attribute:a href="https://ckeditor.com">' +
  1930. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1931. '</attribute:a>' +
  1932. '</container:p>' +
  1933. '<container:blockquote>' +
  1934. '<container:ul>' +
  1935. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1936. '</container:ul>' +
  1937. '</container:blockquote>';
  1938. viewRoot._appendChild( parse( content ) );
  1939. renderer.markToSync( 'children', viewRoot );
  1940. renderer.render();
  1941. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1942. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1943. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1944. viewRoot._removeChildren( 0, viewRoot.childCount );
  1945. viewRoot._appendChild( parse( content ) );
  1946. const viewH = viewRoot.getChild( 0 );
  1947. const viewP = viewRoot.getChild( 1 );
  1948. const viewQ = viewRoot.getChild( 2 );
  1949. const domH = domRoot.childNodes[ 0 ];
  1950. const domHI = domH.childNodes[ 1 ];
  1951. const domP = domRoot.childNodes[ 1 ];
  1952. const domPT = domP.childNodes[ 0 ];
  1953. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1954. const domQ = domRoot.childNodes[ 2 ];
  1955. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1956. renderer.markToSync( 'children', viewRoot );
  1957. renderer.render();
  1958. // Assert content.
  1959. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1960. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1961. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1962. // Assert if DOM elements did not change.
  1963. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1964. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1965. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1966. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1967. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1968. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1969. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1970. // Assert mappings.
  1971. const mappings = renderer.domConverter._domToViewMapping;
  1972. expect( mappings.get( domH ) ).to.equal( viewH );
  1973. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1974. expect( mappings.get( domP ) ).to.equal( viewP );
  1975. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1976. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1977. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1978. } );
  1979. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1980. const content = '' +
  1981. '<container:h2>He' +
  1982. '<attribute:i>ading 1</attribute:i>' +
  1983. '</container:h2>' +
  1984. '<container:p>Ph ' +
  1985. '<attribute:strong>Bold</attribute:strong>' +
  1986. '<attribute:a href="https://ckeditor.com">' +
  1987. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1988. '</attribute:a>' +
  1989. '</container:p>' +
  1990. '<container:blockquote>' +
  1991. '<container:ul>' +
  1992. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1993. '</container:ul>' +
  1994. '</container:blockquote>';
  1995. const content2 = '' +
  1996. '<container:p>Ph ' +
  1997. '<attribute:strong>Bold</attribute:strong>' +
  1998. '<attribute:a href="https://ckeditor.com">' +
  1999. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2000. '</attribute:a>' +
  2001. '</container:p>' +
  2002. '<container:blockquote>' +
  2003. '<container:ul>' +
  2004. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2005. '</container:ul>' +
  2006. '</container:blockquote>';
  2007. viewRoot._appendChild( parse( content ) );
  2008. renderer.markToSync( 'children', viewRoot );
  2009. renderer.render();
  2010. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  2011. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2012. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2013. viewRoot._removeChildren( 0, viewRoot.childCount );
  2014. viewRoot._appendChild( parse( content2 ) );
  2015. const viewP = viewRoot.getChild( 0 );
  2016. const viewQ = viewRoot.getChild( 1 );
  2017. const domP = domRoot.childNodes[ 1 ];
  2018. const domPT = domP.childNodes[ 0 ];
  2019. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  2020. const domQ = domRoot.childNodes[ 2 ];
  2021. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  2022. renderer.markToSync( 'children', viewRoot );
  2023. renderer.render();
  2024. // Assert content.
  2025. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  2026. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2027. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2028. // Assert if DOM elements did not change.
  2029. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2030. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  2031. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  2032. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  2033. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  2034. // Assert mappings.
  2035. const mappings = renderer.domConverter._domToViewMapping;
  2036. expect( mappings.get( domP ) ).to.equal( viewP );
  2037. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  2038. expect( mappings.get( domQ ) ).to.equal( viewQ );
  2039. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2040. } );
  2041. it( 'should not rerender DOM when typing inside empty inline element', () => {
  2042. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  2043. viewRoot._appendChild( view );
  2044. renderer.markToSync( 'children', viewRoot );
  2045. renderer.render();
  2046. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  2047. const viewP = viewRoot.getChild( 0 );
  2048. viewP._removeChildren( 1 );
  2049. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  2050. const domP = domRoot.childNodes[ 0 ];
  2051. const domText = domP.childNodes[ 0 ];
  2052. const domB = domP.childNodes[ 1 ];
  2053. domB.innerHTML = 'a';
  2054. renderer.markToSync( 'children', viewRoot );
  2055. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  2056. renderer.render();
  2057. // Assert content.
  2058. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  2059. // Assert if DOM elements did not change.
  2060. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2061. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  2062. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  2063. // Assert mappings.
  2064. const mappings = renderer.domConverter._domToViewMapping;
  2065. expect( mappings.get( domP ) ).to.equal( viewP );
  2066. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  2067. } );
  2068. it( 'should handle complex view duplication', () => {
  2069. const content = '' +
  2070. '<container:blockquote>' +
  2071. '<container:ul>' +
  2072. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2073. '<container:li>Item 2</container:li>' +
  2074. '<container:li>' +
  2075. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2076. '</container:li>' +
  2077. '</container:ul>' +
  2078. '</container:blockquote>';
  2079. const expected = '' +
  2080. '<blockquote>' +
  2081. '<ul>' +
  2082. '<li>Quoted <strong>item 1</strong></li>' +
  2083. '<li>Item 2</li>' +
  2084. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2085. '</ul>' +
  2086. '</blockquote>';
  2087. viewRoot._appendChild( parse( content ) );
  2088. renderer.markToSync( 'children', viewRoot );
  2089. renderer.render();
  2090. expect( domRoot.innerHTML ).to.equal( expected );
  2091. viewRoot._removeChildren( 0, viewRoot.childCount );
  2092. viewRoot._appendChild( parse( content + content ) );
  2093. const domBQ = domRoot.childNodes[ 0 ];
  2094. const domUL = domBQ.childNodes[ 0 ];
  2095. const domLI1 = domUL.childNodes[ 0 ];
  2096. const domLI2 = domUL.childNodes[ 1 ];
  2097. const domLI3 = domUL.childNodes[ 2 ];
  2098. renderer.markToSync( 'children', viewRoot );
  2099. renderer.render();
  2100. // Assert content.
  2101. expect( domRoot.innerHTML ).to.equal( expected + expected );
  2102. // Assert if DOM elements did not change.
  2103. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  2104. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  2105. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  2106. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  2107. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  2108. // Assert mappings.
  2109. const domMappings = renderer.domConverter._domToViewMapping;
  2110. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  2111. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  2112. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  2113. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2114. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  2115. // Assert if new view elements are bind to new DOM elements.
  2116. const viewMappings = renderer.domConverter._domToViewMapping;
  2117. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  2118. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  2119. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  2120. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  2121. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  2122. } );
  2123. it( 'should handle complex view replace', () => {
  2124. const content = '' +
  2125. '<container:h2>He' +
  2126. '<attribute:i>ading 1</attribute:i>' +
  2127. '</container:h2>' +
  2128. '<container:p>Ph ' +
  2129. '<attribute:strong>Bold</attribute:strong>' +
  2130. '<attribute:a href="https://ckeditor.com">' +
  2131. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2132. '</attribute:a>' +
  2133. '</container:p>' +
  2134. '<container:blockquote>' +
  2135. '<container:ul>' +
  2136. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2137. '<container:li>Item 2</container:li>' +
  2138. '<container:li>' +
  2139. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2140. '</container:li>' +
  2141. '</container:ul>' +
  2142. '</container:blockquote>';
  2143. const replacement = '' +
  2144. '<container:p>' +
  2145. '1' +
  2146. '<attribute:i>A</attribute:i>' +
  2147. '</container:p>' +
  2148. '<container:p>' +
  2149. '<attribute:a href="https://cksource.com">' +
  2150. 'Li' +
  2151. '<attribute:strong>nk</attribute:strong>' +
  2152. '</attribute:a>' +
  2153. '</container:p>' +
  2154. '<container:h1>' +
  2155. 'Heading ' +
  2156. '<attribute:strong>1</attribute:strong>' +
  2157. '</container:h1>' +
  2158. '<container:h2>' +
  2159. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2160. '</container:h2>' +
  2161. '<container:h3>' +
  2162. 'Heading' +
  2163. '<attribute:i> 3</attribute:i>' +
  2164. '</container:h3>' +
  2165. '<container:blockquote>' +
  2166. 'Foo Bar Baz' +
  2167. '</container:blockquote>' +
  2168. '<container:ul>' +
  2169. '<container:li>' +
  2170. 'Item ' +
  2171. '<attribute:strong>1</attribute:strong>' +
  2172. '</container:li>' +
  2173. '<container:li>' +
  2174. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2175. ' 2' +
  2176. '</container:li>' +
  2177. '</container:ul>';
  2178. viewRoot._appendChild( parse( content ) );
  2179. renderer.markToSync( 'children', viewRoot );
  2180. renderer.render();
  2181. expect( domRoot.innerHTML ).to.equal( '' +
  2182. '<h2>He<i>ading 1</i></h2>' +
  2183. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2184. '<blockquote><ul>' +
  2185. '<li>Quoted <strong>item 1</strong></li>' +
  2186. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2187. '</ul></blockquote>' );
  2188. viewRoot._removeChildren( 0, viewRoot.childCount );
  2189. viewRoot._appendChild( parse( replacement ) );
  2190. renderer.markToSync( 'children', viewRoot );
  2191. renderer.render();
  2192. // Here we just check if new DOM structure was properly rendered.
  2193. expect( domRoot.innerHTML ).to.equal( '' +
  2194. '<p>1<i>A</i></p>' +
  2195. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2196. '<h1>Heading <strong>1</strong></h1>' +
  2197. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2198. '<h3>Heading<i> 3</i></h3>' +
  2199. '<blockquote>Foo Bar Baz</blockquote>' +
  2200. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2201. } );
  2202. it( 'should handle br elements while refreshing bindings', () => {
  2203. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2204. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2205. renderer.markToSync( 'children', viewRoot );
  2206. renderer.render();
  2207. expect( domRoot.innerHTML ).to.equal( expected );
  2208. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2209. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2210. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2211. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2212. viewRoot._removeChildren( 1 );
  2213. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2214. renderer.markToSync( 'children', viewRoot );
  2215. renderer.render();
  2216. expect( domRoot.innerHTML ).to.equal( expected );
  2217. } );
  2218. it( 'should handle list to paragraph conversion', () => {
  2219. const view = '' +
  2220. '<container:ol>' +
  2221. '<container:li>Item 1' +
  2222. '<container:ol>' +
  2223. '<container:li>Item 2</container:li>' +
  2224. '</container:ol>' +
  2225. '</container:li>' +
  2226. '</container:ol>' +
  2227. '<container:p>Paragraph</container:p>' +
  2228. '<container:ol>' +
  2229. '<container:li>Item 3' +
  2230. '<container:ol>' +
  2231. '<container:li>Item 4</container:li>' +
  2232. '</container:ol>' +
  2233. '</container:li>' +
  2234. '</container:ol>';
  2235. viewRoot._appendChild( parse( view ) );
  2236. renderer.markToSync( 'children', viewRoot );
  2237. renderer.render();
  2238. expect( domRoot.innerHTML ).to.equal(
  2239. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2240. const viewOL1 = viewRoot.getChild( 0 );
  2241. viewOL1.getChild( 0 )._removeChildren( 1 );
  2242. viewRoot._removeChildren( 2 );
  2243. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2244. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2245. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2246. const domOL1 = domRoot.childNodes[ 0 ];
  2247. const domOL2 = domRoot.childNodes[ 2 ];
  2248. const domP = domRoot.childNodes[ 1 ];
  2249. renderer.markToSync( 'children', viewRoot );
  2250. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2251. renderer.render();
  2252. expect( domRoot.innerHTML ).to.equal(
  2253. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2254. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2255. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2256. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2257. } );
  2258. it( 'should handle attributes change in replaced elements', () => {
  2259. const view = '' +
  2260. '<container:ol>' +
  2261. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2262. '</container:ol>' +
  2263. '<container:p>Paragraph ' +
  2264. '<attribute:a href="123">Link</attribute:a>' +
  2265. '</container:p>' +
  2266. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2267. viewRoot._appendChild( parse( view ) );
  2268. renderer.markToSync( 'children', viewRoot );
  2269. renderer.render();
  2270. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2271. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2272. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2273. const viewOL = viewRoot.getChild( 0 );
  2274. viewOL._removeChildren( 0 );
  2275. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2276. const viewP1 = viewRoot.getChild( 1 );
  2277. viewP1._removeChildren( 1 );
  2278. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2279. viewRoot._removeChildren( 2 );
  2280. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2281. renderer.markToSync( 'children', viewRoot );
  2282. renderer.markToSync( 'children', viewOL );
  2283. renderer.markToSync( 'children', viewP1 );
  2284. renderer.render();
  2285. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2286. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2287. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2288. } );
  2289. it( 'should handle classes change in replaced elements', () => {
  2290. const view = '' +
  2291. '<container:ol>' +
  2292. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2293. '</container:ol>' +
  2294. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2295. viewRoot._appendChild( parse( view ) );
  2296. renderer.markToSync( 'children', viewRoot );
  2297. renderer.render();
  2298. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2299. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2300. const viewOL = viewRoot.getChild( 0 );
  2301. const oldViewLI = viewOL.getChild( 0 );
  2302. viewOL._removeChildren( 0 );
  2303. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2304. const oldViewP = viewRoot.getChild( 1 );
  2305. viewRoot._removeChildren( 1 );
  2306. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2307. renderer.markToSync( 'attributes', oldViewLI );
  2308. renderer.markToSync( 'attributes', oldViewP );
  2309. renderer.markToSync( 'children', viewRoot );
  2310. renderer.markToSync( 'children', viewOL );
  2311. renderer.render();
  2312. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2313. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2314. } );
  2315. it( 'should handle styles change in replaced elements', () => {
  2316. const view = '' +
  2317. '<container:ol>' +
  2318. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2319. '<container:li>Bar ' +
  2320. '<attribute:i>' +
  2321. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2322. ' Bax</attribute:i>' +
  2323. '</container:li>' +
  2324. '</container:ol>';
  2325. viewRoot._appendChild( parse( view ) );
  2326. renderer.markToSync( 'children', viewRoot );
  2327. renderer.render();
  2328. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2329. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2330. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2331. const viewOL = viewRoot.getChild( 0 );
  2332. const viewLI1 = viewOL.getChild( 0 );
  2333. const viewLI2 = viewOL.getChild( 1 );
  2334. viewLI1._removeStyle( 'font-weight' );
  2335. viewLI1._setStyle( { color: '#FFF' } );
  2336. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2337. viewLI2._removeChildren( 0, viewLI2.childCount );
  2338. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2339. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2340. renderer.markToSync( 'attributes', viewLI1 );
  2341. renderer.markToSync( 'attributes', viewLI2 );
  2342. renderer.markToSync( 'children', viewRoot );
  2343. renderer.markToSync( 'children', viewLI2 );
  2344. renderer.render();
  2345. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2346. '<ol><li style="color:#FFF;">Foo</li>' +
  2347. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2348. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2349. } );
  2350. it( 'should handle uiElement rendering', () => {
  2351. function createUIElement( id, text ) {
  2352. const element = new UIElement( viewDocument, 'span' );
  2353. element.render = function( domDocument ) {
  2354. const domElement = this.toDomElement( domDocument );
  2355. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2356. return domElement;
  2357. };
  2358. return element;
  2359. }
  2360. const ui1 = createUIElement( 'id1', 'UI1' );
  2361. const ui2 = createUIElement( 'id2', 'UI2' );
  2362. const viewP = new ViewContainerElement( viewDocument, 'p', null, [
  2363. new ViewText( viewDocument, 'Foo ' ),
  2364. ui1,
  2365. new ViewText( viewDocument, 'Bar' )
  2366. ] );
  2367. viewRoot._appendChild( viewP );
  2368. renderer.markToSync( 'children', viewRoot );
  2369. renderer.render();
  2370. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2371. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2372. viewP._removeChildren( 0, viewP.childCount );
  2373. viewP._insertChild( 0, [ new ViewText( viewDocument, 'Foo' ), ui2, new ViewText( viewDocument, ' Bar' ) ] );
  2374. renderer.markToSync( 'children', viewRoot );
  2375. renderer.markToSync( 'children', viewP );
  2376. renderer.render();
  2377. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2378. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2379. } );
  2380. it( 'should handle linking entire content', () => {
  2381. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2382. renderer.markToSync( 'children', viewRoot );
  2383. renderer.render();
  2384. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2385. const viewP = viewRoot.getChild( 0 );
  2386. // While linking, the existing DOM children are moved to a new `a` element during binding
  2387. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2388. // where view elements were moved to a newly created link view element.
  2389. const viewA = new ViewAttributeElement( viewDocument, 'a', { href: '#href' }, [
  2390. new ViewText( viewDocument, 'Foo' ),
  2391. viewP.getChild( 1 )
  2392. ] );
  2393. viewP._removeChildren( 0, viewP.childCount );
  2394. viewP._insertChild( 0, viewA );
  2395. renderer.markToSync( 'children', viewRoot );
  2396. renderer.markToSync( 'children', viewP );
  2397. renderer.render();
  2398. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2399. } );
  2400. // https://github.com/ckeditor/ckeditor5/issues/6367.
  2401. it( 'should correctly handle moving a DOM element when rendering children', () => {
  2402. viewRoot._insertChild( 0, parse( 'y<attribute:span>x</attribute:span>' ) );
  2403. renderer.markToSync( 'children', viewRoot );
  2404. renderer.render();
  2405. const viewSpan = viewRoot._removeChildren( 1, 1 )[ 0 ];
  2406. viewRoot._insertChild( 0, viewSpan );
  2407. viewRoot._insertChild( 2, parse( '<attribute:strong>z</attribute:strong>' ) );
  2408. renderer.markToSync( 'children', viewRoot );
  2409. // This would throw without a fix.
  2410. renderer.render();
  2411. expect( domRoot.innerHTML ).to.equal( '<span>x</span>y<strong>z</strong>' );
  2412. } );
  2413. // https://github.com/ckeditor/ckeditor5/issues/6367, but more complex
  2414. it( 'should correctly handle moving a DOM element when rendering children (more complex case)', () => {
  2415. viewRoot._insertChild( 0,
  2416. parse( '1<attribute:span>2</attribute:span><attribute:span>3</attribute:span>4<attribute:span>5</attribute:span>' )
  2417. );
  2418. renderer.markToSync( 'children', viewRoot );
  2419. renderer.render();
  2420. const viewSpan5 = viewRoot._removeChildren( 4, 1 )[ 0 ];
  2421. const viewSpan2 = viewRoot._removeChildren( 1, 1 )[ 0 ];
  2422. viewRoot._insertChild( 0, viewSpan2 );
  2423. viewRoot._insertChild( 1, parse( '<attribute:strong>6</attribute:strong>' ) );
  2424. viewRoot._insertChild( 4, parse( '<attribute:strong>7</attribute:strong>' ) );
  2425. viewRoot._insertChild( 2, viewSpan5 );
  2426. renderer.markToSync( 'children', viewRoot );
  2427. // This would throw without a fix.
  2428. renderer.render();
  2429. expect( domRoot.innerHTML ).to.equal( '<span>2</span><strong>6</strong><span>5</span>1<span>3</span><strong>7</strong>4' );
  2430. } );
  2431. } );
  2432. describe( 'optimal (minimal) rendering – minimal children changes', () => {
  2433. let observer;
  2434. beforeEach( () => {
  2435. observer = new MutationObserver( () => {} );
  2436. observer.observe( domRoot, {
  2437. childList: true,
  2438. attributes: false,
  2439. subtree: false
  2440. } );
  2441. } );
  2442. afterEach( () => {
  2443. observer.disconnect();
  2444. } );
  2445. it( 'should add only one child (at the beginning)', () => {
  2446. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2447. renderer.markToSync( 'children', viewRoot );
  2448. renderer.render();
  2449. cleanObserver( observer );
  2450. viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
  2451. renderer.markToSync( 'children', viewRoot );
  2452. renderer.render();
  2453. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2454. 'added: 1, removed: 0'
  2455. ] );
  2456. } );
  2457. it( 'should add only one child (at the end)', () => {
  2458. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2459. renderer.markToSync( 'children', viewRoot );
  2460. renderer.render();
  2461. cleanObserver( observer );
  2462. viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
  2463. renderer.markToSync( 'children', viewRoot );
  2464. renderer.render();
  2465. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2466. 'added: 1, removed: 0'
  2467. ] );
  2468. } );
  2469. it( 'should add only one child (in the middle)', () => {
  2470. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2471. renderer.markToSync( 'children', viewRoot );
  2472. renderer.render();
  2473. cleanObserver( observer );
  2474. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2475. renderer.markToSync( 'children', viewRoot );
  2476. renderer.render();
  2477. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2478. 'added: 1, removed: 0'
  2479. ] );
  2480. } );
  2481. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2482. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2483. renderer.markToSync( 'children', viewRoot );
  2484. renderer.render();
  2485. cleanObserver( observer );
  2486. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2487. viewRoot._removeChildren( 0, 1 );
  2488. renderer.markToSync( 'children', viewRoot );
  2489. renderer.render();
  2490. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2491. } );
  2492. it( 'should remove and add one', () => {
  2493. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2494. renderer.markToSync( 'children', viewRoot );
  2495. renderer.render();
  2496. cleanObserver( observer );
  2497. viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
  2498. viewRoot._removeChildren( 0, 1 );
  2499. renderer.markToSync( 'children', viewRoot );
  2500. renderer.render();
  2501. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2502. 'added: 0, removed: 1',
  2503. 'added: 1, removed: 0'
  2504. ] );
  2505. } );
  2506. it( 'should not touch the FSC when rendering children', () => {
  2507. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2508. // Set fake selection on the second paragraph.
  2509. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2510. renderer.markToSync( 'children', viewRoot );
  2511. renderer.render();
  2512. cleanObserver( observer );
  2513. // Remove the second paragraph.
  2514. viewRoot._removeChildren( 1, 1 );
  2515. // And set the fake selection on the first one.
  2516. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2517. renderer.markToSync( 'children', viewRoot );
  2518. renderer.render();
  2519. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2520. 'added: 0, removed: 1'
  2521. ] );
  2522. } );
  2523. it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
  2524. // This test's purpose is mostly reaching 100% CC.
  2525. observer = new MutationObserver( () => {} );
  2526. viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
  2527. const viewDiv = viewRoot.getChild( 0 );
  2528. // Set fake selection on the second paragraph.
  2529. selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
  2530. renderer.markToSync( 'children', viewDiv );
  2531. renderer.markToSync( 'children', viewRoot );
  2532. renderer.render();
  2533. observer.observe( domRoot.childNodes[ 0 ], {
  2534. childList: true,
  2535. attributes: false,
  2536. subtree: false
  2537. } );
  2538. // Remove the second paragraph.
  2539. viewDiv._removeChildren( 1, 1 );
  2540. // And set the fake selection on the first one.
  2541. selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
  2542. renderer.markToSync( 'children', viewDiv );
  2543. renderer.markToSync( 'children', viewRoot );
  2544. renderer.render();
  2545. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2546. 'added: 0, removed: 1'
  2547. ] );
  2548. observer.disconnect();
  2549. } );
  2550. describe( 'using fastDiff() - significant number of nodes in the editor', () => {
  2551. it( 'should add only one child (at the beginning)', () => {
  2552. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2553. renderer.markToSync( 'children', viewRoot );
  2554. renderer.render();
  2555. cleanObserver( observer );
  2556. viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
  2557. renderer.markToSync( 'children', viewRoot );
  2558. renderer.render();
  2559. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2560. 'added: 1, removed: 0'
  2561. ] );
  2562. } );
  2563. it( 'should add only one child (at the end)', () => {
  2564. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2565. renderer.markToSync( 'children', viewRoot );
  2566. renderer.render();
  2567. cleanObserver( observer );
  2568. viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
  2569. renderer.markToSync( 'children', viewRoot );
  2570. renderer.render();
  2571. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2572. 'added: 1, removed: 0'
  2573. ] );
  2574. } );
  2575. it( 'should add only one child (in the middle)', () => {
  2576. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2577. renderer.markToSync( 'children', viewRoot );
  2578. renderer.render();
  2579. cleanObserver( observer );
  2580. viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
  2581. renderer.markToSync( 'children', viewRoot );
  2582. renderer.render();
  2583. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2584. 'added: 1, removed: 0'
  2585. ] );
  2586. } );
  2587. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2588. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2589. renderer.markToSync( 'children', viewRoot );
  2590. renderer.render();
  2591. cleanObserver( observer );
  2592. viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
  2593. viewRoot._removeChildren( 0, 1 );
  2594. renderer.markToSync( 'children', viewRoot );
  2595. renderer.render();
  2596. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2597. } );
  2598. it( 'should remove and add one', () => {
  2599. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2600. renderer.markToSync( 'children', viewRoot );
  2601. renderer.render();
  2602. cleanObserver( observer );
  2603. viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
  2604. viewRoot._removeChildren( 0, 1 );
  2605. renderer.markToSync( 'children', viewRoot );
  2606. renderer.render();
  2607. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2608. 'added: 0, removed: 1',
  2609. 'added: 1, removed: 0'
  2610. ] );
  2611. } );
  2612. it( 'should not touch the FSC when rendering children', () => {
  2613. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2614. // Set fake selection on the second paragraph.
  2615. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2616. renderer.markToSync( 'children', viewRoot );
  2617. renderer.render();
  2618. cleanObserver( observer );
  2619. // Remove the second paragraph.
  2620. viewRoot._removeChildren( 1, 1 );
  2621. // And set the fake selection on the first one.
  2622. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2623. renderer.markToSync( 'children', viewRoot );
  2624. renderer.render();
  2625. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2626. 'added: 0, removed: 1'
  2627. ] );
  2628. } );
  2629. } );
  2630. function getMutationStats( mutationList ) {
  2631. return mutationList.map( mutation => {
  2632. return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
  2633. } );
  2634. }
  2635. function cleanObserver( observer ) {
  2636. observer.takeRecords();
  2637. }
  2638. function makeContainers( howMany ) {
  2639. const containers = [];
  2640. for ( let i = 1; i <= howMany; i++ ) {
  2641. containers.push( `<container:p>${ i }</container:p>` );
  2642. }
  2643. return containers.join( '' );
  2644. }
  2645. } );
  2646. // #1560
  2647. describe( 'attributes manipulation on replaced element', () => {
  2648. it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
  2649. const writer = new DowncastWriter( viewDocument );
  2650. // 1. Setup initial view/DOM.
  2651. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2652. const viewP = viewRoot.getChild( 0 );
  2653. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2654. renderer.markToSync( 'children', viewRoot );
  2655. renderer.render();
  2656. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2657. // 2. Modify view.
  2658. writer.removeAttribute( 'data-placeholder', viewP );
  2659. viewRoot._removeChildren( 0, viewRoot.childCount );
  2660. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2661. renderer.markToSync( 'attributes', viewP );
  2662. renderer.markToSync( 'children', viewRoot );
  2663. renderer.render();
  2664. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2665. } );
  2666. it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
  2667. const writer = new DowncastWriter( viewDocument );
  2668. // 1. Setup initial view/DOM.
  2669. viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
  2670. const viewP = viewRoot.getChild( 1 );
  2671. writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
  2672. renderer.markToSync( 'children', viewRoot );
  2673. renderer.render();
  2674. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
  2675. // 2. Modify view.
  2676. writer.removeClass( 'cke-test2', viewP );
  2677. viewRoot._removeChildren( 0, viewRoot.childCount );
  2678. viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
  2679. '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
  2680. renderer.markToSync( 'attributes', viewP );
  2681. renderer.markToSync( 'children', viewRoot );
  2682. renderer.render();
  2683. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
  2684. } );
  2685. it( 'should rerender element if it was removed and have its attributes removed after', () => {
  2686. const writer = new DowncastWriter( viewDocument );
  2687. // 1. Setup initial view/DOM.
  2688. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2689. const viewP = viewRoot.getChild( 0 );
  2690. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2691. renderer.markToSync( 'children', viewRoot );
  2692. renderer.render();
  2693. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2694. // 2. Modify view.
  2695. viewRoot._removeChildren( 0, viewRoot.childCount );
  2696. writer.removeAttribute( 'data-placeholder', viewP );
  2697. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2698. renderer.markToSync( 'children', viewRoot );
  2699. renderer.render();
  2700. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2701. } );
  2702. } );
  2703. // ckeditor/ckeditor5-utils#269
  2704. // The expected times has a significant margin above the usual execution time (which is around 40-50%
  2705. // of the expected time) because it depends on the browser and environment in which tests are run.
  2706. // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
  2707. // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
  2708. describe( 'rendering performance', () => {
  2709. it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
  2710. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
  2711. expect( renderingTime ).to.be.within( 0, 350 );
  2712. } );
  2713. it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
  2714. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
  2715. expect( renderingTime ).to.be.within( 0, 350 );
  2716. } );
  2717. it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
  2718. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
  2719. expect( renderingTime ).to.be.within( 0, 350 );
  2720. } );
  2721. it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
  2722. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
  2723. expect( renderingTime ).to.be.within( 0, 350 );
  2724. } );
  2725. it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
  2726. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
  2727. expect( renderingTime ).to.be.within( 0, 350 );
  2728. } );
  2729. it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
  2730. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
  2731. expect( renderingTime ).to.be.within( 0, 350 );
  2732. } );
  2733. function measureRenderingTime( viewRoot, initialData, newData ) {
  2734. // Set initial data.
  2735. const initialView = parse( initialData );
  2736. viewRoot._appendChild( initialView );
  2737. renderer.markToSync( 'children', viewRoot );
  2738. renderer.render();
  2739. // Set new data.
  2740. const newView = parse( newData );
  2741. viewRoot._removeChildren( 0, viewRoot.childCount );
  2742. viewRoot._appendChild( newView );
  2743. renderer.markToSync( 'children', viewRoot );
  2744. // Measure render time.
  2745. const start = Date.now();
  2746. renderer.render();
  2747. return Date.now() - start;
  2748. }
  2749. function generateViewData1( repeat = 1 ) {
  2750. const viewData = '' +
  2751. '<container:h1>' +
  2752. 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
  2753. '</container:h1>' +
  2754. '<container:p>' +
  2755. 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
  2756. '</container:p>' +
  2757. '<container:ul>' +
  2758. '<container:li>Item 1</container:li>' +
  2759. '</container:ul>' +
  2760. '<container:ul>' +
  2761. '<container:li>Item 2</container:li>' +
  2762. '</container:ul>' +
  2763. '<container:ul>' +
  2764. '<container:li>Item 3</container:li>' +
  2765. '</container:ul>';
  2766. return viewData.repeat( repeat );
  2767. }
  2768. function generateViewData2( repeat = 1 ) {
  2769. const viewData = '' +
  2770. '<container:ol>' +
  2771. '<container:li>' +
  2772. '<attribute:strong>Foo</attribute:strong>' +
  2773. '</container:li>' +
  2774. '</container:ol>' +
  2775. '<container:ol>' +
  2776. '<container:li>Item 1</container:li>' +
  2777. '</container:ol>' +
  2778. '<container:h1>Heading 1</container:h1>' +
  2779. '<container:h2>' +
  2780. '<attribute:strong>Heading</attribute:strong> 2' +
  2781. '</container:h2>' +
  2782. '<container:h3>Heading 4</container:h3>';
  2783. return viewData.repeat( repeat );
  2784. }
  2785. } );
  2786. } );
  2787. describe( '#922', () => {
  2788. let view, viewDoc, viewRoot, domRoot, converter;
  2789. beforeEach( () => {
  2790. view = new View( new StylesProcessor() );
  2791. viewDoc = view.document;
  2792. domRoot = document.createElement( 'div' );
  2793. document.body.appendChild( domRoot );
  2794. viewRoot = createViewRoot( viewDoc );
  2795. view.attachDomRoot( domRoot );
  2796. converter = view.domConverter;
  2797. } );
  2798. afterEach( () => {
  2799. view.destroy();
  2800. domRoot.remove();
  2801. } );
  2802. it( 'should properly render unwrapped attributes #1', () => {
  2803. setViewData( view,
  2804. '<container:p>' +
  2805. '[<attribute:italic>' +
  2806. '<attribute:strong>f</attribute:strong>' +
  2807. '</attribute:italic>]' +
  2808. '<attribute:strong>oo</attribute:strong>' +
  2809. '</container:p>'
  2810. );
  2811. // Render it to DOM to create initial DOM <-> view mappings.
  2812. view.forceRender();
  2813. // Unwrap italic attribute element.
  2814. view.change( writer => {
  2815. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2816. } );
  2817. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2818. // Re-render changes in view to DOM.
  2819. view.forceRender();
  2820. // Check if DOM is rendered correctly.
  2821. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2822. expect( checkMappings() ).to.be.true;
  2823. } );
  2824. it( 'should properly render unwrapped attributes #2', () => {
  2825. setViewData( view,
  2826. '<container:p>' +
  2827. '[<attribute:italic>' +
  2828. '<attribute:strong>foo</attribute:strong>' +
  2829. '</attribute:italic>]' +
  2830. '</container:p>' );
  2831. // Render it to DOM to create initial DOM <-> view mappings.
  2832. view.forceRender();
  2833. // Unwrap italic attribute element and change text inside.
  2834. view.change( writer => {
  2835. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2836. } );
  2837. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2838. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2839. // Re-render changes in view to DOM.
  2840. view.forceRender();
  2841. // Check if DOM is rendered correctly.
  2842. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2843. expect( checkMappings() ).to.be.true;
  2844. } );
  2845. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2846. setViewData( view,
  2847. '<container:p>foo</container:p>'
  2848. );
  2849. // Render it to DOM to create initial DOM <-> view mappings.
  2850. view.forceRender();
  2851. // Change text and insert new element into paragraph.
  2852. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2853. textNode._data = 'foobar';
  2854. view.change( writer => {
  2855. writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2856. } );
  2857. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2858. // Re-render changes in view to DOM.
  2859. view.forceRender();
  2860. // Check if DOM is rendered correctly.
  2861. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2862. expect( checkMappings() ).to.be.true;
  2863. } );
  2864. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2865. setViewData( view,
  2866. '<container:p>foo</container:p>'
  2867. );
  2868. // Render it to DOM to create initial DOM <-> view mappings.
  2869. view.forceRender();
  2870. // Change text and insert new element into paragraph.
  2871. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2872. textNode._data = 'foobar';
  2873. view.change( writer => {
  2874. writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2875. } );
  2876. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2877. // Re-render changes in view to DOM.
  2878. view.forceRender();
  2879. // Check if DOM is rendered correctly.
  2880. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2881. expect( checkMappings() ).to.be.true;
  2882. } );
  2883. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2884. setViewData( view,
  2885. '<container:p>' +
  2886. '<attribute:b></attribute:b>' +
  2887. '<attribute:i></attribute:i>' +
  2888. '<attribute:span></attribute:span>' +
  2889. '</container:p>'
  2890. );
  2891. // Render it to DOM to create initial DOM <-> view mappings.
  2892. view.forceRender();
  2893. // Remove first element and reinsert it at the end.
  2894. const container = viewRoot.getChild( 0 );
  2895. const firstElement = container.getChild( 0 );
  2896. view.change( writer => {
  2897. writer.remove( ViewRange._createOn( firstElement ) );
  2898. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2899. } );
  2900. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2901. // Re-render changes in view to DOM.
  2902. view.forceRender();
  2903. // Check if DOM is rendered correctly.
  2904. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2905. expect( checkMappings() ).to.be.true;
  2906. } );
  2907. // Checks if every node in DOM tree is mapped to the view.
  2908. function checkMappings() {
  2909. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2910. while ( domWalker.nextNode() ) {
  2911. const node = domWalker.currentNode;
  2912. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2913. return false;
  2914. }
  2915. }
  2916. return true;
  2917. }
  2918. } );
  2919. describe( '_markDescendantTextToSync', () => {
  2920. let viewRoot;
  2921. beforeEach( () => {
  2922. viewRoot = new ViewElement( viewDocument, 'div' );
  2923. renderer.markedTexts.clear();
  2924. renderer.markedAttributes.clear();
  2925. renderer.markedChildren.clear();
  2926. } );
  2927. it( 'should handle null values', () => {
  2928. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2929. renderer._markDescendantTextToSync( null );
  2930. expect( renderer.markedChildren.size ).to.equal( 0 );
  2931. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2932. expect( renderer.markedTexts.size ).to.equal( 0 );
  2933. } );
  2934. it( 'should handle element nodes', () => {
  2935. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2936. viewRoot._appendChild( viewP );
  2937. renderer._markDescendantTextToSync( viewP );
  2938. expect( renderer.markedChildren.size ).to.equal( 0 );
  2939. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2940. expect( renderer.markedTexts.size ).to.equal( 3 );
  2941. } );
  2942. it( 'should handle text nodes', () => {
  2943. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2944. viewRoot._appendChild( viewP );
  2945. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2946. expect( renderer.markedChildren.size ).to.equal( 0 );
  2947. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2948. expect( renderer.markedTexts.size ).to.equal( 1 );
  2949. } );
  2950. it( 'should handle document fragment', () => {
  2951. const fragment = new DocumentFragment();
  2952. renderer._markDescendantTextToSync( fragment );
  2953. expect( renderer.markedChildren.size ).to.equal( 0 );
  2954. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2955. expect( renderer.markedTexts.size ).to.equal( 0 );
  2956. } );
  2957. it( 'should handle empty element nodes', () => {
  2958. const viewP = parse( '<container:p></container:p>' );
  2959. viewRoot._appendChild( viewP );
  2960. renderer._markDescendantTextToSync( viewP );
  2961. expect( renderer.markedChildren.size ).to.equal( 0 );
  2962. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2963. expect( renderer.markedTexts.size ).to.equal( 0 );
  2964. } );
  2965. } );
  2966. describe( '_updateText', () => {
  2967. let viewRoot, domRoot;
  2968. beforeEach( () => {
  2969. viewRoot = new ViewElement( viewDocument, 'div' );
  2970. domRoot = document.createElement( 'div' );
  2971. document.body.appendChild( domRoot );
  2972. domConverter.bindElements( domRoot, viewRoot );
  2973. renderer.markedTexts.clear();
  2974. renderer.markedAttributes.clear();
  2975. renderer.markedChildren.clear();
  2976. renderer.isFocused = true;
  2977. } );
  2978. afterEach( () => {
  2979. domRoot.remove();
  2980. } );
  2981. it( 'should update text - change on end', () => {
  2982. const viewText = new ViewText( viewDocument, 'foo' );
  2983. viewRoot._appendChild( viewText );
  2984. renderer.markToSync( 'children', viewRoot );
  2985. renderer.render();
  2986. expect( domRoot.childNodes.length ).to.equal( 1 );
  2987. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2988. viewText._data = 'fobar';
  2989. renderer._updateText( viewText, {} );
  2990. expect( domRoot.childNodes.length ).to.equal( 1 );
  2991. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2992. } );
  2993. it( 'should update text - change on start', () => {
  2994. const viewText = new ViewText( viewDocument, 'foo' );
  2995. viewRoot._appendChild( viewText );
  2996. renderer.markToSync( 'children', viewRoot );
  2997. renderer.render();
  2998. expect( domRoot.childNodes.length ).to.equal( 1 );
  2999. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3000. viewText._data = 'baro';
  3001. renderer._updateText( viewText, {} );
  3002. expect( domRoot.childNodes.length ).to.equal( 1 );
  3003. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  3004. } );
  3005. it( 'should update text - change in the middle', () => {
  3006. const viewText = new ViewText( viewDocument, 'foobar' );
  3007. viewRoot._appendChild( viewText );
  3008. renderer.markToSync( 'children', viewRoot );
  3009. renderer.render();
  3010. expect( domRoot.childNodes.length ).to.equal( 1 );
  3011. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  3012. viewText._data = 'fobazr';
  3013. renderer._updateText( viewText, {} );
  3014. expect( domRoot.childNodes.length ).to.equal( 1 );
  3015. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  3016. } );
  3017. it( 'should update text - empty expected', () => {
  3018. const viewText = new ViewText( viewDocument, 'foo' );
  3019. viewRoot._appendChild( viewText );
  3020. renderer.markToSync( 'children', viewRoot );
  3021. renderer.render();
  3022. expect( domRoot.childNodes.length ).to.equal( 1 );
  3023. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3024. viewText._data = '';
  3025. renderer._updateText( viewText, {} );
  3026. expect( domRoot.childNodes.length ).to.equal( 1 );
  3027. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3028. } );
  3029. it( 'should update text - empty actual', () => {
  3030. const viewText = new ViewText( viewDocument, '' );
  3031. viewRoot._appendChild( viewText );
  3032. renderer.markToSync( 'children', viewRoot );
  3033. renderer.render();
  3034. expect( domRoot.childNodes.length ).to.equal( 1 );
  3035. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3036. viewText._data = 'fobar';
  3037. renderer._updateText( viewText, {} );
  3038. expect( domRoot.childNodes.length ).to.equal( 1 );
  3039. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  3040. } );
  3041. it( 'should handle filler during text modifications', () => {
  3042. const viewText = new ViewText( viewDocument, 'foo' );
  3043. viewRoot._appendChild( viewText );
  3044. renderer.markToSync( 'children', viewRoot );
  3045. renderer.render();
  3046. expect( domRoot.childNodes.length ).to.equal( 1 );
  3047. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3048. // 1. Insert filler.
  3049. renderer._updateText( viewText, {
  3050. inlineFillerPosition: {
  3051. parent: viewText.parent,
  3052. offset: 0
  3053. }
  3054. } );
  3055. expect( domRoot.childNodes.length ).to.equal( 1 );
  3056. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3057. // 2. Edit text - filler should be preserved.
  3058. viewText._data = 'barfoo';
  3059. renderer._updateText( viewText, {
  3060. inlineFillerPosition: {
  3061. parent: viewText.parent,
  3062. offset: 0
  3063. }
  3064. } );
  3065. expect( domRoot.childNodes.length ).to.equal( 1 );
  3066. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  3067. // 3. Remove filler.
  3068. renderer._updateText( viewText, {} );
  3069. expect( domRoot.childNodes.length ).to.equal( 1 );
  3070. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  3071. } );
  3072. it( 'should handle filler during text modifications - empty text', () => {
  3073. const viewText = new ViewText( viewDocument, '' );
  3074. viewRoot._appendChild( viewText );
  3075. renderer.markToSync( 'children', viewRoot );
  3076. renderer.render();
  3077. expect( domRoot.childNodes.length ).to.equal( 1 );
  3078. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3079. // 1. Insert filler.
  3080. renderer._updateText( viewText, {
  3081. inlineFillerPosition: {
  3082. parent: viewText.parent,
  3083. offset: 0
  3084. }
  3085. } );
  3086. expect( domRoot.childNodes.length ).to.equal( 1 );
  3087. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  3088. // 2. Edit text - filler should be preserved.
  3089. viewText._data = 'foo';
  3090. renderer._updateText( viewText, {
  3091. inlineFillerPosition: {
  3092. parent: viewText.parent,
  3093. offset: 0
  3094. }
  3095. } );
  3096. expect( domRoot.childNodes.length ).to.equal( 1 );
  3097. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3098. // 3. Remove filler.
  3099. viewText._data = '';
  3100. renderer._updateText( viewText, {} );
  3101. expect( domRoot.childNodes.length ).to.equal( 1 );
  3102. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3103. } );
  3104. it( 'should handle filler during text modifications inside inline element', () => {
  3105. const viewB = new ViewElement( viewDocument, 'b' );
  3106. const viewText = new ViewText( viewDocument, 'foo' );
  3107. viewB._appendChild( viewText );
  3108. viewRoot._appendChild( viewB );
  3109. renderer.markToSync( 'children', viewRoot );
  3110. renderer.render();
  3111. expect( domRoot.childNodes.length ).to.equal( 1 );
  3112. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3113. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3114. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  3115. // 1. Insert filler.
  3116. renderer._updateText( viewText, {
  3117. inlineFillerPosition: {
  3118. parent: viewText.parent,
  3119. offset: 0
  3120. }
  3121. } );
  3122. expect( domRoot.childNodes.length ).to.equal( 1 );
  3123. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3124. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3125. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3126. // 2. Edit text - filler should be preserved.
  3127. viewText._data = 'bar';
  3128. renderer._updateText( viewText, {
  3129. inlineFillerPosition: {
  3130. parent: viewText.parent,
  3131. offset: 0
  3132. }
  3133. } );
  3134. expect( domRoot.childNodes.length ).to.equal( 1 );
  3135. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3136. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3137. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  3138. // 3. Remove filler.
  3139. viewText._data = 'bar';
  3140. renderer._updateText( viewText, {} );
  3141. expect( domRoot.childNodes.length ).to.equal( 1 );
  3142. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3143. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3144. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  3145. } );
  3146. } );
  3147. } );
  3148. function renderAndExpectNoChanges( renderer, domRoot ) {
  3149. const config = {
  3150. childList: true,
  3151. characterData: true,
  3152. characterDataOldValue: true,
  3153. subtree: true
  3154. };
  3155. const mutationObserver = new window.MutationObserver( () => {
  3156. throw 'There should be not mutations';
  3157. } );
  3158. mutationObserver.observe( domRoot, config );
  3159. renderer.render();
  3160. const records = mutationObserver.takeRecords();
  3161. mutationObserver.disconnect();
  3162. expect( records.length ).to.equal( 0 );
  3163. }