ソースを参照

Removed focus class from image when caption editable is focused.

Szymon Kupś 8 年 前
コミット
d344096b4c

+ 0 - 15
packages/ckeditor5-image/src/widget/widgetengine.js

@@ -8,7 +8,6 @@
  */
 
 import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
-import RootEditable from '@ckeditor/ckeditor5-engine/src/view/rooteditableelement';
 import { WIDGET_SELECTED_CLASS_NAME, isWidget } from './utils';
 
 /**
@@ -36,20 +35,6 @@ export default class WidgetEngine extends Plugin {
 
 			const viewSelection = conversionApi.viewSelection;
 
-			// Add CSS class if selection is placed inside nested editable that belongs to widget.
-			const editableElement = viewSelection.editableElement;
-
-			if ( editableElement && !( editableElement instanceof RootEditable ) ) {
-				const widget = editableElement.findAncestor( element => isWidget( element ) );
-
-				if ( widget ) {
-					widget.addClass( WIDGET_SELECTED_CLASS_NAME );
-					previouslySelected = widget;
-
-					return;
-				}
-			}
-
 			// Check if widget was clicked or some sub-element.
 			const selectedElement = viewSelection.getSelectedElement();
 

+ 2 - 2
packages/ckeditor5-image/tests/imagecaption/imagecaptionengine.js

@@ -232,7 +232,7 @@ describe( 'ImageCaptionEngine', () => {
 			);
 		} );
 
-		it( 'should not remove figcatpion when selection is inside it even when it is empty', () => {
+		it( 'should not remove figcaption when selection is inside it even when it is empty', () => {
 			setModelData( document, '<image src=""><caption>[foo bar]</caption></image>' );
 
 			document.enqueueChanges( () => {
@@ -240,7 +240,7 @@ describe( 'ImageCaptionEngine', () => {
 			} );
 
 			expect( getViewData( viewDocument ) ).to.equal(
-				'<figure class="image ck-widget ck-widget_selected" contenteditable="false">' +
+				'<figure class="image ck-widget" contenteditable="false">' +
 					'<img src=""></img>' +
 					'<figcaption contenteditable="true">[]</figcaption>' +
 				'</figure>'

+ 0 - 10
packages/ckeditor5-image/tests/widget/widgetengine.js

@@ -68,16 +68,6 @@ describe( 'WidgetEngine', () => {
 		);
 	} );
 
-	it( 'should add selected class if selection is placed inside nested editable', () => {
-		setModelData( document, '<widget><editable>[foo bar]</editable></widget>' );
-
-		expect( getViewData( viewDocument ) ).to.equal(
-			'<div class="ck-widget ck-widget_selected" contenteditable="false">' +
-				'<figcaption contenteditable="true">{foo bar}</figcaption>' +
-			'</div>'
-		);
-	} );
-
 	it( 'should do nothing when selection is placed in other editable', () => {
 		setModelData( document, '<widget><editable>foo bar</editable></widget><editable>[baz]</editable>' );