ソースを参照

Apply suggestions from code review

Maciej 5 年 前
コミット
d17be23423

+ 1 - 1
packages/ckeditor5-image/tests/imageinsert/ui/imageinsertpanelview.js

@@ -313,7 +313,7 @@ describe( 'ImageUploadPanelView', () => {
 			const form = view.getIntegration( 'insertImageViaUrl' );
 			const saveButtonView = view.template.children[ 1 ].children.first;
 
-			expect( !!saveButtonView.isEnabled ).to.be.false;
+			expect( saveButtonView.isEnabled ).to.be.false;
 
 			form.fieldView.element.value = 'test';
 			form.fieldView.fire( 'input' );

+ 1 - 1
packages/ckeditor5-media-embed/src/ui/mediaformview.js

@@ -79,7 +79,7 @@ export default class MediaFormView extends View {
 		 */
 		this.saveButtonView = this._createButton( t( 'Save' ), checkIcon, 'ck-button-save' );
 		this.saveButtonView.type = 'submit';
-		this.saveButtonView.bind( 'isEnabled' ).to( this, 'mediaURLInputValue' );
+		this.saveButtonView.bind( 'isEnabled' ).to( this, 'mediaURLInputValue', value => !!value );
 
 		/**
 		 * The Cancel button view.

+ 2 - 2
packages/ckeditor5-media-embed/tests/mediaembedui.js

@@ -224,12 +224,12 @@ describe( 'MediaEmbedUI', () => {
 		it( 'binds saveButtonView#isEnabled to trimmed URL input value', () => {
 			form.urlInputView.fieldView.fire( 'input' );
 
-			expect( !!form.saveButtonView.isEnabled ).to.be.false;
+			expect( form.saveButtonView.isEnabled ).to.be.false;
 
 			form.urlInputView.fieldView.element.value = 'test';
 			form.urlInputView.fieldView.fire( 'input' );
 
-			expect( !!form.saveButtonView.isEnabled ).to.be.true;
+			expect( form.saveButtonView.isEnabled ).to.be.true;
 		} );
 
 		describe( 'validators', () => {