瀏覽代碼

Renamed `willDataChange` to `hasDataChanges`.

Maciej Bukowski 7 年之前
父節點
當前提交
51af75c154

+ 3 - 3
packages/ckeditor5-engine/src/model/differ.js

@@ -247,11 +247,11 @@ export default class Differ {
 	}
 
 	/**
-	 * Checks whether some of buffered marker affects the data model or whether some element will change.
+	 * Checks whether some of buffered marker affects the data model or whether some element changed.
 	 *
-	 * @returns {Boolean} `true` if buffered markers or changes in elements will affect the data model.
+	 * @returns {Boolean} `true` if buffered markers or changes in elements affects the data model.
 	 */
-	willDataChange() {
+	hasDataChanges() {
 		for ( const [ , change ] of this._changedMarkers ) {
 			if ( change.affectsData ) {
 				return true;

+ 1 - 1
packages/ckeditor5-engine/src/model/document.js

@@ -152,7 +152,7 @@ export default class Document {
 			if ( !this.differ.isEmpty || hasSelectionChanged ) {
 				this._callPostFixers( writer );
 
-				if ( this.differ.willDataChange() ) {
+				if ( this.differ.hasDataChanges() ) {
 					this.fire( 'change:data', writer.batch );
 				} else {
 					this.fire( 'change', writer.batch );

+ 5 - 5
packages/ckeditor5-engine/tests/model/differ.js

@@ -1308,13 +1308,13 @@ describe( 'Differ', () => {
 		it( 'add marker not affecting data', () => {
 			differ.bufferMarkerChange( 'name', range, rangeB, false );
 
-			expect( differ.willDataChange() ).to.be.false;
+			expect( differ.hasDataChanges() ).to.be.false;
 		} );
 
 		it( 'add marker affecting data', () => {
 			differ.bufferMarkerChange( 'name', range, rangeB, true );
 
-			expect( differ.willDataChange() ).to.be.true;
+			expect( differ.hasDataChanges() ).to.be.true;
 		} );
 
 		it( 'add marker and remove it', () => {
@@ -1323,7 +1323,7 @@ describe( 'Differ', () => {
 
 			expect( differ.getMarkersToRemove() ).to.deep.equal( [] );
 			expect( differ.getMarkersToAdd() ).to.deep.equal( [] );
-			expect( differ.willDataChange() ).to.be.false;
+			expect( differ.hasDataChanges() ).to.be.false;
 		} );
 
 		it( 'add marker and change it', () => {
@@ -1341,7 +1341,7 @@ describe( 'Differ', () => {
 			differ.bufferMarkerChange( 'name', range, rangeB, true );
 			differ.bufferMarkerChange( 'name', range, rangeB, false );
 
-			expect( differ.willDataChange() ).to.be.false;
+			expect( differ.hasDataChanges() ).to.be.false;
 		} );
 
 		it( 'change marker and remove it', () => {
@@ -1353,7 +1353,7 @@ describe( 'Differ', () => {
 			] );
 
 			expect( differ.getMarkersToAdd() ).to.deep.equal( [] );
-			expect( differ.willDataChange() ).to.be.true;
+			expect( differ.hasDataChanges() ).to.be.true;
 		} );
 
 		it( 'remove marker and add it at same range', () => {